Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GovCloud ELB hosted zone IDs #12976

Merged
merged 1 commit into from
Apr 28, 2020
Merged

GovCloud ELB hosted zone IDs #12976

merged 1 commit into from
Apr 28, 2020

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Apr 23, 2020

https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/CONTRIBUTING.md#new-region

No reason to stop at just new regions:
#12967
#13061

working on getting these documented as well :)

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

us-gov-east-1 and us-gov-west-1 ELB hosted zone IDs

@PatMyron PatMyron requested a review from a team April 23, 2020 21:35
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/elb Issues and PRs that pertain to the elb service. labels Apr 23, 2020
@ewbankkit
Copy link
Contributor

ewbankkit commented Apr 23, 2020

@PatMyron Thanks for this.
Could you add the URL where you obtained these from to the comments if that's publicly accessible.

I know the other URLs in the comments may now be stale 😄.

@PatMyron
Copy link
Contributor Author

PatMyron commented Apr 23, 2020

if that's publicly accessible

Still working on this part :)

@ewbankkit @bflad done

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 24, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for getting this documented and added! 🚀

@bflad bflad added this to the v2.60.0 milestone Apr 28, 2020
@bflad bflad merged commit 3a2880a into hashicorp:master Apr 28, 2020
bflad added a commit that referenced this pull request Apr 28, 2020
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elb Issues and PRs that pertain to the elb service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants