Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/kms: Update acceptance tests to use ARN testing check functions #12989

Merged
merged 2 commits into from
Apr 29, 2020
Merged

service/kms: Update acceptance tests to use ARN testing check functions #12989

merged 2 commits into from
Apr 29, 2020

Conversation

gdavison
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11888

Release note for CHANGELOG:

NONE

Previously:

terraform-provider-aws/aws/data_source_aws_kms_alias_test.go:26:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
terraform-provider-aws/aws/data_source_aws_kms_alias_test.go:28:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsKmsAlias_AwsService (18.62s)
--- PASS: TestAccDataSourceAwsKmsAlias_CMK (42.67s)

@gdavison gdavison requested a review from a team April 24, 2020 00:23
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. service/kms Issues and PRs that pertain to the kms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 24, 2020
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 24, 2020
bflad
bflad approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although we can simplify the AWS service alias checks instead of ignoring the linter.

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsKmsAlias_AwsService (8.28s)
--- PASS: TestAccDataSourceAwsKmsAlias_CMK (27.29s)

aws/data_source_aws_kms_alias_test.go
@@ -64,49 +67,6 @@ func testAccDataSourceAwsKmsAliasCheckExists(name string) resource.TestCheckFunc
}
}

func testAccDataSourceAwsKmsAliasCheckCMKAttributes(aliasResourceName, datasourceAliasResourceName string) resource.TestCheckFunc {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

aws/data_source_aws_kms_alias_test.go Outdated Show resolved Hide resolved
@gdavison @bflad
Removes some lintignore directives
c00f56e 
Co-Authored-By: Brian Flad <bflad417@gmail.com>
@gdavison gdavison merged commit 726947d into master Apr 29, 2020
@gdavison gdavison deleted the t-clean-up-kms-arn-tests branch April 29, 2020 23:08
@gdavison gdavison added this to the v2.60.0 milestone Apr 30, 2020
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 30, 2020
@breathingdust breathingdust added the linter Pertains to changes to or issues with the various linters. label Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. service/kms Issues and PRs that pertain to the kms service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.60.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gdavison @bflad @breathingdust