Support MongoDB connection type for AWS Glue

[drexler]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13007

Release note for CHANGELOG:

support MongoDB connection type for AWS Glue

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueConnection_MongoDB'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueConnection_MongoDB -timeout 120m
=== RUN   TestAccAWSGlueConnection_MongoDB
=== PAUSE TestAccAWSGlueConnection_MongoDB
=== CONT  TestAccAWSGlueConnection_MongoDB
--- PASS: TestAccAWSGlueConnection_MongoDB (15.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.208s


...

[anGie44]

PR looks great @drexler, thank you!
only small note on the formatting of the embedded config block and I think it'd be helpful to document the newly supported connection_type in glue_connection.html.markdown (e.g. "Supported: JDBC, SFTP, MONGODB")

Output of acceptance test:

=== RUN   TestAccAWSGlueConnection_MongoDB
=== PAUSE TestAccAWSGlueConnection_MongoDB
=== CONT  TestAccAWSGlueConnection_MongoDB
--- PASS: TestAccAWSGlueConnection_MongoDB (18.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.790s

[drexler]

Thanks for the review @anGie44. I've updated the PR and added the documentation snippet.

I think it'd be helpful to document the newly supported connection_type in glue_connection.html.markdown (e.g. "Supported: JDBC, SFTP, MONGODB")

Interestingly enough SFTP is not supported with the Go SDK so omitted that from the documentation. Should i file a follow-up issue to remove it from the resource validation check? Alternatively, i could do it as part of this PR - it doesn't seem to be a breaking change to do so.

[anGie44]

@drexler interesting! hmm seems like the online dev-guide docs haven't been updated.. yes, please file a follow-up issue so we have it documented. thanks for investigating :)

I also just created an issue to support the Kafka connection_type since you brought up the API docs 🙏
#13038

[drexler]

@anGie44 issue for SFTP connection support created.

[bflad]

LGTM 🚀

--- PASS: TestAccAWSGlueConnection_MongoDB (9.03s)
--- PASS: TestAccAWSGlueConnection_Basic (9.25s)
--- PASS: TestAccAWSGlueConnection_Description (14.38s)
--- PASS: TestAccAWSGlueConnection_MatchCriteria (19.46s)
--- PASS: TestAccAWSGlueConnection_PhysicalConnectionRequirements (642.30s)

[ghost]

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!