Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/codepipeline: Update acceptance test with ARN testing check function #13041

Merged
merged 3 commits into from
Apr 29, 2020

Conversation

gdavison
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11888

Release note for CHANGELOG:

NONE

Tightens up ARN regex and improves some tests. (This PR got sniped)

Output from acceptance testing:

--- PASS: TestAccAWSCodePipeline_emptyStageArtifacts (39.15s)
--- PASS: TestAccAWSCodePipeline_deployWithServiceRole (40.88s)
--- PASS: TestAccAWSCodePipeline_multiregion_basic (52.54s)
--- PASS: TestAccAWSCodePipeline_basic (61.66s)
--- PASS: TestAccAWSCodePipeline_multiregion_Update (69.94s)
--- PASS: TestAccAWSCodePipeline_tags (71.28s)
--- PASS: TestAccAWSCodePipeline_multiregion_ConvertSingleRegion (93.59s)

@gdavison gdavison requested a review from a team April 27, 2020 18:34
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/codepipeline Issues and PRs that pertain to the codepipeline service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 27, 2020
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 28, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing (#9950 covers linting test names without underscores):

--- PASS: TestAccAWSCodePipeline_basic (46.02s)
--- PASS: TestAccAWSCodePipeline_deployWithServiceRole (42.39s)
--- PASS: TestAccAWSCodePipeline_emptyStageArtifacts (27.98s)
--- PASS: TestAccAWSCodePipeline_multiregion_basic (43.90s)
--- PASS: TestAccAWSCodePipeline_multiregion_ConvertSingleRegion (60.34s)
--- PASS: TestAccAWSCodePipeline_multiregion_Update (58.82s)
--- PASS: TestAccAWSCodePipeline_tags (53.93s)
--- PASS: TestAccAWSCodePipelineWithNamespace (25.52s)

@gdavison gdavison merged commit 5650ee2 into master Apr 29, 2020
@gdavison gdavison deleted the t-clean-up-codepipeline-arn-tests branch April 29, 2020 22:01
@gdavison gdavison added this to the v2.60.0 milestone Apr 30, 2020
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/codepipeline Issues and PRs that pertain to the codepipeline service. size/L Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants