Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ami_launch_permission: Remove extraneous Exists function #13043

Merged

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9953.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAMILaunchPermission_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAMILaunchPermission_ -timeout 120m
=== RUN   TestAccAWSAMILaunchPermission_Basic
=== PAUSE TestAccAWSAMILaunchPermission_Basic
=== RUN   TestAccAWSAMILaunchPermission_Disappears_LaunchPermission
=== PAUSE TestAccAWSAMILaunchPermission_Disappears_LaunchPermission
=== RUN   TestAccAWSAMILaunchPermission_Disappears_LaunchPermission_Public
=== PAUSE TestAccAWSAMILaunchPermission_Disappears_LaunchPermission_Public
=== RUN   TestAccAWSAMILaunchPermission_Disappears_AMI
=== PAUSE TestAccAWSAMILaunchPermission_Disappears_AMI
=== CONT  TestAccAWSAMILaunchPermission_Basic
=== CONT  TestAccAWSAMILaunchPermission_Disappears_LaunchPermission_Public
=== CONT  TestAccAWSAMILaunchPermission_Disappears_AMI
=== CONT  TestAccAWSAMILaunchPermission_Disappears_LaunchPermission
--- PASS: TestAccAWSAMILaunchPermission_Basic (355.36s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission_Public (356.82s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission (356.85s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_AMI (372.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	372.143s

@ewbankkit ewbankkit requested a review from a team April 27, 2020 19:14
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. labels Apr 27, 2020
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 28, 2020
@appilon appilon added this to the v2.60.0 milestone Apr 29, 2020
@appilon appilon merged commit d334d9b into hashicorp:master Apr 29, 2020
@ewbankkit ewbankkit deleted the issue-9953.aws_ami_launch_permission branch April 29, 2020 11:07
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants