Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to renamed validation func ValidateJsonString --> StringIsJSON #13069

Closed
wants to merge 1 commit into from
Closed

switch to renamed validation func ValidateJsonString --> StringIsJSON #13069

wants to merge 1 commit into from

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Apr 28, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11844

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@appilon appilon requested a review from a team April 28, 2020 19:26
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. labels Apr 28, 2020
@appilon
Copy link
Contributor Author

appilon commented Apr 28, 2020

@bflad Are you happy with the code compiling or did you want me to run down the affected acctests? Previous func just called this one directly

@bflad
Copy link
Contributor

bflad commented Apr 28, 2020

Is this replacing #12378?

@appilon
Copy link
Contributor Author

appilon commented Apr 28, 2020

:back-away-slowly: Sorry the PR got buried in my inbox let's merge yours!

@appilon appilon closed this Apr 28, 2020
@appilon appilon deleted the appilon/switch-deprecated-validators branch April 28, 2020 19:31
@ghost ghost added service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/configservice Issues and PRs that pertain to the configservice service. service/databasemigrationservice service/ec2 Issues and PRs that pertain to the ec2 service. service/ecr Issues and PRs that pertain to the ecr service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/emr Issues and PRs that pertain to the emr service. service/glacier Issues and PRs that pertain to the glacier service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/organizations Issues and PRs that pertain to the organizations service. service/s3 Issues and PRs that pertain to the s3 service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/ses Issues and PRs that pertain to the ses service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. labels Apr 28, 2020
@ghost
Copy link

ghost commented May 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 29, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/configservice Issues and PRs that pertain to the configservice service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecr Issues and PRs that pertain to the ecr service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/emr Issues and PRs that pertain to the emr service. service/glacier Issues and PRs that pertain to the glacier service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/organizations Issues and PRs that pertain to the organizations service. service/s3 Issues and PRs that pertain to the s3 service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/ses Issues and PRs that pertain to the ses service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tech debt: Replace use of deprecated plugin SDK validation functions
3 participants
@appilon @bflad @breathingdust