Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP datasource authorization_config fields. #13080

Closed
wants to merge 5 commits into from

Conversation

maddijoyce
Copy link

@maddijoyce maddijoyce commented Apr 29, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12721 #9628

Release note for CHANGELOG:

resource/aws_appsync_graphql_api: Add `authorization_config` block to `http_config`

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsAppsyncDatasource_HTTPConfig'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAppsyncDatasource_HTTPConfig -timeout 120m
=== RUN   TestAccAwsAppsyncDatasource_HTTPConfig_AuthorizationConfig
=== PAUSE TestAccAwsAppsyncDatasource_HTTPConfig_AuthorizationConfig
=== RUN   TestAccAwsAppsyncDatasource_HTTPConfig_Endpoint
=== PAUSE TestAccAwsAppsyncDatasource_HTTPConfig_Endpoint
=== CONT  TestAccAwsAppsyncDatasource_HTTPConfig_AuthorizationConfig
=== CONT  TestAccAwsAppsyncDatasource_HTTPConfig_Endpoint
--- PASS: TestAccAwsAppsyncDatasource_HTTPConfig_AuthorizationConfig (45.24s)
--- PASS: TestAccAwsAppsyncDatasource_HTTPConfig_Endpoint (65.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.791s

@maddijoyce maddijoyce requested a review from a team April 29, 2020 10:08
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. service/appsync Issues and PRs that pertain to the appsync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Apr 29, 2020
@Callumccr
Copy link

This is definitely needed!

@maddijoyce
Copy link
Author

@bflad Sorry if you're the wrong person to ping on this, but I'm wondering what the chances of this getting into the aws provider are?

@maddijoyce maddijoyce requested a review from a team as a code owner November 17, 2020 23:55
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Nov 18, 2020
Base automatically changed from master to main January 23, 2021 00:57
@ignaciopeixoto
Copy link

Is this stuck just because some linting failed?

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 21, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@ewbankkit
Copy link
Contributor

Superseded by #22411.

@ewbankkit ewbankkit closed this Jan 9, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/appsync Issues and PRs that pertain to the appsync service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add authorization_config to http_config for aws_appsync_datasource
6 participants