service/secretsmanager: Update acceptance tests to use ARN testing check functions

[gdavison]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11888

Release note for CHANGELOG:

NONE

Previously:

aws/resource_aws_secretsmanager_secret_test.go:81:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_secretsmanager_secret_test.go:116:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_secretsmanager_secret_test.go:249:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_secretsmanager_secret_version_test.go:33:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_secretsmanager_secret_version_test.go:64:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)

Output from acceptance testing:

--- PASS: TestAccAwsSecretsManagerSecret_policy (17.47s)
--- PASS: TestAccAwsSecretsManagerSecret_Basic (19.59s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (20.10s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (31.28s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (35.90s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (55.29s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (57.99s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (60.14s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (66.59s)

--- PASS: TestAccAwsSecretsManagerSecretVersion_Base64Binary (18.69s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_BasicString (20.54s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_VersionStages (44.35s)

[bflad]

LGTM 🚀 Created #13181 for some unrelated flakiness I saw with CheckDestroy while testing this.

Output from acceptance testing:

--- PASS: TestAccAwsSecretsManagerSecret_policy (16.55s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (17.82s)
--- PASS: TestAccAwsSecretsManagerSecret_Basic (18.49s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_BasicString (19.02s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_Base64Binary (19.59s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (29.24s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (38.04s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_VersionStages (43.34s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (52.72s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (65.81s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (66.03s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (75.98s)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!