service/lambda: Update acceptance tests to use ARN testing check functions

[gdavison]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11888

Release note for CHANGELOG:

NONE

Previously:

aws/resource_aws_lambda_alias_test.go:38:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_lambda_event_source_mapping_test.go:57:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_lambda_event_source_mapping_test.go:154:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_lambda_event_source_mapping_test.go:185:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_lambda_function_test.go:86:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_lambda_function_test.go:408:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_lambda_function_test.go:462:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_lambda_function_test.go:480:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
aws/resource_aws_lambda_permission_test.go:477:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)

Output from acceptance testing:

--- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (2.71s)
--- PASS: TestAccAWSLambdaFunction_s3 (43.99s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby27 (56.12s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (60.04s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_dotnetcore31 (62.49s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (63.08s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (72.80s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x (79.24s)
--- PASS: TestAccAWSLambdaFunction_basic (85.89s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs12x (91.09s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python38 (95.94s)
--- PASS: TestAccAWSLambdaFunction_tags (98.99s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (103.83s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java11 (109.80s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (115.31s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby25 (119.91s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (129.47s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (132.50s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (134.55s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (133.19s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (99.24s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (144.93s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (19.18s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (521.50s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (544.52s)
--- PASS: TestAccAWSLambdaFunction_Layers (533.74s)
--- PASS: TestAccAWSLambdaFunction_versioned (534.02s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (554.61s)
--- PASS: TestAccAWSLambdaFunction_envVariables (584.96s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (524.27s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (556.37s)
--- PASS: TestAccAWSLambdaFunction_concurrency (547.00s)
--- PASS: TestAccAWSLambdaFunction_disappears (533.36s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (565.91s)
--- PASS: TestAccAWSLambdaFunction_updateRuntime (555.44s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (560.31s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (601.44s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (1907.91s)
--- PASS: TestAccAWSLambdaFunction_VPC (1921.26s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (2425.53s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (2582.79s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (2612.86s)

--- PASS: TestAccAWSLambdaAlias_basic (55.94s)
--- PASS: TestAccAWSLambdaAlias_nameupdate (69.84s)
--- PASS: TestAccAWSLambdaAlias_routingconfig (76.84s)

--- PASS: TestAccAWSLambdaPermission_withIAMRole (36.76s)
--- PASS: TestAccAWSLambdaPermission_withRawFunctionName (42.17s)
--- PASS: TestAccAWSLambdaPermission_basic (48.05s)
--- PASS: TestAccAWSLambdaPermission_withStatementIdPrefix (54.62s)
--- PASS: TestAccAWSLambdaPermission_withQualifier (66.74s)
--- PASS: TestAccAWSLambdaPermission_withS3 (79.80s)
--- PASS: TestAccAWSLambdaPermission_withSNS (83.03s)
--- PASS: TestAccAWSLambdaPermission_multiplePerms (105.84s)
--- PASS: TestAccAWSLambdaPermission_StatementId_Duplicate (111.36s)
--- PASS: TestAccAWSLambdaPermission_disappears (129.61s)

--- PASS: TestAccAWSLambdaEventSourceMapping_StartingPositionTimestamp (63.03s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName (65.31s)
--- PASS: TestAccAWSLambdaEventSourceMapping_KinesisDestinationConfig (78.50s)
--- PASS: TestAccAWSLambdaEventSourceMapping_BatchWindow (81.72s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (107.56s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (117.73s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRecordAgeInSeconds (120.61s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRetryAttempts (127.27s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_basic (137.81s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize (148.62s)
--- PASS: TestAccAWSLambdaEventSourceMapping_ParallelizationFactor (153.08s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_disappears (155.62s)
--- PASS: TestAccAWSLambdaEventSourceMapping_BisectBatch (157.76s)
--- PASS: TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected (182.63s)

[anGie44]

LGTM 👍
Output of acceptance tests in TC:

--- PASS: TestAccAWSLambdaFunction_*
--- PASS: TestAccAWSLambdaPermission_*
--- PASS: TestAccAWSLambdaEventSourceMapping_*
--- PASS: TestLambdaPermissionGetFunctionName*
--- PASS: TestLambdaPermissionUnmarshalling
--- PASS: TestAccAWSLambdaAlias_*
--- PASS: TestAccAWSProvider_*
--- PASS: TestAccAWSLambdaFunctionEventInvokeConfig_*

With exception of (though when run locally, passed) :

--- FAIL: TestAccAWSLambdaEventSourceMapping_MaximumRetryAttempts
--- FAIL: TestAccAWSLambdaFunction_VPCRemoval

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!