Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synthetics - new service #13186

Merged
merged 6 commits into from
May 15, 2020
Merged

Synthetics - new service #13186

merged 6 commits into from
May 15, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11145

Release note for CHANGELOG:

add new service synthetics service support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@DrFaust92 DrFaust92 requested a review from a team May 6, 2020 15:46
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. dependencies Used to indicate dependency changes. labels May 6, 2020
@DrFaust92 DrFaust92 mentioned this pull request May 6, 2020
Merged
bflad
bflad reviewed May 6, 2020
View reviewed changes
aws/provider.go Outdated Show resolved Hide resolved
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label May 7, 2020
@bflad bflad self-assigned this May 7, 2020
@bflad bflad added this to the v2.62.0 milestone May 14, 2020
@bflad
Copy link
Contributor

bflad commented May 14, 2020

Hi @DrFaust92 👋 Can you please add the website/ additions from this checklist? Thanks. https://github.com/terraform-providers/terraform-provider-aws/blob/master/docs/contributing/contribution-checklists.md#new-service

@breathingdust breathingdust modified the milestones: v2.62.0, v2.63.0 May 14, 2020
@ghost ghost added the documentation Introduces or discusses updates to documentation. label May 15, 2020
bflad
bflad approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will add website/allowed-subcategories.txt on merge 🚀

@bflad bflad merged commit 9a89bc7 into hashicorp:master May 15, 2020
@ghost
Copy link

ghost commented May 22, 2020

This has been released in version 2.63.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

adamdecaf pushed a commit to adamdecaf/terraform-provider-aws that referenced this pull request May 28, 2020
@DrFaust92 @adamdecaf
service/synthetics: Add service client (hashicorp#13186)
aa33c06
@ghost
Copy link

ghost commented Jun 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 14, 2020
@DrFaust92 DrFaust92 deleted the synthetics branch June 23, 2020 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.63.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @bflad @breathingdust