Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/organizations: Update acceptance tests to use ARN testing check functions #13270

Merged
merged 2 commits into from
May 26, 2020
Merged

service/organizations: Update acceptance tests to use ARN testing check functions #13270

merged 2 commits into from
May 26, 2020

Conversation

gdavison
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11888

Release note for CHANGELOG:

NONE

Previously:

aws/resource_aws_organizations_policy_test.go:31:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)

Output from acceptance testing:

--- PASS: TestAccAWSOrganizations (32.68s)
    --- PASS: TestAccAWSOrganizations/PolicyAttachment (7.66s)
        --- SKIP: TestAccAWSOrganizations/PolicyAttachment/Account (3.13s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
        --- SKIP: TestAccAWSOrganizations/PolicyAttachment/OrganizationalUnit (2.63s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
        --- SKIP: TestAccAWSOrganizations/PolicyAttachment/Root (1.90s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
    --- PASS: TestAccAWSOrganizations/Organization (9.63s)
        --- SKIP: TestAccAWSOrganizations/Organization/basic (1.97s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
        --- SKIP: TestAccAWSOrganizations/Organization/AwsServiceAccessPrincipals (1.87s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
        --- SKIP: TestAccAWSOrganizations/Organization/EnabledPolicyTypes (1.92s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
        --- SKIP: TestAccAWSOrganizations/Organization/FeatureSet (1.92s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
        --- SKIP: TestAccAWSOrganizations/Organization/DataSource (1.95s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
    --- PASS: TestAccAWSOrganizations/Account (0.00s)
        --- SKIP: TestAccAWSOrganizations/Account/basic (0.00s)
            resource_aws_organizations_account_test.go:15: AWS Organizations Account testing is not currently automated due to manual account deletion steps.
        --- SKIP: TestAccAWSOrganizations/Account/ParentId (0.00s)
            resource_aws_organizations_account_test.go:58: AWS Organizations Account testing is not currently automated due to manual account deletion steps.
        --- SKIP: TestAccAWSOrganizations/Account/Tags (0.00s)
            resource_aws_organizations_account_test.go:104: AWS Organizations Account testing is not currently automated due to manual account deletion steps.
    --- PASS: TestAccAWSOrganizations/OrganizationalUnit (3.98s)
        --- SKIP: TestAccAWSOrganizations/OrganizationalUnit/basic (2.00s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
        --- SKIP: TestAccAWSOrganizations/OrganizationalUnit/Name (1.98s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
    --- PASS: TestAccAWSOrganizations/OrganizationalUnits (0.00s)
        --- SKIP: TestAccAWSOrganizations/OrganizationalUnits/DataSource (1.83s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
    --- PASS: TestAccAWSOrganizations/Policy (9.58s)
        --- SKIP: TestAccAWSOrganizations/Policy/concurrent (2.03s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
        --- SKIP: TestAccAWSOrganizations/Policy/Description (2.84s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
        --- SKIP: TestAccAWSOrganizations/Policy/Type (2.78s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization
        --- SKIP: TestAccAWSOrganizations/Policy/basic (1.94s)
            provider_test.go:450: skipping tests; this AWS account must not be an existing member of an AWS Organization

These tests are expected to be skipped

@gdavison
Updates Organizations acceptance tests to use ARN testing check funct…
c818bd0 
…ions

Addresses:
aws/resource_aws_organizations_policy_test.go:31:6: AWSAT001: prefer resource.TestCheckResourceAttrPair() or ARN check functions (e.g. testAccMatchResourceAttrRegionalARN)
@gdavison gdavison requested a review from a team May 11, 2020 21:42
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/organizations Issues and PRs that pertain to the organizations service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 11, 2020
@gdavison gdavison added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label May 11, 2020
@bflad bflad self-assigned this May 13, 2020
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label May 13, 2020
@gdavison @bflad
Removes old test check
eefe929 
Co-authored-by: Brian Flad <bflad417@gmail.com>
@gdavison gdavison removed the waiting-response Maintainers are waiting on response from community or contributor. label May 21, 2020
bflad
bflad approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

Output from acceptance testing:

    --- PASS: TestAccAWSOrganizations/Policy (127.80s)
        --- PASS: TestAccAWSOrganizations/Policy/basic (30.20s)
        --- PASS: TestAccAWSOrganizations/Policy/concurrent (27.65s)
        --- PASS: TestAccAWSOrganizations/Policy/Description (29.68s)
        --- PASS: TestAccAWSOrganizations/Policy/Type (40.27s)

@gdavison gdavison merged commit 3cfeb07 into master May 26, 2020
@gdavison gdavison deleted the t-clean-up-organizations-arn-tests branch May 26, 2020 22:50
@gdavison gdavison added this to the v2.64.0 milestone May 27, 2020
@ghost
Copy link

ghost commented May 29, 2020

This has been released in version 2.64.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jun 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/organizations Issues and PRs that pertain to the organizations service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.64.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @bflad