Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws_workspaces_workspace Examples Check linting error #13300

Merged
merged 1 commit into from
May 13, 2020

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented May 13, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Fixes error:

Error: Invalid resource name

  on main.tf line 40, in resource "aws_workspaces_workspace" "jhon.doe":
  40: resource "aws_workspaces_workspace" "jhon.doe" {

A name must start with a letter or underscore and may contain only letters,
digits, underscores, and dashes.

Relates #11608.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

n/a

Error: Invalid resource name

  on main.tf line 40, in resource "aws_workspaces_workspace" "jhon.doe":
  40: resource "aws_workspaces_workspace" "jhon.doe" {

A name must start with a letter or underscore and may contain only letters,
digits, underscores, and dashes.
@ewbankkit ewbankkit requested a review from a team May 13, 2020 12:19
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels May 13, 2020
@ewbankkit ewbankkit changed the title Fix Examples Check linting error Fix aws_workspaces_workspace Examples Check linting error May 13, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label May 13, 2020
@bflad bflad added this to the v2.62.0 milestone May 13, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, these should get caught by the GitHub Actions workflow during PRs going forward. 🚀

@bflad bflad merged commit 5e576da into hashicorp:master May 13, 2020
@ewbankkit ewbankkit deleted the patch-2 branch May 13, 2020 15:10
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.62.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

adamdecaf pushed a commit to adamdecaf/terraform-provider-aws that referenced this pull request May 28, 2020
Error: Invalid resource name

  on main.tf line 40, in resource "aws_workspaces_workspace" "jhon.doe":
  40: resource "aws_workspaces_workspace" "jhon.doe" {

A name must start with a letter or underscore and may contain only letters,
digits, underscores, and dashes.
@ghost
Copy link

ghost commented Jun 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants