Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update acceptance tests with ARN values #13498

Merged
merged 14 commits into from
Jun 1, 2020
Merged

Update acceptance tests with ARN values #13498

merged 14 commits into from
Jun 1, 2020

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented May 26, 2020 •
edited
Loading

Description

These ARN checks are not caught by AWSAT001

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11888
Relates #13363

Release note for CHANGELOG:

NONE

Output from acceptance testing:

--- PASS: TestAccAWSAPIGatewayAuthorizer_authTypeValidation (88.28s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_basic (208.81s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_cognito (27.43s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_disappears (117.96s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_switchAuthType (57.20s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_switchAuthorizerTTL (136.58s)

--- PASS: TestAccAWSBillingServiceAccount_basic (13.31s)

--- PASS: TestAccAWSCloudTrail (261.78s)
    --- PASS: TestAccAWSCloudTrail/Trail (261.78s)
        --- PASS: TestAccAWSCloudTrail/Trail/basic (33.52s)
        --- PASS: TestAccAWSCloudTrail/Trail/cloudwatch (48.59s)
        --- PASS: TestAccAWSCloudTrail/Trail/isMultiRegion (27.97s)
        --- SKIP: TestAccAWSCloudTrail/Trail/isOrganization (1.08s)
        --- PASS: TestAccAWSCloudTrail/Trail/tags (29.49s)
        --- PASS: TestAccAWSCloudTrail/Trail/eventSelector (43.62s)
        --- PASS: TestAccAWSCloudTrail/Trail/enableLogging (28.73s)
        --- PASS: TestAccAWSCloudTrail/Trail/includeGlobalServiceEvents (13.68s)
        --- PASS: TestAccAWSCloudTrail/Trail/logValidation (21.63s)
        --- PASS: TestAccAWSCloudTrail/Trail/kmsKey (13.47s)

--- PASS: TestAccAWSCloudTrailServiceAccount_Region (13.90s)
--- PASS: TestAccAWSCloudTrailServiceAccount_basic (13.28s)

--- PASS: TestAccAWSCodeBuildProject_ARMContainer (105.90s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (46.50s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (35.13s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Location (54.85s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Name (112.07s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (106.27s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (47.07s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (34.89s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (49.00s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Type (43.24s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (20.64s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (50.83s)
--- PASS: TestAccAWSCodeBuildProject_Cache (196.62s)
--- PASS: TestAccAWSCodeBuildProject_Description (41.28s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (28.13s)
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (24.95s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (97.49s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (57.69s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value (232.24s)
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (62.55s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (52.39s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (102.76s)
--- PASS: TestAccAWSCodeBuildProject_QueuedTimeout (39.09s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (25.74s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier (64.27s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled (53.38s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Location (64.29s)
--- SKIP: TestAccAWSCodeBuildProject_SecondaryArtifacts_Name (0.00s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType (75.21s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName (43.53s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging (70.98s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Path (65.00s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Type (33.79s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (31.16s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit (137.53s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub (65.41s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise (68.08s)
--- PASS: TestAccAWSCodeBuildProject_SourceVersion (27.48s)
--- FAIL: TestAccAWSCodeBuildProject_Source_Auth (7.70s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (247.28s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit (56.97s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub (178.50s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise (70.03s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (35.01s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (57.03s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (51.30s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (158.00s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (38.96s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (28.67s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (34.12s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (22.11s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (28.28s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (16.20s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (29.61s)
--- PASS: TestAccAWSCodeBuildProject_Tags (58.99s)
--- FAIL: TestAccAWSCodeBuildProject_VpcConfig (338.72s)
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (47.51s)
--- PASS: TestAccAWSCodeBuildProject_basic (29.69s)

--- PASS: TestAccAWSConfigConfigurationAggregator_account (9.29s)
--- SKIP: TestAccAWSConfigConfigurationAggregator_organization (1.09s)
--- SKIP: TestAccAWSConfigConfigurationAggregator_switch (1.07s)
--- PASS: TestAccAWSConfigConfigurationAggregator_tags (21.97s)

--- PASS: TestAccAWSElbServiceAccount_Region (13.76s)
--- PASS: TestAccAWSElbServiceAccount_basic (11.48s)

--- PASS: TestAccAWSProvider_AssumeRole_Empty (12.78s)
--- PASS: TestAccAWSProvider_Endpoints (10.44s)
--- PASS: TestAccAWSProvider_Endpoints_Deprecated (9.07s)
--- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (7.28s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (8.79s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (8.20s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (8.79s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (8.76s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (9.04s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (9.00s)
--- PASS: TestAccAWSProvider_Region_AwsChina (8.70s)
--- PASS: TestAccAWSProvider_Region_AwsCommercial (8.54s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (7.87s)

--- PASS: TestAccAWSRedshiftCluster_basic (359.41s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (724.91s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (2191.54s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (2251.25s)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (704.52s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (973.00s)
--- PASS: TestAccAWSRedshiftCluster_iamRoles (565.01s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (370.08s)
--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (449.98s)
--- FAIL: TestAccAWSRedshiftCluster_publiclyAccessible (447.10s)
--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (449.08s)
--- PASS: TestAccAWSRedshiftCluster_tags (494.93s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeCount (2373.92s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (1981.95s)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (733.64s)

--- PASS: TestAccAWSRedshiftServiceAccount_Region (11.91s)
--- PASS: TestAccAWSRedshiftServiceAccount_basic (12.91s)

--- PASS: TestAccDataSourceAWSS3BucketObject_LeadingSlash (25.48s)
--- PASS: TestAccDataSourceAWSS3BucketObject_MultipleSlashes (21.89s)
--- PASS: TestAccDataSourceAWSS3BucketObject_ObjectLockLegalHoldOff (18.01s)
--- PASS: TestAccDataSourceAWSS3BucketObject_ObjectLockLegalHoldOn (18.76s)
--- PASS: TestAccDataSourceAWSS3BucketObject_allParams (17.99s)
--- PASS: TestAccDataSourceAWSS3BucketObject_basic (17.55s)
--- PASS: TestAccDataSourceAWSS3BucketObject_basicViaAccessPoint (20.63s)
--- PASS: TestAccDataSourceAWSS3BucketObject_kmsEncrypted (18.29s)
--- PASS: TestAccDataSourceAWSS3BucketObject_readableBody (18.45s)

--- PASS: TestAccDataSourceAwsRoute53Zone_id (52.52s)
--- PASS: TestAccDataSourceAwsRoute53Zone_name (52.64s)
--- PASS: TestAccDataSourceAwsRoute53Zone_serviceDiscovery (116.99s)
--- PASS: TestAccDataSourceAwsRoute53Zone_tags (86.41s)
--- PASS: TestAccDataSourceAwsRoute53Zone_vpc (84.80s)

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/codebuild Issues and PRs that pertain to the codebuild service. service/configservice Issues and PRs that pertain to the configservice service. service/elb Issues and PRs that pertain to the elb service. service/redshift Issues and PRs that pertain to the redshift service. service/route53 Issues and PRs that pertain to the route53 service. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 26, 2020
@gdavison gdavison marked this pull request as ready for review May 28, 2020 18:21
@gdavison gdavison requested a review from a team May 28, 2020 18:21
@anGie44 anGie44 self-assigned this May 29, 2020
anGie44
anGie44 approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 just needs a rebase

Output of acceptance tests

--- PASS: TestAccAWSElbServiceAccount_basic (12.28s)
--- PASS: TestAccAWSRedshiftServiceAccount_Region (13.38s)
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (13.19s)
--- PASS: TestProvider_impl (0.04s)
--- PASS: TestProvider (0.29s)
--- PASS: TestAccAWSBillingServiceAccount_basic (13.46s)
--- PASS: TestAccAWSElbServiceAccount_Region (14.05s)
--- PASS: TestAccAWSRedshiftServiceAccount_basic (14.10s)
--- PASS: TestAccAWSCloudTrailServiceAccount_basic (14.28s)
--- PASS: TestAccDataSourceAWSS3BucketObject_basic (15.55s)
--- PASS: TestAccDataSourceAWSS3BucketObject_ObjectLockLegalHoldOn (17.41s)
--- PASS: TestAccDataSourceAWSS3BucketObject_allParams (18.42s)
--- PASS: TestAccDataSourceAWSS3BucketObject_kmsEncrypted (18.74s)
--- PASS: TestAccDataSourceAWSS3BucketObject_basicViaAccessPoint (19.25s)
--- PASS: TestAccDataSourceAWSS3BucketObject_ObjectLockLegalHoldOff (19.28s)
--- PASS: TestAccDataSourceAWSS3BucketObject_readableBody (19.37s)
--- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (9.53s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (8.76s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (8.90s)
--- PASS: TestAccAWSProvider_Endpoints (9.82s)
--- PASS: TestAccAWSProvider_Endpoints_Deprecated (9.89s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (10.04s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (9.61s)
--- PASS: TestAccDataSourceAWSS3BucketObject_LeadingSlash (25.68s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (9.81s)
--- PASS: TestAccAWSProvider_Region_AwsChina (8.88s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (9.55s)
--- PASS: TestAccAWSProvider_Region_AwsCommercial (8.66s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (9.01s)
--- PASS: TestAccAWSProvider_AssumeRole_Empty (13.82s)
--- PASS: TestAccDataSourceAWSS3BucketObject_MultipleSlashes (22.06s)
--- PASS: TestAccDataSourceAwsRoute53Zone_name (51.56s)
--- PASS: TestAccDataSourceAwsRoute53Zone_id (52.46s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_cognito (32.40s)
--- PASS: TestAccAWSCodeBuildProject_basic (30.76s)
--- PASS: TestAccAWSCodeBuildProject_SourceVersion (30.11s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (39.47s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (32.32s)
--- PASS: TestAccAWSCodeBuildProject_QueuedTimeout (40.93s)
--- PASS: TestAccAWSCodeBuildProject_Description (42.65s)
--- PASS: TestAccDataSourceAwsRoute53Zone_vpc (84.29s)
--- PASS: TestAccDataSourceAwsRoute53Zone_tags (85.91s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_authTypeValidation (62.71s)
--- PASS: TestAccAWSCodeBuildProject_Environment_Certificate (33.52s)
--- PASS: TestAccAWSCodeBuildProject_Cache (68.77s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (49.70s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable (53.76s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Value (49.36s)
--- PASS: TestAccDataSourceAwsRoute53Zone_serviceDiscovery (108.27s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (96.34s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_switchAuthType (106.58s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_CodeCommit (67.89s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHub (57.53s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHub (41.88s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_Bitbucket (49.07s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (56.12s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (28.97s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (86.80s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (30.55s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_basic (138.27s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSourceInvalid (11.11s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_GitHubEnterprise (77.79s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_GitSubmodulesConfig_CodeCommit (86.63s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHubEnterprise (93.60s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (41.38s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_switchAuthorizerTTL (163.06s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_NoSource (48.16s)
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (41.07s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (41.42s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus_GitHubEnterprise (99.07s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (43.12s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (102.91s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (65.65s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitSubmodulesConfig_GitHub (128.79s)
--- SKIP: TestAccAWSCodeBuildProject_SecondaryArtifacts_Name (0.00s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_CloudWatchLogs (151.14s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (24.69s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Packaging (48.63s)
--- PASS: TestAccAWSCodeBuildProject_Tags (86.81s)
--- PASS: TestAccAWSCodeBuildProject_LogsConfig_S3Logs (178.93s)
--- PASS: TestAWSCodeBuildProject_nameValidation (0.00s)
--- PASS: TestAccAWSAPIGatewayAuthorizer_disappears (225.10s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_EncryptionDisabled (40.63s)
--- SKIP: TestAccAWSConfigConfigurationAggregator_organization (1.12s)
--- SKIP: TestAccAWSConfigConfigurationAggregator_switch (1.06s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_NamespaceType (74.73s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_OverrideArtifactName (75.82s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_OverrideArtifactName (53.47s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_ArtifactIdentifier (54.54s)
--- PASS: TestAccAWSConfigConfigurationAggregator_account (9.64s)
--- PASS: TestAccAWSCloudTrail (239.60s)
    --- PASS: TestAccAWSCloudTrail/Trail (239.60s)
        --- PASS: TestAccAWSCloudTrail/Trail/includeGlobalServiceEvents (14.24s)
        --- PASS: TestAccAWSCloudTrail/Trail/kmsKey (12.75s)
        --- PASS: TestAccAWSCloudTrail/Trail/eventSelector (43.56s)
        --- PASS: TestAccAWSCloudTrail/Trail/basic (18.82s)
        --- PASS: TestAccAWSCloudTrail/Trail/enableLogging (24.51s)
        --- PASS: TestAccAWSCloudTrail/Trail/isMultiRegion (25.82s)
        --- SKIP: TestAccAWSCloudTrail/Trail/isOrganization (1.05s)
        --- PASS: TestAccAWSCloudTrail/Trail/logValidation (28.83s)
        --- PASS: TestAccAWSCloudTrail/Trail/tags (25.40s)
        --- PASS: TestAccAWSCloudTrail/Trail/cloudwatch (44.63s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (26.46s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Type (35.80s)
--- PASS: TestAccAWSConfigConfigurationAggregator_tags (22.25s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Type (80.89s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_NamespaceType (68.55s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Packaging (67.53s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Location (73.15s)
--- PASS: TestAccAWSCodeBuildProject_Environment_RegistryCredential (41.02s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Path (95.39s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts_Path (69.12s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Name (138.65s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_Location (144.92s)
--- PASS: TestAccAWSCodeBuildProject_ARMContainer (178.02s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (372.89s)
--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (373.26s)
--- PASS: TestAccAWSRedshiftCluster_basic (427.40s)
--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (416.77s)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (723.28s)
--- PASS: TestAccAWSRedshiftCluster_tags (899.70s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (1218.02s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (1260.01s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (2428.27s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (3131.78s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (3445.18s)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (555.29s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeCount (3575.22s)

Usual suspects:

--- FAIL: TestAccAWSCodeBuildProject_Source_Auth (20.78s)
--- FAIL: TestAccAWSCodeBuildProject_VpcConfig (338.68s)

--- FAIL: TestAccAWSRedshiftCluster_iamRoles (396.85s)
--- FAIL: TestAccAWSRedshiftCluster_publiclyAccessible (531.91s)

aws/resource_aws_cloudtrail_test.go Outdated Show resolved Hide resolved
@gdavison
Removes custom ARN check for CloudTrail
f3ff49b
@gdavison
Uses ARN testing check function for Redshift cluster
5abfbf6
@gdavison
Uses ARN testing check function for billing service account
7acf8fa
@gdavison
Uses Account ID check function for AWS Config aggregator
1d1080d
@gdavison
Uses ARN testing check functions for AWS Config recorder
72d2c41
@gdavison
Uses ARN testing check functions for Cloudtrail service account data …
848c596 
…source
@gdavison
Uses ARN testing check functions for ELB service account data source
bc3ecc7
@gdavison
Uses ARN testing check functions for Redshift service account data so…
f2f48db 
…urce
@gdavison
Uses Pair check function for Route 53 service discovery
2e49ca8
@gdavison
Uses resource.TestCheckResourceAttrPair for most attributes in S3 B…
253cd03 
…ucket Object data source acceptance tests. Simplifies most multi-stage tests
@gdavison
Removes ARN checks and replaces them with AttrPair checks. Removes un…
79617df 
…needed custom checks and other cleanups.
@gdavison
Removes explicit ARN checks. Other cleanups.
a3adbcf
@gdavison
Removes unused function
6840bad
@gdavison
Removes stray comment
fcc7273
@gdavison gdavison force-pushed the t-clean-up-stealth-arn-tests branch from b8a862d to fcc7273 Compare June 1, 2020 20:16
@gdavison gdavison merged commit cd37340 into master Jun 1, 2020
@gdavison gdavison deleted the t-clean-up-stealth-arn-tests branch June 1, 2020 21:25
@gdavison gdavison added this to the v2.65.0 milestone Jun 1, 2020
@ghost
Copy link

ghost commented Jun 5, 2020

This has been released in version 2.65.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
service/apigateway Issues and PRs that pertain to the apigateway service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/codebuild Issues and PRs that pertain to the codebuild service. service/configservice Issues and PRs that pertain to the configservice service. service/elb Issues and PRs that pertain to the elb service. service/redshift Issues and PRs that pertain to the redshift service. service/route53 Issues and PRs that pertain to the route53 service. service/s3 Issues and PRs that pertain to the s3 service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.65.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @anGie44