Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds available_ip_address_count to data_source_aws_subnet. #13554

Conversation

wuxort
Copy link

@wuxort wuxort commented May 29, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Adds available_ip_address_count to data_source_aws_subnet.

Output from acceptance testing:

ok  	github.com/terraform-providers/terraform-provider-aws/aws	19.767s

Local tests passed, but I would like to request a proper acceptance test on AWS.

@wuxort wuxort requested a review from a team May 29, 2020 16:54
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 29, 2020
@nirmalparekh1984
Copy link

Which version is this feature going to be available?

Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@jaekunchoi
Copy link

I also need this. Is this going to be merged soon?

@connor-tyndall
Copy link
Contributor

Yes, I am in need of this as well!

@YakDriver YakDriver self-assigned this Feb 18, 2021
@YakDriver YakDriver force-pushed the f-data_source_aws_subnet-add-available_ip_address_count branch from 90544a9 to e7fa342 Compare February 18, 2021 21:24
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Feb 18, 2021
@YakDriver YakDriver force-pushed the f-data_source_aws_subnet-add-available_ip_address_count branch from 8395fbe to d20246e Compare February 18, 2021 21:37
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Feb 18, 2021
@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Feb 18, 2021
@YakDriver YakDriver added this to the v3.29.0 milestone Feb 18, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Acceptance tests on GovCloud:

--- PASS: TestAccDataSourceAwsSubnet_basic (27.88s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock (49.43s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter (49.94s)

us-west-2:

--- PASS: TestAccDataSourceAwsSubnet_basic (24.24s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock (43.54s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter (44.32s)

@YakDriver YakDriver merged commit 9bde60a into hashicorp:main Feb 18, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants