Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_batch_job_definition: Prevent diffs when no command specified in container properties #13634

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13629.

Release note for CHANGELOG:

resource/aws_batch_job_definition: Prevent diffs when no `command` is specified in `container_properties`

Output from acceptance testing:

$ go test ./aws/internal/service/batch/equivalency
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/batch/equivalency	0.005s

Related:

@ewbankkit ewbankkit requested a review from a team June 5, 2020 15:10
@ghost ghost added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 5, 2020
@bflad bflad added the service/batch Issues and PRs that pertain to the batch service. label Jun 5, 2020
@bflad bflad self-assigned this Jun 5, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccAWSBatchJobDefinition_basic (8.72s)
--- PASS: TestAccAWSBatchJobDefinition_ContainerProperties_Advanced (8.76s)
--- PASS: TestAccAWSBatchJobDefinition_updateForcesNewResource (13.62s)

@bflad bflad added the bug Addresses a defect in current functionality. label Jun 5, 2020
@bflad bflad added this to the v2.66.0 milestone Jun 5, 2020
@bflad bflad merged commit 1424691 into hashicorp:master Jun 5, 2020
bflad added a commit that referenced this pull request Jun 5, 2020
@ewbankkit ewbankkit deleted the b-aws_batch_job_definition-container-properties-empty-commands branch June 5, 2020 17:27
@ghost
Copy link

ghost commented Jun 12, 2020

This has been released in version 2.66.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/batch Issues and PRs that pertain to the batch service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_batch_job_definition resource always shows destroy/create without any changes
2 participants