Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/keyvaluetags: Support servicediscovery and worklink #13732

Merged
merged 1 commit into from
Jun 12, 2020
Merged

internal/keyvaluetags: Support servicediscovery and worklink #13732

merged 1 commit into from
Jun 12, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 12, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #13459
Reference: #13696

Release note for CHANGELOG:

NONE

Supports them in the generated code for easier implementation of the functionality later.

Output from acceptance testing: N/A (covered via unit testing)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/worklink Issues and PRs that pertain to the worklink service. labels Jun 12, 2020
@bflad bflad requested a review from a team June 12, 2020 15:21
@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jun 12, 2020
@bflad bflad mentioned this pull request Jun 12, 2020
Closed
@bflad bflad added this to the v2.67.0 milestone Jun 12, 2020
@bflad bflad merged commit 71a2a91 into master Jun 12, 2020
@bflad bflad deleted the f-keyvaluetags-sd-and-worklink branch June 12, 2020 18:45
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/worklink Issues and PRs that pertain to the worklink service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.67.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @ewbankkit