Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource aws_vpc_endpoint_security_group_association #13737

Merged
merged 11 commits into from
Mar 15, 2022
Merged

New resource aws_vpc_endpoint_security_group_association #13737

merged 11 commits into from
Mar 15, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 12, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10429.
Relates #12599.
Relates #15105.

Adds a new resource, aws_vpc_endpoint_security_group_association, similar to aws_vpc_endpoint_route_table_association and aws_vpc_endpoint_subnet_association, which allows security groups to be associated with a VPC endpoint.
The wrinkle here is that there must always be at least one security group associated with a VPC endpoint, unlike for route tables or subnets. When a VPC endpoint is created with no security groups specified the VPC's default security group is associated with the VPC endpoint. Prior to this PR we always required at least one security group to be specified for a VPC endpoint, so associating the default security group with the VPC endpoint required explicit configuration. Now associating the default security group with the VPC endpoint is implicit if no security groups are specified.
In order for this default association to be removed, one aws_vpc_endpoint_security_group_association for the VPC endpoint can be configured with replace_default_association = true which means that the resource will remove the default association once the specified security group is associated with the VPC endpoint and conversely, when the resource is deleted the default association is reinstated.

There are the usual caveats around not attempting to manage associations through both the aws_vpc_endpoint resource's security_group_ids attribute and individual aws_vpc_endpoint_security_group_association resources.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_\|TestAccAWSVpcEndpoint_\|TestAccAWSVpcEndpointSubnetAssociation_\|TestAccAWSVpcEndpointRouteTableAssociation_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_\|TestAccAWSVpcEndpoint_\|TestAccAWSVpcEndpointSubnetAssociation_\|TestAccAWSVpcEndpointRouteTableAssociation_ -timeout 180m
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_basic
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_basic
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_basic
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_multiple
=== RUN   TestAccAWSVpcEndpoint_gatewayBasic
=== PAUSE TestAccAWSVpcEndpoint_gatewayBasic
=== RUN   TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccAWSVpcEndpoint_gatewayPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayPolicy
=== RUN   TestAccAWSVpcEndpoint_interfaceBasic
=== PAUSE TestAccAWSVpcEndpoint_interfaceBasic
=== RUN   TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccAWSVpcEndpoint_disappears
=== PAUSE TestAccAWSVpcEndpoint_disappears
=== RUN   TestAccAWSVpcEndpoint_tags
=== PAUSE TestAccAWSVpcEndpoint_tags
=== RUN   TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== PAUSE TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_basic
=== CONT  TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (37.47s)
=== CONT  TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (69.89s)
=== CONT  TestAccAWSVpcEndpoint_tags
--- PASS: TestAccAWSVpcEndpoint_tags (85.48s)
=== CONT  TestAccAWSVpcEndpoint_disappears
--- PASS: TestAccAWSVpcEndpoint_disappears (30.97s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer (396.86s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (281.49s)
=== CONT  TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (316.66s)
=== CONT  TestAccAWSVpcEndpoint_interfaceBasic
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (87.63s)
=== CONT  TestAccAWSVpcEndpoint_gatewayPolicy
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (375.61s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (58.57s)
=== CONT  TestAccAWSVpcEndpoint_gatewayBasic
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (34.93s)
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_multiple
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation (132.97s)
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_disappears
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_disappears (265.54s)
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_basic
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_basic (245.34s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_multiple (623.90s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_disappears (107.47s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_basic
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_multiple (105.00s)
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_disappears
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_basic (92.71s)
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_disappears (34.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1695.257s

@ewbankkit ewbankkit requested a review from a team June 12, 2020 19:47
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 12, 2020
@ewbankkit ewbankkit force-pushed the f-add-aws_vpc_endpoint_security_group_association-resource branch from 430d10e to 2bace82 Compare June 12, 2020 20:10
@Lightning0
Copy link

This is a welcome addition to TF!

Will replace some custom code I needed to write to set up an AWS Transfer Server of type VPC which doesn't expose the VPC Endpoint and needs to use AWS Security Groups to whitelist Vendor CIDR's.

@ewbankkit
Copy link
Contributor Author

@Lightning0 Yes, #12599 was the catalyst for this new resource.

@ewbankkit ewbankkit force-pushed the f-add-aws_vpc_endpoint_security_group_association-resource branch from 2bace82 to c3806b2 Compare July 19, 2020 22:36
@ewbankkit
Copy link
Contributor Author

Rebased to remove merge conflicts.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_ -timeout 120m
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_basic (120.46s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation (122.91s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_disappears (105.48s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_multiple (114.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	234.769s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpoint_ -timeout 120m
=== RUN   TestAccAWSVpcEndpoint_gatewayBasic
=== PAUSE TestAccAWSVpcEndpoint_gatewayBasic
=== RUN   TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccAWSVpcEndpoint_gatewayPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayPolicy
=== RUN   TestAccAWSVpcEndpoint_interfaceBasic
=== PAUSE TestAccAWSVpcEndpoint_interfaceBasic
=== RUN   TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccAWSVpcEndpoint_disappears
=== PAUSE TestAccAWSVpcEndpoint_disappears
=== RUN   TestAccAWSVpcEndpoint_tags
=== PAUSE TestAccAWSVpcEndpoint_tags
=== CONT  TestAccAWSVpcEndpoint_gatewayBasic
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (35.90s)
=== CONT  TestAccAWSVpcEndpoint_tags
--- PASS: TestAccAWSVpcEndpoint_tags (65.25s)
=== CONT  TestAccAWSVpcEndpoint_disappears
--- PASS: TestAccAWSVpcEndpoint_disappears (32.93s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (351.56s)
=== CONT  TestAccAWSVpcEndpoint_interfaceBasic
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (316.21s)
=== CONT  TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (108.80s)
=== CONT  TestAccAWSVpcEndpoint_gatewayPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (56.91s)
=== CONT  TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (66.21s)
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (372.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	822.654s

@ewbankkit ewbankkit force-pushed the f-add-aws_vpc_endpoint_security_group_association-resource branch from c3806b2 to bc42da0 Compare August 16, 2020 22:11
@ewbankkit
Copy link
Contributor Author

Rebased and upgraded new code to Plugin SDK v2.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_ -timeout 120m
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
    resource_aws_vpc_endpoint_security_group_association_test.go:41: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation (105.14s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_basic (107.23s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_multiple (109.48s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_disappears (111.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	111.146s

@ewbankkit ewbankkit force-pushed the f-add-aws_vpc_endpoint_security_group_association-resource branch from bc42da0 to 24c7e5e Compare August 21, 2020 19:01
@ewbankkit ewbankkit force-pushed the f-add-aws_vpc_endpoint_security_group_association-resource branch from 24c7e5e to b0a5e84 Compare September 22, 2020 19:30
@ewbankkit
Copy link
Contributor Author

Rebased and fixed merge conflict.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_ -timeout 120m
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation (104.16s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_basic (111.52s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
    resource_aws_vpc_endpoint_security_group_association_test.go:41: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_multiple (61.28s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_disappears (63.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	175.194s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpoint_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpoint_ -timeout 120m
=== RUN   TestAccAWSVpcEndpoint_gatewayBasic
=== PAUSE TestAccAWSVpcEndpoint_gatewayBasic
=== RUN   TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccAWSVpcEndpoint_gatewayPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayPolicy
=== RUN   TestAccAWSVpcEndpoint_interfaceBasic
=== PAUSE TestAccAWSVpcEndpoint_interfaceBasic
=== RUN   TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccAWSVpcEndpoint_disappears
=== PAUSE TestAccAWSVpcEndpoint_disappears
=== RUN   TestAccAWSVpcEndpoint_tags
=== PAUSE TestAccAWSVpcEndpoint_tags
=== CONT  TestAccAWSVpcEndpoint_gatewayBasic
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (39.27s)
=== CONT  TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (272.03s)
=== CONT  TestAccAWSVpcEndpoint_tags
--- PASS: TestAccAWSVpcEndpoint_tags (94.20s)
=== CONT  TestAccAWSVpcEndpoint_disappears
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (344.51s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== CONT  TestAccAWSVpcEndpoint_disappears
    resource_aws_vpc_endpoint_test.go:445: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSVpcEndpoint_disappears (35.43s)
=== CONT  TestAccAWSVpcEndpoint_gatewayPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (64.31s)
=== CONT  TestAccAWSVpcEndpoint_interfaceBasic
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (79.91s)
=== CONT  TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (73.57s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (326.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	710.605s

@sshearn sshearn mentioned this pull request Sep 23, 2020
Merged
@bflad bflad added new-resource Introduces a new resource. proposal Proposes new design or functionality. labels Sep 24, 2020
@andwoods
Copy link

andwoods commented Oct 7, 2020

Thanks for the work on this feature! Has there been any updates or estimated time of releasing? My team could use this functionality.

@kramarenko104
Copy link

Thanks for the work on this feature! Has there been any updates or estimated time of releasing? My team could use this functionality.

Our team is really looking forward to the release of this feature. We would be glad to know the possible release time.

@ewbankkit ewbankkit mentioned this pull request Oct 22, 2020
Closed
@ewbankkit
Copy link
Contributor Author

@kramarenko104 Is it attachment of security groups to an AWS Transfer Server that you require this resource for? If so, AWS recently added this functionality to the Transfer API.
I opened #15788 for this.

@kramarenko104
Copy link

kramarenko104 commented Oct 22, 2020 •
edited
Loading

@kramarenko104 Is it attachment of security groups to an AWS Transfer Server that you require this resource for? If so, AWS recently added this functionality to the Transfer API.
I opened #15788 for this.

Yes, we need it for SFTP server. Thanks, we will vote for this PR, too.
@ewbankkit, is it difficult to say when one of these PRs can be taken into release? I'm stuck with lack of this functionality and trying now to do workaround but it looks like hard for now. So, I hope to see one of these PRs released ASAP.

@pstrav
Copy link

pstrav commented Nov 16, 2020

Hey team, do we have any updates on this?

@ewbankkit ewbankkit force-pushed the f-add-aws_vpc_endpoint_security_group_association-resource branch from b0a5e84 to d6a3b16 Compare November 16, 2020 13:40
@ewbankkit ewbankkit requested a review from a team as a code owner November 16, 2020 13:40
@ewbankkit
Copy link
Contributor Author

ewbankkit commented Nov 16, 2020 •
edited
Loading

Sometimes the gateway load balancer test fails with the same error as here.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_\|TestAccAWSVpcEndpoint_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_\|TestAccAWSVpcEndpoint_ -timeout 120m
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== RUN   TestAccAWSVpcEndpoint_gatewayBasic
=== PAUSE TestAccAWSVpcEndpoint_gatewayBasic
=== RUN   TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccAWSVpcEndpoint_gatewayPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayPolicy
=== RUN   TestAccAWSVpcEndpoint_interfaceBasic
=== PAUSE TestAccAWSVpcEndpoint_interfaceBasic
=== RUN   TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccAWSVpcEndpoint_disappears
=== PAUSE TestAccAWSVpcEndpoint_disappears
=== RUN   TestAccAWSVpcEndpoint_tags
=== PAUSE TestAccAWSVpcEndpoint_tags
=== RUN   TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== PAUSE TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== CONT  TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
    resource_aws_vpc_endpoint_test.go:513: Step 1/2 error: Error running apply: 2020/11/16 08:41:22 [DEBUG] Using modified User-Agent: Terraform/0.12.26 HashiCorp-terraform-exec/0.10.0
        
        Error: error waiting for VPC Endpoint (vpce-003d272b3ec2f66e7) to become available: VPC endpoint (vpce-003d272b3ec2f66e7) is in a failed state
        
        
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_basic (98.27s)
=== CONT  TestAccAWSVpcEndpoint_tags
--- FAIL: TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer (121.50s)
=== CONT  TestAccAWSVpcEndpoint_disappears
--- PASS: TestAccAWSVpcEndpoint_disappears (31.86s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccAWSVpcEndpoint_tags (86.99s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (251.34s)
=== CONT  TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (284.20s)
=== CONT  TestAccAWSVpcEndpoint_interfaceBasic
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (106.77s)
=== CONT  TestAccAWSVpcEndpoint_gatewayPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (59.44s)
=== CONT  TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (69.62s)
=== CONT  TestAccAWSVpcEndpoint_gatewayBasic
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (34.98s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation (90.86s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (362.98s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_multiple (136.15s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_disappears (139.51s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	939.138s
FAIL
GNUmakefile:27: recipe for target 'testacc' failed
make: *** [testacc] Error 1

@ewbankkit
Copy link
Contributor Author

Rebased and resolved merge conflicts.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_\|TestAccAWSVpcEndpoint_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_\|TestAccAWSVpcEndpoint_ -timeout 120m
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== RUN   TestAccAWSVpcEndpoint_gatewayBasic
=== PAUSE TestAccAWSVpcEndpoint_gatewayBasic
=== RUN   TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccAWSVpcEndpoint_gatewayPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayPolicy
=== RUN   TestAccAWSVpcEndpoint_interfaceBasic
=== PAUSE TestAccAWSVpcEndpoint_interfaceBasic
=== RUN   TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccAWSVpcEndpoint_disappears
=== PAUSE TestAccAWSVpcEndpoint_disappears
=== RUN   TestAccAWSVpcEndpoint_tags
=== PAUSE TestAccAWSVpcEndpoint_tags
=== RUN   TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== PAUSE TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== CONT  TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_basic (117.84s)
=== CONT  TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (384.50s)
=== CONT  TestAccAWSVpcEndpoint_tags
=== CONT  TestAccAWSVpcEndpoint_disappears
--- PASS: TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer (335.03s)
--- PASS: TestAccAWSVpcEndpoint_tags (83.42s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccAWSVpcEndpoint_disappears (30.92s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (240.93s)
=== CONT  TestAccAWSVpcEndpoint_gatewayBasic
=== CONT  TestAccAWSVpcEndpoint_interfaceBasic
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (34.22s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (293.72s)
=== CONT  TestAccAWSVpcEndpoint_gatewayPolicy
=== CONT  TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (61.78s)
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (60.07s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_multiple (59.76s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (66.55s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation (52.65s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_disappears (48.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	936.201s

ewbankkit added a commit that referenced this pull request Jun 15, 2021
@ewbankkit
VPC Endpoint changes from #13737.
3a96fb1
@ewbankkit ewbankkit force-pushed the f-add-aws_vpc_endpoint_security_group_association-resource branch 2 times, most recently from eb60cf1 to 10991e1 Compare June 18, 2021 19:09
@ewbankkit
Add new resource 'aws_vpc_endpoint_security_group_association'.
a23cd5a 
Test no security groups specified for Interface VPC endpoint.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpoint_ -timeout 120m
=== RUN   TestAccAWSVpcEndpoint_gatewayBasic
=== PAUSE TestAccAWSVpcEndpoint_gatewayBasic
=== RUN   TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicyAndTags
=== PAUSE TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicyAndTags
=== RUN   TestAccAWSVpcEndpoint_gatewayPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayPolicy
=== RUN   TestAccAWSVpcEndpoint_interfaceBasic
=== PAUSE TestAccAWSVpcEndpoint_interfaceBasic
=== RUN   TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSService
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSService
=== RUN   TestAccAWSVpcEndpoint_disappears
=== PAUSE TestAccAWSVpcEndpoint_disappears
=== CONT  TestAccAWSVpcEndpoint_gatewayBasic
=== CONT  TestAccAWSVpcEndpoint_disappears
--- PASS: TestAccAWSVpcEndpoint_disappears (48.99s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSService
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (51.48s)
=== CONT  TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSService (330.97s)
=== CONT  TestAccAWSVpcEndpoint_interfaceBasic
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (112.93s)
=== CONT  TestAccAWSVpcEndpoint_gatewayPolicy
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (451.61s)
=== CONT  TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicyAndTags
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (84.62s)
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicyAndTags (93.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	596.473s

First acceptance test.

Output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_basic -timeout 120m
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_basic
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_basic (136.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	136.460s

Add 'TestAccAWSVpcEndpointSecurityGroupAssociation_disappears'.

Output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_disappears -timeout 120m
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_disappears (189.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	189.437s

Remove resource importer.

r/aws_vpc_endpoint_security_group_association: Add 'replace_default_association' attribute.

Fix acceptance tests after rebase.

Upgrade to Plugin SDK v2 and use Terraform 0.12 syntax in documentation.

r/aws_vpc_endpoint: Add 'finder.VpcEndpointByID'.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpoint_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpoint_ -timeout 120m
=== RUN   TestAccAWSVpcEndpoint_gatewayBasic
=== PAUSE TestAccAWSVpcEndpoint_gatewayBasic
=== RUN   TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccAWSVpcEndpoint_gatewayPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayPolicy
=== RUN   TestAccAWSVpcEndpoint_interfaceBasic
=== PAUSE TestAccAWSVpcEndpoint_interfaceBasic
=== RUN   TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccAWSVpcEndpoint_disappears
=== PAUSE TestAccAWSVpcEndpoint_disappears
=== RUN   TestAccAWSVpcEndpoint_tags
=== PAUSE TestAccAWSVpcEndpoint_tags
=== CONT  TestAccAWSVpcEndpoint_gatewayBasic
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (39.27s)
=== CONT  TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (272.03s)
=== CONT  TestAccAWSVpcEndpoint_tags
--- PASS: TestAccAWSVpcEndpoint_tags (94.20s)
=== CONT  TestAccAWSVpcEndpoint_disappears
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (344.51s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== CONT  TestAccAWSVpcEndpoint_disappears
    resource_aws_vpc_endpoint_test.go:445: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSVpcEndpoint_disappears (35.43s)
=== CONT  TestAccAWSVpcEndpoint_gatewayPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (64.31s)
=== CONT  TestAccAWSVpcEndpoint_interfaceBasic
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (79.91s)
=== CONT  TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (73.57s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (326.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	710.605s

r/aws_vpc_endpoint_security_group_association: Use internal 'finder' package.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_ -timeout 120m
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation (104.16s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_basic (111.52s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
    resource_aws_vpc_endpoint_security_group_association_test.go:41: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_multiple (61.28s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_disappears (63.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	175.194s

Fix linting issues.

'hcl' -> 'terraform' in documentation.

r/aws_vpc_endpoint_*: Use internal finder and waiter packages.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_\|TestAccAWSVpcEndpoint_\|TestAccAWSVpcEndpointSubnetAssociation_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_\|TestAccAWSVpcEndpoint_\|TestAccAWSVpcEndpointSubnetAssociation_ -timeout 180m
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_basic
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_multiple
=== RUN   TestAccAWSVpcEndpoint_gatewayBasic
=== PAUSE TestAccAWSVpcEndpoint_gatewayBasic
=== RUN   TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccAWSVpcEndpoint_gatewayPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayPolicy
=== RUN   TestAccAWSVpcEndpoint_interfaceBasic
=== PAUSE TestAccAWSVpcEndpoint_interfaceBasic
=== RUN   TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccAWSVpcEndpoint_disappears
=== PAUSE TestAccAWSVpcEndpoint_disappears
=== RUN   TestAccAWSVpcEndpoint_tags
=== PAUSE TestAccAWSVpcEndpoint_tags
=== RUN   TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== PAUSE TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== CONT  TestAccAWSVpcEndpoint_gatewayPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (59.54s)
=== CONT  TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_basic (66.30s)
=== CONT  TestAccAWSVpcEndpoint_tags
--- PASS: TestAccAWSVpcEndpoint_tags (83.44s)
=== CONT  TestAccAWSVpcEndpoint_disappears
--- PASS: TestAccAWSVpcEndpoint_disappears (31.54s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer (324.96s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (277.00s)
=== CONT  TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (271.89s)
=== CONT  TestAccAWSVpcEndpoint_interfaceBasic
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (76.82s)
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_disappears
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (323.02s)
=== CONT  TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== CONT  TestAccAWSVpcEndpoint_gatewayBasic
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (67.98s)
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (34.33s)
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_multiple
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_disappears (300.21s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation (67.70s)
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_basic
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_basic (247.76s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_multiple
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_multiple (107.91s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_multiple (585.07s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_disappears (76.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1533.242s

Add 'ErrorCheck' for new acceptance tests.

Fix golangci-lint error:

aws/resource_aws_vpc_endpoint_subnet_association_test.go:111:63: `testAccCheckVpcEndpointSubnetAssociationExists` - `vpce` is unused (unparam)
func testAccCheckVpcEndpointSubnetAssociationExists(n string, vpce *ec2.VpcEndpoint) resource.TestCheckFunc {
                                                              ^

Fix golangci-lint error:

S1039: unnecessary use of fmt.Sprintf (gosimple)
		fmt.Sprintf(`
		^

r/aws_route_table_association: Tidy up after rebase including hashicorp#18465.

r/aws_vpc_endpoint_route_table_association: Use internal finder package.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointRouteTableAssociation_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointRouteTableAssociation_ -timeout 180m
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_basic
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_basic
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_disappears
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_basic
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_disappears
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_disappears (36.58s)
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (39.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.161s

r/aws_vpc_endpoint_security_group_association: 'VpcEndpointSecurityGroupAssociation' -> 'VpcEndpointSecurityGroupAssociationExists'.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_ -timeout 180m
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation (65.31s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_basic (67.35s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_disappears (65.30s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_multiple (81.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	147.314s

r/aws_vpc_endpoint_subnet_association: Use internal finder package.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointSubnetAssociation_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointSubnetAssociation_ -timeout 180m
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_basic
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_multiple
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_basic
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_multiple
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_basic (244.58s)
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_disappears
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_disappears (301.32s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_multiple (592.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	592.827s

Set Name tag in acceptance tests where possible.

Add CHANGELOG entry.

'ExistsPropagation' -> 'ExistancePropagation'.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_basic\|TestAccAWSVpcEndpointSubnetAssociation_basic\|TestAccAWSVpcEndpointRouteTableAssociation_basic' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_basic\|TestAccAWSVpcEndpointSubnetAssociation_basic\|TestAccAWSVpcEndpointRouteTableAssociation_basic -timeout 180m
=== RUN   TestAccAWSVpcEndpointRouteTableAssociation_basic
=== PAUSE TestAccAWSVpcEndpointRouteTableAssociation_basic
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_basic
=== CONT  TestAccAWSVpcEndpointRouteTableAssociation_basic
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_basic
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (38.09s)
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_basic
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_basic (82.50s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_basic (255.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	255.882s

Fix golangci-lint error:

S1021: should merge variable declaration with assignment on next line (gosimple)
		var err error
		^

Add 'tfresource.RetryUntilFound'.

Exclude 'aws/internal/tfresource/retry.go' from helper-schema-resource-Retry-without-TimeoutError-check.

r/aws_vpc_endpoint_security_group_association: Don't retry on read.

Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_ -timeout 180m
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation (104.66s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_basic (108.84s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_multiple (111.20s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_disappears (124.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	127.135s

r/aws_vpc_endpoint_subnet_association: Don't retry on read.

Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointSubnetAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointSubnetAssociation_ -timeout 180m
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_basic
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSubnetAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSubnetAssociation_multiple
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_basic
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_multiple
=== CONT  TestAccAWSVpcEndpointSubnetAssociation_disappears
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_disappears (258.95s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_basic (259.71s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_multiple (545.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	548.634s
@ewbankkit ewbankkit force-pushed the f-add-aws_vpc_endpoint_security_group_association-resource branch from 10991e1 to a23cd5a Compare June 18, 2021 20:57
@ewbankkit
Copy link
Contributor Author 

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpcEndpointSecurityGroupAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpointSecurityGroupAssociation_ -timeout 180m
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== PAUSE TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_basic
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_multiple
=== CONT  TestAccAWSVpcEndpointSecurityGroupAssociation_disappears
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_ReplaceDefaultAssociation (86.03s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_basic (90.93s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_disappears (93.30s)
--- PASS: TestAccAWSVpcEndpointSecurityGroupAssociation_multiple (94.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	98.082s

@ewbankkit ewbankkit removed the size/XXL Managed by automation to categorize the size of a PR. label Jun 18, 2021
@Ninir
Copy link
Contributor

Ninir commented Jul 9, 2021

@DrFaust92 Would it be possible to get this one reviewed 🙏 It's about to cross the finish line. Thanks!

@Shocktrooper
Copy link

Wee just learned that our organization prevents us from doing the workaround of directly attaching security groups to Network Interfaces so an actual attachment the right way with a terraform resource would go a long way to solve our issues

@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@ewbankkit
Copy link
Contributor Author

Commercial

% make testacc TESTARGS='-run=TestAccEC2VPCEndpointSecurityGroupAssociation_\|TestAccEC2VPCEndpoint_interfaceBasic' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2VPCEndpointSecurityGroupAssociation_\|TestAccEC2VPCEndpoint_interfaceBasic -timeout 180m
=== RUN   TestAccEC2VPCEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccEC2VPCEndpointSecurityGroupAssociation_basic
=== RUN   TestAccEC2VPCEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccEC2VPCEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccEC2VPCEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccEC2VPCEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccEC2VPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== PAUSE TestAccEC2VPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== RUN   TestAccEC2VPCEndpoint_interfaceBasic
=== PAUSE TestAccEC2VPCEndpoint_interfaceBasic
=== CONT  TestAccEC2VPCEndpointSecurityGroupAssociation_basic
=== CONT  TestAccEC2VPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== CONT  TestAccEC2VPCEndpointSecurityGroupAssociation_multiple
--- PASS: TestAccEC2VPCEndpointSecurityGroupAssociation_basic (107.05s)
=== CONT  TestAccEC2VPCEndpointSecurityGroupAssociation_disappears
--- PASS: TestAccEC2VPCEndpointSecurityGroupAssociation_replaceDefaultAssociation (112.27s)
=== CONT  TestAccEC2VPCEndpoint_interfaceBasic
--- PASS: TestAccEC2VPCEndpointSecurityGroupAssociation_multiple (117.03s)
--- PASS: TestAccEC2VPCEndpoint_interfaceBasic (76.91s)
--- PASS: TestAccEC2VPCEndpointSecurityGroupAssociation_disappears (83.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	193.958s

GovCloud

% make testacc TESTARGS='-run=TestAccEC2VPCEndpointSecurityGroupAssociation_\|TestAccEC2VPCEndpoint_interfaceBasic' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2VPCEndpointSecurityGroupAssociation_\|TestAccEC2VPCEndpoint_interfaceBasic -timeout 180m
=== RUN   TestAccEC2VPCEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccEC2VPCEndpointSecurityGroupAssociation_basic
=== RUN   TestAccEC2VPCEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccEC2VPCEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccEC2VPCEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccEC2VPCEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccEC2VPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== PAUSE TestAccEC2VPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== RUN   TestAccEC2VPCEndpoint_interfaceBasic
=== PAUSE TestAccEC2VPCEndpoint_interfaceBasic
=== CONT  TestAccEC2VPCEndpointSecurityGroupAssociation_basic
=== CONT  TestAccEC2VPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== CONT  TestAccEC2VPCEndpoint_interfaceBasic
--- PASS: TestAccEC2VPCEndpointSecurityGroupAssociation_replaceDefaultAssociation (99.86s)
=== CONT  TestAccEC2VPCEndpointSecurityGroupAssociation_multiple
--- PASS: TestAccEC2VPCEndpointSecurityGroupAssociation_basic (105.70s)
=== CONT  TestAccEC2VPCEndpointSecurityGroupAssociation_disappears
--- PASS: TestAccEC2VPCEndpoint_interfaceBasic (105.92s)
--- PASS: TestAccEC2VPCEndpointSecurityGroupAssociation_multiple (90.74s)
--- PASS: TestAccEC2VPCEndpointSecurityGroupAssociation_disappears (92.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	201.647s

@ewbankkit ewbankkit changed the title New resource 'aws_vpc_endpoint_security_group_association' New resource aws_vpc_endpoint_security_group_association Mar 12, 2022
@YakDriver YakDriver self-assigned this Mar 15, 2022
YakDriver
YakDriver approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Виглядає мені добре!

Output from acceptance tests:

% make testacc TESTARGS='-run=TestAccEC2VPCEndpointSecurityGroupAssociation_\|TestAccEC2VPCEndpoint_interfaceBasic' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2VPCEndpointSecurityGroupAssociation_\|TestAccEC2VPCEndpoint_interfaceBasic -timeout 180m
--- PASS: TestAccEC2VPCEndpointSecurityGroupAssociation_basic (45.48s)
--- PASS: TestAccEC2VPCEndpointSecurityGroupAssociation_replaceDefaultAssociation (53.02s)
--- PASS: TestAccEC2VPCEndpointSecurityGroupAssociation_multiple (71.73s)
--- PASS: TestAccEC2VPCEndpointSecurityGroupAssociation_disappears (140.02s)
--- PASS: TestAccEC2VPCEndpoint_interfaceBasic (149.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	197.138s

website/docs/r/vpc_endpoint_security_group_association.html.markdown Outdated Show resolved Hide resolved
@ewbankkit @YakDriver
Update website/docs/r/vpc_endpoint_security_group_association.html.ma…
8bf44a8 
…rkdown

Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>
@ewbankkit ewbankkit merged commit 242b03b into hashicorp:main Mar 15, 2022
@ewbankkit ewbankkit deleted the f-add-aws_vpc_endpoint_security_group_association-resource branch March 15, 2022 17:04
@github-actions github-actions bot added this to the v4.6.0 milestone Mar 15, 2022
@github-actions
Copy link

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrFaust92 DrFaust92 DrFaust92 left review comments

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. proposal Proposes new design or functionality. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.6.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Dynamic Security Group Association for VPC Endpoint Interface