Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 13952 #13965
Issue 13952 #13965
Changes from 19 commits
4e81983
7a68637
8228594
de89fec
bf826cb
44437b6
64bc218
08fcfdb
e34b0c7
1e5af99
dde888e
636221a
bbf8578
c8b5209
cdd8e49
dc0eaee
de02135
1d8017c
7ae8a6d
44340eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly does not need to be for this pull request, but since this API uses a PUT-type call, it should allow the resource to support an Update function (essentially similar to this Create function, except no d.SetId(), then removing all
ForceNew
from thecompute_limits
attributes). May be worth creating a followup GitHub issue if it is not implemented since the forced recreation may be a little confusing for operators.