-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/elastic_transcoder_pipeline - add validations #13973
r/elastic_transcoder_pipeline - add validations #13973
Conversation
d41838b
to
182bee2
Compare
182bee2
to
e2b3260
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple nitpicks here and comment re: the "grantee" validation. i'm not sure if we can readily validate all the possibilities, but we should definitely document them if not already done so 👍
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
…ust92/terraform-provider-aws into r/elastictrascoder_refactor
Added docs and addressed comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM 👍 thanks @DrFaust92
Output of acceptance tests (commercial):
--- PASS: TestAccAWSElasticTranscoderPipeline_disappears (19.42s)
--- PASS: TestAccAWSElasticTranscoderPipeline_kmsKey (21.90s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withPermissions (23.32s)
--- PASS: TestAccAWSElasticTranscoderPipeline_notifications (35.24s)
--- PASS: TestAccAWSElasticTranscoderPipeline_withContentConfig (35.26s)
--- PASS: TestAccAWSElasticTranscoderPipeline_basic (39.11s)
This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #11872, #13820
Release note for CHANGELOG:
Output from acceptance testing: