Add support for tags on Directory Service #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
added
the
enhancement
pablo-ruth
changed the title
radeksimko
approved these changes
Aug 21, 2017
There was a problem hiding this comment.
Hi @pablo-ruth
this is looking very good. All DS acceptance tests (including your new one) are passing and the code is aok.
Just one request - would you mind adding tests for the diff function? See what we have for similar function in R53: https://github.com/terraform-providers/terraform-provider-aws/blob/master/aws/tags_route53_test.go
radeksimko
added
the
waiting-response
radeksimko
removed
the
waiting-response
|
Hi @radeksimko, thanks for your feedback. I just added a test to diff function. |
radeksimko
approved these changes
Aug 23, 2017
nbaztec
pushed a commit
to nbaztec/terraform-provider-aws
that referenced
this pull request
Sep 26, 2017
* add support for tags on Directory Service * update doc for directory service tags argument * add acceptance test for tags on directory service * Add tests for the diff function
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for cost allocation tags on Directory Service to resolve #350.