Apply tags to Elastic Search domain resources after creation.

[charles-at-geospock]

The Elastic Search Domain resource takes about 10 minutes to create.
During this time, many things may go wrong to break the behaviour of
the Terraform system - network drops, token expiry, system crashes,
accidentally closing the wrong terminal, etc... In such cases, the
resource will have been created but not be tagged. So, as well as
Terraform losing track of it, the tracking tags would not give an
indication of why it existed in the first place.

The current code creates the domain and then waits until it has
completed construction before setting the tags. It also seems to
use the partial completion interface, which seems redundant as
it immediately completes the operation.

In any case, moving the tag setting operations before the wait
means that the tags are present as early as possible, allowing
the resource to be identified. And that tiny amount of time is
absorbed into the long domain creation, making things marginally
faster.

[radeksimko]

LGTM. Thanks.

Related acceptance tests are passing and I don't think there's any way we can test the particular code change, so 🚢 ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!