Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_route: Refactor acceptance tests in preparation for future fixes/enhancements #14014

Merged
merged 2 commits into from
Mar 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions aws/data_source_aws_route_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ func TestAccAWSRouteDataSource_basic(t *testing.T) {
}

func TestAccAWSRouteDataSource_TransitGatewayID(t *testing.T) {
var route ec2.Route
dataSourceName := "data.aws_route.test"
resourceName := "aws_route.test"
rName := acctest.RandomWithPrefix("tf-acc-test")
Expand All @@ -62,7 +61,6 @@ func TestAccAWSRouteDataSource_TransitGatewayID(t *testing.T) {
{
Config: testAccAWSRouteDataSourceConfigIpv4TransitGateway(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckAWSRouteExists(resourceName, &route),
resource.TestCheckResourceAttrPair(resourceName, "destination_cidr_block", dataSourceName, "destination_cidr_block"),
resource.TestCheckResourceAttrPair(resourceName, "route_table_id", dataSourceName, "route_table_id"),
resource.TestCheckResourceAttrPair(resourceName, "transit_gateway_id", dataSourceName, "transit_gateway_id"),
Expand Down Expand Up @@ -95,7 +93,6 @@ func TestAccAWSRouteDataSource_IPv6DestinationCidr(t *testing.T) {
}

func TestAccAWSRouteDataSource_LocalGatewayID(t *testing.T) {
var route ec2.Route
dataSourceName := "data.aws_route.by_local_gateway_id"
resourceName := "aws_route.test"
rName := acctest.RandomWithPrefix("tf-acc-test")
Expand All @@ -109,7 +106,6 @@ func TestAccAWSRouteDataSource_LocalGatewayID(t *testing.T) {
{
Config: testAccAWSRouteDataSourceConfigIpv4LocalGateway(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckAWSRouteExists(resourceName, &route),
resource.TestCheckResourceAttrPair(resourceName, "destination_cidr_block", dataSourceName, "destination_cidr_block"),
resource.TestCheckResourceAttrPair(resourceName, "route_table_id", dataSourceName, "route_table_id"),
resource.TestCheckResourceAttrPair(resourceName, "local_gateway_id", dataSourceName, "local_gateway_id"),
Expand Down
Loading