Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_lambda_invocation: Remove result_map attribute #14125

Merged
merged 1 commit into from
Jul 14, 2020
Merged

data-source/aws_lambda_invocation: Remove result_map attribute #14125

merged 1 commit into from
Jul 14, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 9, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9189

Release note for CHANGELOG:

* data-source/aws_lambda_invocation: Remove `result_map` attribute

Already documented in the version 3 upgrade guide.

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsLambdaInvocation_basic (37.41s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_complex (43.39s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_qualifier (52.03s)

@bflad
data-source/aws_lambda_invocation: Remove result_map attribute
57216ec 
Reference: #9189

Already documented in the version 3 upgrade guide.

Output from acceptance testing:

```
--- PASS: TestAccDataSourceAwsLambdaInvocation_basic (37.41s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_complex (43.39s)
--- PASS: TestAccDataSourceAwsLambdaInvocation_qualifier (52.03s)
```
@bflad bflad added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Jul 9, 2020
@bflad bflad added this to the v3.0.0 milestone Jul 9, 2020
@bflad bflad requested a review from a team July 9, 2020 21:19
@bflad bflad mentioned this pull request Jul 14, 2020
Merged
@bflad bflad merged commit fadad72 into master Jul 14, 2020
@bflad bflad deleted the td-aws_lambda_invocation-remove-result_map branch July 14, 2020 14:21
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appilon appilon appilon approved these changes

Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Deprecate aws_lambda_invocation data source result_map attribute
2 participants
@bflad @appilon