Remove hardcoded AMI IDs from data_source_aws_instance_test #14145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/M
This was referenced Jul 10, 2020
17 tasks
bflad
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
Otherwise, looks good. 🚀
Output from acceptance testing in AWS Commercial:
--- FAIL: TestAccAWSInstanceDataSource_secondaryPrivateIPs (17.16s)
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (76.83s)
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (101.23s)
--- PASS: TestAccAWSInstanceDataSource_privateIP (103.59s)
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (105.78s)
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (113.60s)
--- PASS: TestAccAWSInstanceDataSource_VPC (118.67s)
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (122.56s)
--- PASS: TestAccAWSInstanceDataSource_blockDevices (122.68s)
--- PASS: TestAccAWSInstanceDataSource_AzUserData (122.91s)
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (123.34s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (125.23s)
--- PASS: TestAccAWSInstanceDataSource_SecurityGroups (125.66s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (130.14s)
--- PASS: TestAccAWSInstanceDataSource_tags (134.25s)
--- PASS: TestAccAWSInstanceDataSource_metadataOptions (125.22s)
--- PASS: TestAccAWSInstanceDataSource_basic (143.17s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (143.38s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (156.18s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (163.11s)
--- PASS: TestAccAWSInstanceDataSource_keyPair (182.89s)
Output from acceptance testing in AWS GovCloud (US) (other test failures related to other tech debt like hardcoded AZs):
--- FAIL: TestAccAWSInstanceDataSource_AzUserData (9.15s)
--- FAIL: TestAccAWSInstanceDataSource_VPC (10.06s)
--- FAIL: TestAccAWSInstanceDataSource_secondaryPrivateIPs (15.15s)
--- FAIL: TestAccAWSInstanceDataSource_VPCSecurityGroups (26.15s)
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (62.73s)
--- PASS: TestAccAWSInstanceDataSource_keyPair (67.84s)
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (75.32s)
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (76.20s)
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (78.40s)
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (87.29s)
--- PASS: TestAccAWSInstanceDataSource_privateIP (88.67s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (83.50s)
--- PASS: TestAccAWSInstanceDataSource_SecurityGroups (101.95s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (77.26s)
--- PASS: TestAccAWSInstanceDataSource_blockDevices (104.03s)
--- PASS: TestAccAWSInstanceDataSource_tags (107.74s)
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (60.68s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (123.34s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (125.66s)
--- PASS: TestAccAWSInstanceDataSource_basic (199.59s)
--- PASS: TestAccAWSInstanceDataSource_metadataOptions (301.61s)
aws/data_source_aws_instance_test.go
Outdated
| @@ -687,7 +680,7 @@ data "aws_instance" "test" { | |||
| } | |||
|
|
|||
| func testAccInstanceDataSourceConfig_secondaryPrivateIPs(rName string) string { | |||
| return testAccLatestAmazonLinuxHvmEbsAmiConfig() + testAccAwsInstanceVpcConfig(rName, false) + ` | |||
| return testAccLatestAmazonLinuxHvmEbsAmiConfig() + testAccAwsInstanceVpcConfigBasic(rName) + ` | |||
There was a problem hiding this comment.
Ah sorry in trying to fix the merge conflicts, I switched this over to the new function and the hardcoded IP a few lines down needs the same treatment as the one a few lines up.
TestAccAWSInstanceDataSource_secondaryPrivateIPs: testing.go:684: Step 0 error: errors during apply:
Error: Error launching source instance: InvalidParameterValue: Address 10.1.1.42 does not fall within the subnet's address range
YakDriver
force-pushed
the
harddatainstance
branch
2 times, most recently
from
9e908d2 to
d5b707e
Compare
YakDriver
force-pushed
the
harddatainstance
branch
from
d5b707e to
ebace76
Compare
ghost
added
size/L
|
Latest: On commercial partition: On GovCloud: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #11126
Central management issue: #12994
Release note for CHANGELOG:
See AWSAT002
Current stats of acceptance tests for this PR: