Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add underscore to acceptance test names #14227

Merged
merged 1 commit into from
Jul 18, 2020
Merged

Add underscore to acceptance test names #14227

merged 1 commit into from
Jul 18, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jul 17, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9950

Release note for CHANGELOG:

NONE

Output from acceptance testing:

Hit some flakey errors, You have imported the maximum number of 8000 certificates in the last year.

--- PASS: TestAccAWSAccessAnalyzer_serial (43.73s)
--- PASS: TestAccAwsAcmpcaCertificateAuthority_basic (16.67s)
--- PASS: TestAccAWSAMILaunchPermission_basic (334.20s)
--- PASS: TestAccAWSAppmesh_serial (634.72s)
--- PASS: TestAccAWSCloudTrail_serial (725.83s)
--- PASS: TestAccAWSCloudWatchEventPermission_basic (23.08s)
--- PASS: TestAccAWSCodeBuildSourceCredential_basic (23.08s)
--- PASS: TestAccAWSCodeStarNotificationsNotificationRule_basic (16.37s)
--- PASS: TestAccAWSDlmLifecyclePolicy_basic (18.43s)
--- PASS: TestAccAWSDmsCertificate_basic (9.84s)
--- PASS: TestAccAwsDmsEndpoint_basic (20.54s)
--- PASS: TestAccAWSDmsReplicationInstance_basic (294.96s)
--- PASS: TestAccAWSDmsReplicationSubnetGroup_basic (50.75s)
--- PASS: TestAccAWSEcrDataSource_nonExistent (2.25s)
--- PASS: TestAccAWSElasticBeanstalkSolutionStackDataSource_basic (10.02s)
--- PASS: TestAccAWSKinesisStreamDataSource_basic (165.92s)
--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (2.10s)
--- PASS: TestAccAWSStepFunctionsActivityDataSource_basic (21.30s)
--- PASS: TestAccDataSourceAwsAcmpcaCertificateAuthority_basic (22.72s)
--- PASS: TestAccDataSourceAwsApiGatewayApiKey_basic (11.09s)
--- PASS: TestAccDataSourceAwsApiGatewayResource_basic (17.07s)
--- PASS: TestAccDataSourceAwsApiGatewayVpcLink_basic (688.65s)
--- PASS: TestAccDataSourceAwsBatchComputeEnvironment_basic (59.67s)
--- PASS: TestAccDataSourceAwsBatchJobQueue_basic (92.09s)
--- PASS: TestAccDataSourceAwsDxGateway_basic (34.22s)
--- PASS: TestAccDataSourceAwsEbsVolumes_basic (37.86s)
--- PASS: TestAccDataSourceAwsEfsMountTargetByMountTargetId_basic (144.42s)
--- PASS: TestAccDataSourceAWSLB_BackwardsCompatibility (194.88s)
--- PASS: TestAccDataSourceAWSLBTargetGroup_BackwardsCompatibility (186.24s)
--- PASS: TestAccDataSourceAwsNatGateway_basic (235.62s)
--- PASS: TestAccDataSourceAwsQLDBLedger_basic (48.20s)
--- PASS: TestAccDataSourceAwsRamResourceShare_basic (15.21s)
--- PASS: TestAccDataSourceAwsRegions_basic (9.66s)
--- PASS: TestAccDataSourceAwsRouteTables_basic (46.12s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_basic (4.29s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecretRotation_basic (48.54s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_basic (15.98s)
--- PASS: TestAccDataSourceAwsSfnStateMachine_basic (30.52s)
--- PASS: TestAccDataSourceAwsSnsTopic_basic (12.49s)
--- PASS: TestAccDataSourceAwsSubnetIDs_basic (39.91s)
--- PASS: TestAccDataSourceAwsWafIPSet_basic (11.26s)
--- PASS: TestAccDataSourceAwsWafRateBasedRule_basic (12.50s)
--- PASS: TestAccDataSourceAwsWafRegionalIPSet_basic (15.33s)
--- PASS: TestAccDataSourceAwsWafRegionalRateBasedRule_basic (17.84s)
--- PASS: TestAccDataSourceAwsWafRegionalRule_basic (16.55s)
--- PASS: TestAccDataSourceAwsWafRegionalWebAcl_basic (19.36s)
--- PASS: TestAccDataSourceAwsWafRule_basic (11.35s)
--- PASS: TestAccDataSourceAwsWafv2IPSet_basic (16.24s)
--- PASS: TestAccDataSourceAwsWafv2RegexPatternSet_basic (16.71s)
--- PASS: TestAccDataSourceAwsWafv2RuleGroup_basic (25.10s)
--- PASS: TestAccDataSourceAwsWafv2WebACL_basic (229.72s)
--- PASS: TestAccDataSourceAwsWafWebAcl_basic (11.69s)
--- SKIP: TestAccAWSCodePipeline_WithNamespace (0.00s)



TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsAcmpcaCertificateAuthority_basic -timeout 120m
=== RUN   TestAccDataSourceAwsAcmpcaCertificateAuthority_basic
=== PAUSE TestAccDataSourceAwsAcmpcaCertificateAuthority_basic
=== CONT  TestAccDataSourceAwsAcmpcaCertificateAuthority_basic
--- PASS: TestAccDataSourceAwsAcmpcaCertificateAuthority_basic (22.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	22.764s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsApiGatewayApiKey_basic -timeout 120m
=== RUN   TestAccDataSourceAwsApiGatewayApiKey_basic
=== PAUSE TestAccDataSourceAwsApiGatewayApiKey_basic
=== CONT  TestAccDataSourceAwsApiGatewayApiKey_basic
--- PASS: TestAccDataSourceAwsApiGatewayApiKey_basic (11.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	11.135s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsApiGatewayResource_basic -timeout 120m
=== RUN   TestAccDataSourceAwsApiGatewayResource_basic
=== PAUSE TestAccDataSourceAwsApiGatewayResource_basic
=== CONT  TestAccDataSourceAwsApiGatewayResource_basic
--- PASS: TestAccDataSourceAwsApiGatewayResource_basic (17.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	17.127s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsApiGatewayVpcLink_basic -timeout 120m
=== RUN   TestAccDataSourceAwsApiGatewayVpcLink_basic
=== PAUSE TestAccDataSourceAwsApiGatewayVpcLink_basic
=== CONT  TestAccDataSourceAwsApiGatewayVpcLink_basic
--- PASS: TestAccDataSourceAwsApiGatewayVpcLink_basic (688.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	688.704s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsBatchComputeEnvironment_basic -timeout 120m
=== RUN   TestAccDataSourceAwsBatchComputeEnvironment_basic
=== PAUSE TestAccDataSourceAwsBatchComputeEnvironment_basic
=== CONT  TestAccDataSourceAwsBatchComputeEnvironment_basic
--- PASS: TestAccDataSourceAwsBatchComputeEnvironment_basic (59.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.719s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsBatchJobQueue_basic -timeout 120m
=== RUN   TestAccDataSourceAwsBatchJobQueue_basic
=== PAUSE TestAccDataSourceAwsBatchJobQueue_basic
=== CONT  TestAccDataSourceAwsBatchJobQueue_basic
--- PASS: TestAccDataSourceAwsBatchJobQueue_basic (92.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	92.141s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsDxGateway_basic -timeout 120m
=== RUN   TestAccDataSourceAwsDxGateway_basic
=== PAUSE TestAccDataSourceAwsDxGateway_basic
=== CONT  TestAccDataSourceAwsDxGateway_basic
--- PASS: TestAccDataSourceAwsDxGateway_basic (34.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	34.270s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEbsVolumes_basic -timeout 120m
=== RUN   TestAccDataSourceAwsEbsVolumes_basic
=== PAUSE TestAccDataSourceAwsEbsVolumes_basic
=== CONT  TestAccDataSourceAwsEbsVolumes_basic
--- PASS: TestAccDataSourceAwsEbsVolumes_basic (37.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.914s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcrDataSource_nonExistent -timeout 120m
=== RUN   TestAccAWSEcrDataSource_nonExistent
=== PAUSE TestAccAWSEcrDataSource_nonExistent
=== CONT  TestAccAWSEcrDataSource_nonExistent
--- PASS: TestAccAWSEcrDataSource_nonExistent (2.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.290s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEfsMountTargetByMountTargetId_basic -timeout 120m
=== RUN   TestAccDataSourceAwsEfsMountTargetByMountTargetId_basic
=== PAUSE TestAccDataSourceAwsEfsMountTargetByMountTargetId_basic
=== CONT  TestAccDataSourceAwsEfsMountTargetByMountTargetId_basic
--- PASS: TestAccDataSourceAwsEfsMountTargetByMountTargetId_basic (144.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	144.471s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticBeanstalkSolutionStackDataSource_basic -timeout 120m
=== RUN   TestAccAWSElasticBeanstalkSolutionStackDataSource_basic
=== PAUSE TestAccAWSElasticBeanstalkSolutionStackDataSource_basic
=== CONT  TestAccAWSElasticBeanstalkSolutionStackDataSource_basic
--- PASS: TestAccAWSElasticBeanstalkSolutionStackDataSource_basic (10.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	10.076s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKinesisStreamDataSource_basic -timeout 120m
=== RUN   TestAccAWSKinesisStreamDataSource_basic
=== PAUSE TestAccAWSKinesisStreamDataSource_basic
=== CONT  TestAccAWSKinesisStreamDataSource_basic
--- PASS: TestAccAWSKinesisStreamDataSource_basic (165.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	165.966s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplateDataSource_NonExistent -timeout 120m
=== RUN   TestAccAWSLaunchTemplateDataSource_NonExistent
=== PAUSE TestAccAWSLaunchTemplateDataSource_NonExistent
=== CONT  TestAccAWSLaunchTemplateDataSource_NonExistent
--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (2.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.146s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSLBTargetGroup_BackwardsCompatibility -timeout 120m
=== RUN   TestAccDataSourceAWSLBTargetGroup_BackwardsCompatibility
=== PAUSE TestAccDataSourceAWSLBTargetGroup_BackwardsCompatibility
=== CONT  TestAccDataSourceAWSLBTargetGroup_BackwardsCompatibility
--- PASS: TestAccDataSourceAWSLBTargetGroup_BackwardsCompatibility (186.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	186.285s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSLB_BackwardsCompatibility -timeout 120m
=== RUN   TestAccDataSourceAWSLB_BackwardsCompatibility
=== PAUSE TestAccDataSourceAWSLB_BackwardsCompatibility
=== CONT  TestAccDataSourceAWSLB_BackwardsCompatibility
--- PASS: TestAccDataSourceAWSLB_BackwardsCompatibility (194.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	194.935s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsNatGateway_basic -timeout 120m
=== RUN   TestAccDataSourceAwsNatGateway_basic
=== PAUSE TestAccDataSourceAwsNatGateway_basic
=== CONT  TestAccDataSourceAwsNatGateway_basic
--- PASS: TestAccDataSourceAwsNatGateway_basic (235.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	235.667s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsQLDBLedger_basic -timeout 120m
=== RUN   TestAccDataSourceAwsQLDBLedger_basic
=== PAUSE TestAccDataSourceAwsQLDBLedger_basic
=== CONT  TestAccDataSourceAwsQLDBLedger_basic
--- PASS: TestAccDataSourceAwsQLDBLedger_basic (48.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	48.258s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsRamResourceShare_basic -timeout 120m
=== RUN   TestAccDataSourceAwsRamResourceShare_basic
=== PAUSE TestAccDataSourceAwsRamResourceShare_basic
=== CONT  TestAccDataSourceAwsRamResourceShare_basic
--- PASS: TestAccDataSourceAwsRamResourceShare_basic (15.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.256s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsRegions_basic -timeout 120m
=== RUN   TestAccDataSourceAwsRegions_basic
=== PAUSE TestAccDataSourceAwsRegions_basic
=== CONT  TestAccDataSourceAwsRegions_basic
--- PASS: TestAccDataSourceAwsRegions_basic (9.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	9.712s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsRouteTables_basic -timeout 120m
=== RUN   TestAccDataSourceAwsRouteTables_basic
=== PAUSE TestAccDataSourceAwsRouteTables_basic
=== CONT  TestAccDataSourceAwsRouteTables_basic
--- PASS: TestAccDataSourceAwsRouteTables_basic (46.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	46.168s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsSecretsManagerSecretRotation_basic -timeout 120m
=== RUN   TestAccDataSourceAwsSecretsManagerSecretRotation_basic
=== PAUSE TestAccDataSourceAwsSecretsManagerSecretRotation_basic
=== CONT  TestAccDataSourceAwsSecretsManagerSecretRotation_basic
--- PASS: TestAccDataSourceAwsSecretsManagerSecretRotation_basic (48.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	48.591s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsSecretsManagerSecret_basic -timeout 120m
=== RUN   TestAccDataSourceAwsSecretsManagerSecret_basic
=== PAUSE TestAccDataSourceAwsSecretsManagerSecret_basic
=== CONT  TestAccDataSourceAwsSecretsManagerSecret_basic
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_basic (4.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.348s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsSecretsManagerSecretVersion_basic -timeout 120m
=== RUN   TestAccDataSourceAwsSecretsManagerSecretVersion_basic
=== PAUSE TestAccDataSourceAwsSecretsManagerSecretVersion_basic
=== CONT  TestAccDataSourceAwsSecretsManagerSecretVersion_basic
--- PASS: TestAccDataSourceAwsSecretsManagerSecretVersion_basic (15.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.027s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStepFunctionsActivityDataSource_basic -timeout 120m
=== RUN   TestAccAWSStepFunctionsActivityDataSource_basic
=== PAUSE TestAccAWSStepFunctionsActivityDataSource_basic
=== CONT  TestAccAWSStepFunctionsActivityDataSource_basic
--- PASS: TestAccAWSStepFunctionsActivityDataSource_basic (21.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.349s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsSfnStateMachine_basic -timeout 120m
=== RUN   TestAccDataSourceAwsSfnStateMachine_basic
=== PAUSE TestAccDataSourceAwsSfnStateMachine_basic
=== CONT  TestAccDataSourceAwsSfnStateMachine_basic
--- PASS: TestAccDataSourceAwsSfnStateMachine_basic (30.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	30.564s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsSnsTopic_basic -timeout 120m
=== RUN   TestAccDataSourceAwsSnsTopic_basic
=== PAUSE TestAccDataSourceAwsSnsTopic_basic
=== CONT  TestAccDataSourceAwsSnsTopic_basic
--- PASS: TestAccDataSourceAwsSnsTopic_basic (12.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	12.538s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsSubnetIDs_basic -timeout 120m
=== RUN   TestAccDataSourceAwsSubnetIDs_basic
=== PAUSE TestAccDataSourceAwsSubnetIDs_basic
=== CONT  TestAccDataSourceAwsSubnetIDs_basic
--- PASS: TestAccDataSourceAwsSubnetIDs_basic (39.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.957s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafIPSet_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWafIPSet_basic
=== PAUSE TestAccDataSourceAwsWafIPSet_basic
=== CONT  TestAccDataSourceAwsWafIPSet_basic
--- PASS: TestAccDataSourceAwsWafIPSet_basic (11.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	11.303s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafRateBasedRule_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWafRateBasedRule_basic
=== PAUSE TestAccDataSourceAwsWafRateBasedRule_basic
=== CONT  TestAccDataSourceAwsWafRateBasedRule_basic
--- PASS: TestAccDataSourceAwsWafRateBasedRule_basic (12.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	12.548s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafRule_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWafRule_basic
=== PAUSE TestAccDataSourceAwsWafRule_basic
=== CONT  TestAccDataSourceAwsWafRule_basic
--- PASS: TestAccDataSourceAwsWafRule_basic (11.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	11.398s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafWebAcl_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWafWebAcl_basic
=== PAUSE TestAccDataSourceAwsWafWebAcl_basic
=== CONT  TestAccDataSourceAwsWafWebAcl_basic
--- PASS: TestAccDataSourceAwsWafWebAcl_basic (11.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	11.746s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafRegionalIPSet_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWafRegionalIPSet_basic
=== PAUSE TestAccDataSourceAwsWafRegionalIPSet_basic
=== CONT  TestAccDataSourceAwsWafRegionalIPSet_basic
--- PASS: TestAccDataSourceAwsWafRegionalIPSet_basic (15.33s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.374s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafRegionalRateBasedRule_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWafRegionalRateBasedRule_basic
=== PAUSE TestAccDataSourceAwsWafRegionalRateBasedRule_basic
=== CONT  TestAccDataSourceAwsWafRegionalRateBasedRule_basic
--- PASS: TestAccDataSourceAwsWafRegionalRateBasedRule_basic (17.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	17.883s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafRegionalRule_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWafRegionalRule_basic
=== PAUSE TestAccDataSourceAwsWafRegionalRule_basic
=== CONT  TestAccDataSourceAwsWafRegionalRule_basic
--- PASS: TestAccDataSourceAwsWafRegionalRule_basic (16.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.595s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafRegionalWebAcl_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWafRegionalWebAcl_basic
=== PAUSE TestAccDataSourceAwsWafRegionalWebAcl_basic
=== CONT  TestAccDataSourceAwsWafRegionalWebAcl_basic
--- PASS: TestAccDataSourceAwsWafRegionalWebAcl_basic (19.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	19.409s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafv2IPSet_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWafv2IPSet_basic
=== PAUSE TestAccDataSourceAwsWafv2IPSet_basic
=== CONT  TestAccDataSourceAwsWafv2IPSet_basic
--- PASS: TestAccDataSourceAwsWafv2IPSet_basic (16.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.289s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafv2RegexPatternSet_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWafv2RegexPatternSet_basic
=== PAUSE TestAccDataSourceAwsWafv2RegexPatternSet_basic
=== CONT  TestAccDataSourceAwsWafv2RegexPatternSet_basic
--- PASS: TestAccDataSourceAwsWafv2RegexPatternSet_basic (16.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.751s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafv2RuleGroup_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWafv2RuleGroup_basic
=== PAUSE TestAccDataSourceAwsWafv2RuleGroup_basic
=== CONT  TestAccDataSourceAwsWafv2RuleGroup_basic
--- PASS: TestAccDataSourceAwsWafv2RuleGroup_basic (25.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.147s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWafv2WebACL_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWafv2WebACL_basic
=== PAUSE TestAccDataSourceAwsWafv2WebACL_basic
=== CONT  TestAccDataSourceAwsWafv2WebACL_basic
--- PASS: TestAccDataSourceAwsWafv2WebACL_basic (229.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	229.777s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAccessAnalyzer_serial -timeout 120m
=== RUN   TestAccAWSAccessAnalyzer_serial
=== RUN   TestAccAWSAccessAnalyzer_serial/Analyzer
=== RUN   TestAccAWSAccessAnalyzer_serial/Analyzer/basic
=== RUN   TestAccAWSAccessAnalyzer_serial/Analyzer/disappears
=== RUN   TestAccAWSAccessAnalyzer_serial/Analyzer/Tags
--- PASS: TestAccAWSAccessAnalyzer_serial (43.73s)
    --- PASS: TestAccAWSAccessAnalyzer_serial/Analyzer (43.73s)
        --- PASS: TestAccAWSAccessAnalyzer_serial/Analyzer/basic (11.61s)
        --- PASS: TestAccAWSAccessAnalyzer_serial/Analyzer/disappears (7.88s)
        --- PASS: TestAccAWSAccessAnalyzer_serial/Analyzer/Tags (24.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	43.784s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAcmpcaCertificateAuthority_basic -timeout 120m
=== RUN   TestAccAwsAcmpcaCertificateAuthority_basic
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_basic
=== CONT  TestAccAwsAcmpcaCertificateAuthority_basic
--- PASS: TestAccAwsAcmpcaCertificateAuthority_basic (16.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.720s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAMILaunchPermission_basic -timeout 120m
=== RUN   TestAccAWSAMILaunchPermission_basic
=== PAUSE TestAccAWSAMILaunchPermission_basic
=== CONT  TestAccAWSAMILaunchPermission_basic
--- PASS: TestAccAWSAMILaunchPermission_basic (334.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	334.247s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh_serial -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Mesh
=== RUN   TestAccAWSAppmesh_serial/Mesh/basic
=== RUN   TestAccAWSAppmesh_serial/Mesh/egressFilter
=== RUN   TestAccAWSAppmesh_serial/Mesh/tags
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/routePriority
=== RUN   TestAccAWSAppmesh_serial/Route/tags
=== RUN   TestAccAWSAppmesh_serial/Route/httpHeader
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualService
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualService/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualNode
--- PASS: TestAccAWSAppmesh_serial (634.72s)
    --- PASS: TestAccAWSAppmesh_serial/Mesh (68.39s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/basic (12.67s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/egressFilter (26.10s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/tags (29.62s)
    --- PASS: TestAccAWSAppmesh_serial/Route (199.55s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (45.87s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (42.92s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (32.51s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (47.56s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (30.70s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (203.68s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (25.54s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (25.26s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (37.57s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (16.77s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (98.54s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (61.20s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (36.36s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (24.84s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualService (101.89s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (29.57s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/tags (42.67s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualNode (29.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	634.776s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudTrail_serial -timeout 120m
=== RUN   TestAccAWSCloudTrail_serial
=== RUN   TestAccAWSCloudTrail_serial/Trail
=== RUN   TestAccAWSCloudTrail_serial/Trail/basic
=== RUN   TestAccAWSCloudTrail_serial/Trail/isOrganization
    TestAccAWSCloudTrail_serial/Trail/isOrganization: provider_test.go:532: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAWSCloudTrail_serial/Trail/logValidation
=== RUN   TestAccAWSCloudTrail_serial/Trail/kmsKey
=== RUN   TestAccAWSCloudTrail_serial/Trail/eventSelector
=== RUN   TestAccAWSCloudTrail_serial/Trail/cloudwatch
=== RUN   TestAccAWSCloudTrail_serial/Trail/enableLogging
=== RUN   TestAccAWSCloudTrail_serial/Trail/includeGlobalServiceEvents
=== RUN   TestAccAWSCloudTrail_serial/Trail/isMultiRegion
=== RUN   TestAccAWSCloudTrail_serial/Trail/tags
--- PASS: TestAccAWSCloudTrail_serial (725.83s)
    --- PASS: TestAccAWSCloudTrail_serial/Trail (725.83s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/basic (65.97s)
        --- SKIP: TestAccAWSCloudTrail_serial/Trail/isOrganization (1.82s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/logValidation (67.50s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/kmsKey (42.18s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/eventSelector (141.62s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/cloudwatch (80.59s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/enableLogging (92.46s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/includeGlobalServiceEvents (42.74s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/isMultiRegion (93.81s)
        --- PASS: TestAccAWSCloudTrail_serial/Trail/tags (97.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	725.881s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchEventPermission_basic -timeout 120m
=== RUN   TestAccAWSCloudWatchEventPermission_basic
=== PAUSE TestAccAWSCloudWatchEventPermission_basic
=== CONT  TestAccAWSCloudWatchEventPermission_basic
--- PASS: TestAccAWSCloudWatchEventPermission_basic (23.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	23.132s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildSourceCredential_basic -timeout 120m
=== RUN   TestAccAWSCodeBuildSourceCredential_basic
=== PAUSE TestAccAWSCodeBuildSourceCredential_basic
=== CONT  TestAccAWSCodeBuildSourceCredential_basic
--- PASS: TestAccAWSCodeBuildSourceCredential_basic (23.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	23.129s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodePipeline_WithNamespace -timeout 120m
=== RUN   TestAccAWSCodePipeline_WithNamespace
    TestAccAWSCodePipeline_WithNamespace: resource_aws_codepipeline_test.go:392: Environment variable GITHUB_TOKEN is not set
--- SKIP: TestAccAWSCodePipeline_WithNamespace (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.049s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeStarNotificationsNotificationRule_basic -timeout 120m
=== RUN   TestAccAWSCodeStarNotificationsNotificationRule_basic
=== PAUSE TestAccAWSCodeStarNotificationsNotificationRule_basic
=== CONT  TestAccAWSCodeStarNotificationsNotificationRule_basic
--- PASS: TestAccAWSCodeStarNotificationsNotificationRule_basic (16.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.426s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDlmLifecyclePolicy_basic -timeout 120m
=== RUN   TestAccAWSDlmLifecyclePolicy_basic
=== PAUSE TestAccAWSDlmLifecyclePolicy_basic
=== CONT  TestAccAWSDlmLifecyclePolicy_basic
--- PASS: TestAccAWSDlmLifecyclePolicy_basic (18.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.488s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDmsCertificate_basic -timeout 120m
=== RUN   TestAccAWSDmsCertificate_basic
=== PAUSE TestAccAWSDmsCertificate_basic
=== CONT  TestAccAWSDmsCertificate_basic
--- PASS: TestAccAWSDmsCertificate_basic (9.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	9.887s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsDmsEndpoint_basic -timeout 120m
=== RUN   TestAccAwsDmsEndpoint_basic
=== PAUSE TestAccAwsDmsEndpoint_basic
=== CONT  TestAccAwsDmsEndpoint_basic
--- PASS: TestAccAwsDmsEndpoint_basic (20.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	20.588s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDmsReplicationInstance_basic -timeout 120m
=== RUN   TestAccAWSDmsReplicationInstance_basic
=== PAUSE TestAccAWSDmsReplicationInstance_basic
=== CONT  TestAccAWSDmsReplicationInstance_basic
--- PASS: TestAccAWSDmsReplicationInstance_basic (294.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	295.016s

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDmsReplicationSubnetGroup_basic -timeout 120m
=== RUN   TestAccAWSDmsReplicationSubnetGroup_basic
=== PAUSE TestAccAWSDmsReplicationSubnetGroup_basic
=== CONT  TestAccAWSDmsReplicationSubnetGroup_basic
--- PASS: TestAccAWSDmsReplicationSubnetGroup_basic (50.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	50.806s

@YakDriver YakDriver requested a review from a team July 17, 2020 16:03
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appmesh Issues and PRs that pertain to the appmesh service. service/batch Issues and PRs that pertain to the batch service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/configservice Issues and PRs that pertain to the configservice service. service/databasemigrationservice service/directconnect Issues and PRs that pertain to the directconnect service. service/ec2 Issues and PRs that pertain to the ec2 service. service/efs Issues and PRs that pertain to the efs service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/kinesis Issues and PRs that pertain to the kinesis service. service/qldb Issues and PRs that pertain to the qldb service. service/sfn Issues and PRs that pertain to the sfn service. service/sns Issues and PRs that pertain to the sns service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 17, 2020
@ghost ghost added provider Pertains to the provider itself, rather than any interaction with AWS. service/acmpca Issues and PRs that pertain to the acmpca service. service/ram Issues and PRs that pertain to the ram service. size/L Managed by automation to categorize the size of a PR. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/waf Issues and PRs that pertain to the waf service. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 17, 2020
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jul 17, 2020
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 17, 2020
bflad
bflad approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Just one we may want to consider using the attribute name or swapping to just _basic 👍

aws/data_source_aws_efs_mount_target_test.go Outdated Show resolved Hide resolved
@YakDriver YakDriver merged commit 924d97f into hashicorp:master Jul 18, 2020
@YakDriver YakDriver deleted the at003remaining branch July 18, 2020 03:32
@YakDriver YakDriver added this to the v2.70.1 milestone Jul 18, 2020
@ghost
Copy link

ghost commented Aug 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 17, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Aug 27, 2020
@breathingdust breathingdust modified the milestones: v2.70.1, v3.0.0 Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. provider Pertains to the provider itself, rather than any interaction with AWS. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/acmpca Issues and PRs that pertain to the acmpca service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appmesh Issues and PRs that pertain to the appmesh service. service/batch Issues and PRs that pertain to the batch service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/configservice Issues and PRs that pertain to the configservice service. service/directconnect Issues and PRs that pertain to the directconnect service. service/ec2 Issues and PRs that pertain to the ec2 service. service/efs Issues and PRs that pertain to the efs service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/kinesis Issues and PRs that pertain to the kinesis service. service/qldb Issues and PRs that pertain to the qldb service. service/ram Issues and PRs that pertain to the ram service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/sfn Issues and PRs that pertain to the sfn service. service/sns Issues and PRs that pertain to the sns service. service/waf Issues and PRs that pertain to the waf service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Fix and enable tfproviderlint AT003 check: Ensure acceptance test naming includes underscores
3 participants
@YakDriver @bflad @breathingdust