Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS SDK for Go s3manager dependency #14229

Closed
wants to merge 1 commit into from
Closed

Add AWS SDK for Go s3manager dependency #14229

wants to merge 1 commit into from

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Jul 17, 2020

Adds a dependency on the AWS SDK for Go's s3manager, and s3iface packages. These packages make the s3manager packages's GetBucketRegion utility available for discovering a S3 bucket's locations.

These packages are used by PR #14221.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14221
Relates #14217

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@jasdel
Add AWS SDK for Go s3manager dependency
7d12592 
Adds a dependency on the AWS SDK for Go's `s3manager`, and `s3iface`
packages. These packages make the s3manager packages's GetBucketRegion
utility available for discovering a S3 bucket's locations.

These packages are used by PR #14221.
@jasdel jasdel requested a review from a team July 17, 2020 16:50
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. dependencies Used to indicate dependency changes. labels Jul 17, 2020
@jasdel jasdel closed this Jul 17, 2020
@jasdel jasdel deleted the AddAWSSDKS3ManagerDep branch July 17, 2020 16:52
@ghost
Copy link

ghost commented Aug 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 16, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. partner Contribution from a partner. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasdel @breathingdust @justinretzolk