Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/route53_record: remove StateFunc handling of trailing period in name attribute #14297

Merged
merged 5 commits into from
Jul 27, 2020
Merged

resource/route53_record: remove StateFunc handling of trailing period in name attribute #14297

merged 5 commits into from
Jul 27, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jul 22, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13510

Release note for CHANGELOG:

resource/route53_record: remove StateFunc handling of trailing period in name attribute

Output from acceptance testing:

@anGie44 anGie44 requested a review from a team July 22, 2020 18:03
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/route53 Issues and PRs that pertain to the route53 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 22, 2020
@anGie44 anGie44 mentioned this pull request Jul 22, 2020
Merged
@anGie44 anGie44 force-pushed the b-route53-zone-domain branch from 79b9554 to 6b99c3c Compare July 24, 2020 00:01
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 27, 2020
@anGie44 anGie44 merged this pull request into b-route53-zone-domain Jul 27, 2020
@anGie44 anGie44 deleted the b-route53-record branch July 27, 2020 19:09
@ghost
Copy link

ghost commented Aug 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anGie44