Add support for WorkspaceCreationProperties #14332
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a fix for #12737, but acceptance tests fail due to aws/aws-sdk-go#3439 . Otherwise ready for review.
creation_properties
structure to definition.(resourceAwsWorkspacesDirectoryCreate(*schema.ResourceData, interface{})): Set WorkspaceCreationProperties during object creation.
(resourceAwsWorkspacesDirectoryRead(*schema.ResourceData, interface{})): Process WorkspaceCreationProperties and add to object.
(resourceAwsWorkspacesDirectoryUpdate(*schema.ResourceData, interface{})): Update WorkspaceCreationProperties if a delta exists.
(expandCreationProperties([]interface{})): Add helper function for packing the creation_properties struct.
(flattenCreationProperties(*workspaces.DefaultWorkspaceCreationProperties)): Add helper function for unpacking the DefaultWorkspaceCreationProperties structure
(TestExpandCreationProperties(*testing.T)): Add unit test for expandCreationProperties().
(TestFlattenCreationProperties(*testing.T)): Add unit test for flattenCreationProperties().
(testAccWorkspacesDirectoryConfigB(string)): Add additional resource (aws_security_group.outbound) and use in aws_workspaces_directory.main definition.
(testAccWorkspacesDirectoryConfigC(string)): Add additional properties to aws_workspaces_directory.main.
Community Note
Closes #12737
Release note for CHANGELOG:
Output from acceptance testing: