Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WorkspaceCreationProperties #14332

Closed

Conversation

ablackrw
Copy link
Contributor

@ablackrw ablackrw commented Jul 23, 2020

Implements a fix for #12737, but acceptance tests fail due to aws/aws-sdk-go#3439 . Otherwise ready for review.

  • aws/resource_aws_workspaces_directory.go (resourceAwsWorkspacesDirectory()): Add optional creation_properties structure to definition.
    (resourceAwsWorkspacesDirectoryCreate(*schema.ResourceData, interface{})): Set WorkspaceCreationProperties during object creation.
    (resourceAwsWorkspacesDirectoryRead(*schema.ResourceData, interface{})): Process WorkspaceCreationProperties and add to object.
    (resourceAwsWorkspacesDirectoryUpdate(*schema.ResourceData, interface{})): Update WorkspaceCreationProperties if a delta exists.
    (expandCreationProperties([]interface{})): Add helper function for packing the creation_properties struct.
    (flattenCreationProperties(*workspaces.DefaultWorkspaceCreationProperties)): Add helper function for unpacking the DefaultWorkspaceCreationProperties structure
  • resource_aws_workspaces_directory_test.go (TestAccAwsWorkspacesDirectory_basic(*testing.T)): Add additional attribute checks.
    (TestExpandCreationProperties(*testing.T)): Add unit test for expandCreationProperties().
    (TestFlattenCreationProperties(*testing.T)): Add unit test for flattenCreationProperties().
    (testAccWorkspacesDirectoryConfigB(string)): Add additional resource (aws_security_group.outbound) and use in aws_workspaces_directory.main definition.
    (testAccWorkspacesDirectoryConfigC(string)): Add additional properties to aws_workspaces_directory.main.
  • workspaces_directory.html.markdown: Add documentation on new creation_properties structure.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12737

Release note for CHANGELOG:

resource/aws_workspaces_directory: Add `creation_properties` attribute [GH-12737]

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

…12737

* aws/resource_aws_workspaces_directory.go (resourceAwsWorkspacesDirectory()): Add optional `creation_properties` structure to definition.
  (resourceAwsWorkspacesDirectoryCreate(*schema.ResourceData, interface{})): Set WorkspaceCreationProperties during object creation.
  (resourceAwsWorkspacesDirectoryRead(*schema.ResourceData, interface{})): Process WorkspaceCreationProperties and add to object.
  (resourceAwsWorkspacesDirectoryUpdate(*schema.ResourceData, interface{})): Update WorkspaceCreationProperties if a delta exists.
  (expandCreationProperties([]interface{})): Add helper function for packing the creation_properties struct.
  (flattenCreationProperties(*workspaces.DefaultWorkspaceCreationProperties)): Add helper function for unpacking the DefaultWorkspaceCreationProperties structure
* resource_aws_workspaces_directory_test.go (TestAccAwsWorkspacesDirectory_basic(*testing.T)): Add additional attribute checks.
  (TestExpandCreationProperties(*testing.T)): Add unit test for expandCreationProperties().
  (TestFlattenCreationProperties(*testing.T)): Add unit test for flattenCreationProperties().
  (testAccWorkspacesDirectoryConfigB(string)): Add additional resource (aws_security_group.outbound) and use in aws_workspaces_directory.main definition.
  (testAccWorkspacesDirectoryConfigC(string)): Add additional properties to aws_workspaces_directory.main.
* workspaces_directory.html.markdown: Add documentation on new creation_properties structure.
@ablackrw ablackrw requested a review from a team July 23, 2020 21:01
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 23, 2020
@Tensho
Copy link
Contributor

Tensho commented Dec 17, 2020

Duplicates #14577.

@Tensho Tensho closed this Dec 17, 2020
@ghost
Copy link

ghost commented Jan 16, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 16, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
@ablackrw ablackrw deleted the f-aws_workspaces_directory-12737 branch October 24, 2024 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/workspaces Issues and PRs that pertain to the workspaces service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ModifyWorkspaceCreationProperties support to aws_workspaces_directory
3 participants