Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppMesh timeout configuration support #14361

Merged
merged 17 commits into from
Oct 8, 2020
Merged

AppMesh timeout configuration support #14361

merged 17 commits into from
Oct 8, 2020

Commits on Oct 1, 2020

  1. r/aws_appmesh_route: Add support for retry policies.

    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    b5d8206 View commit details
    Browse the repository at this point in the history

  2. r/aws_appmesh_route: Add support for retry policies.

    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    7ec8be0 View commit details
    Browse the repository at this point in the history

  3. r/aws_appmesh_route: Support gRPC and HTTP/2 services.

    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    9120d0a View commit details
    Browse the repository at this point in the history

  4. r/aws_appmesh_route: Support gRPC and HTTP/2 services.

    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    e64113e View commit details
    Browse the repository at this point in the history

  5. r/aws_appmesh_virtual_router: Test gRPC and HTTP/2 listener protocols.

    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    9b7b246 View commit details
    Browse the repository at this point in the history

  6. r/aws_appmesh_route: Add gRPC route timeout configuration support. 

    Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/grpcRoute'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/grpcRoute -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
--- PASS: TestAccAWSAppmesh_serial (66.22s)
    --- PASS: TestAccAWSAppmesh_serial/Route (66.22s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (27.92s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (38.30s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.266s
    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    f6901c2 View commit details
    Browse the repository at this point in the history

  7. r/aws_appmesh_route: Add TCP route timeout configuration support. 

    Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/tcpRoute'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/tcpRoute -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRouteTimeout
--- PASS: TestAccAWSAppmesh_serial (64.63s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (0.00s)
    --- PASS: TestAccAWSAppmesh_serial/Route (64.63s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (37.42s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (27.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	64.686s
    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    3040745 View commit details
    Browse the repository at this point in the history

  8. r/aws_appmesh_route: Add HTTP and HTTP2 route timeout configuration s… 

    …upport.

Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/httpRoute'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/httpRoute -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
--- FAIL: TestAccAWSAppmesh_serial (40.30s)
    --- FAIL: TestAccAWSAppmesh_serial/Route (40.30s)
        --- FAIL: TestAccAWSAppmesh_serial/Route/httpRoute (12.26s)
            testing.go:684: Step 0 error: Check failed: Check 17/23 error: aws_appmesh_route.test: Attribute 'spec.0.http_route.0.timeout.#' expected "0", got "1"
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (28.03s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (0.00s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	40.353s
FAIL
GNUmakefile:26: recipe for target 'testacc' failed
make: *** [testacc] Error 1
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/http2Route'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/http2Route -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/Route/http2RouteTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
--- FAIL: TestAccAWSAppmesh_serial (40.79s)
    --- FAIL: TestAccAWSAppmesh_serial/Route (40.79s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (29.14s)
        --- FAIL: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (11.65s)
            testing.go:684: Step 0 error: Check failed: Check 17/27 error: aws_appmesh_route.test: Attribute 'spec.0.http2_route.0.timeout.#' expected "1", got "0"
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (0.00s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	40.836s
FAIL
GNUmakefile:26: recipe for target 'testacc' failed
make: *** [testacc] Error 1
    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    d7f9550 View commit details
    Browse the repository at this point in the history

  9. r/aws_appmesh_route: Fix HTTP and HTTP2 route timeout acceptance tests. 

    Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/httpRoute'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/httpRoute -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
--- PASS: TestAccAWSAppmesh_serial (66.64s)
    --- PASS: TestAccAWSAppmesh_serial/Route (66.64s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (27.84s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (38.80s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.726s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route/http2Route'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route/http2Route -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/http2RouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
--- PASS: TestAccAWSAppmesh_serial (56.66s)
    --- PASS: TestAccAWSAppmesh_serial/Route (56.65s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (28.57s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (28.08s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	56.732s
    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    9f3a7c5 View commit details
    Browse the repository at this point in the history

  10. r/aws_appmesh_route: Refactor timeout serde functions. 

    Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/Route'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/Route -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/http2RouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/httpHeader
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/tags
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh_serial/Route/routePriority
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/tags
--- PASS: TestAccAWSAppmesh_serial (433.25s)
    --- PASS: TestAccAWSAppmesh_serial/Route (379.45s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (38.84s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (27.86s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (27.77s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (28.29s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (38.87s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (28.38s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (27.92s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (39.58s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (27.67s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (28.10s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (27.74s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (38.42s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (53.80s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (22.61s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (31.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	433.309s
    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    e0c7d66 View commit details
    Browse the repository at this point in the history

  11. r/aws_appmesh_virtual_node: Add timeout configuration support. 

    Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
--- PASS: TestAccAWSAppmesh_serial (191.43s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (191.43s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (96.36s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (24.56s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (23.12s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (32.95s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (14.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	191.496s
    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    b5ee366 View commit details
    Browse the repository at this point in the history

  12. r/aws_appmesh_virtual_node: Add 'testAccAwsAppmeshVirtualNode_listene… 

    …rTimeout'.

Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode/listenerTimeout'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode/listenerTimeout -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
--- PASS: TestAccAWSAppmesh_serial (23.16s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (23.16s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (23.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	23.237s
    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    dbd6726 View commit details
    Browse the repository at this point in the history

  13. Fix compilation errors after rebase.

    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    b790b3b View commit details
    Browse the repository at this point in the history

  14. r/aws_appmesh_virtual_node: Use '_Values()' (hashicorp#14601). 

    r/aws_appmesh_route: Use '_Values()' (hashicorp#14601).
    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    0367605 View commit details
    Browse the repository at this point in the history

  15. r/aws_appmesh_virtual_node: Update resource testing and documentation… 

    … to 0.12 syntax.

r/aws_appmesh_route: Update resource testing and documentation to 0.12 syntax.

Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/Mesh
=== RUN   TestAccAWSAppmesh_serial/Mesh/egressFilter
=== RUN   TestAccAWSAppmesh_serial/Mesh/tags
=== RUN   TestAccAWSAppmesh_serial/Mesh/basic
=== RUN   TestAccAWSAppmesh_serial/Route
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRoute
=== RUN   TestAccAWSAppmesh_serial/Route/http2RouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/httpHeader
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/tags
=== RUN   TestAccAWSAppmesh_serial/Route/grpcRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/http2Route
=== RUN   TestAccAWSAppmesh_serial/Route/httpRetryPolicy
=== RUN   TestAccAWSAppmesh_serial/Route/httpRoute
=== RUN   TestAccAWSAppmesh_serial/Route/httpRouteTimeout
=== RUN   TestAccAWSAppmesh_serial/Route/routePriority
=== RUN   TestAccAWSAppmesh_serial/Route/tcpRoute
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualService
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualService/virtualRouter
=== RUN   TestAccAWSAppmesh_serial/VirtualService/tags
--- PASS: TestAccAWSAppmesh_serial (1146.96s)
    --- PASS: TestAccAWSAppmesh_serial/Mesh (98.83s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/egressFilter (39.94s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/tags (42.48s)
        --- PASS: TestAccAWSAppmesh_serial/Mesh/basic (16.41s)
    --- PASS: TestAccAWSAppmesh_serial/Route (531.21s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRoute (54.92s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2RouteTimeout (39.03s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpHeader (38.48s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRouteTimeout (37.89s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tags (55.83s)
        --- PASS: TestAccAWSAppmesh_serial/Route/grpcRouteTimeout (38.00s)
        --- PASS: TestAccAWSAppmesh_serial/Route/http2Route (38.65s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRetryPolicy (39.38s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRoute (55.40s)
        --- PASS: TestAccAWSAppmesh_serial/Route/httpRouteTimeout (38.97s)
        --- PASS: TestAccAWSAppmesh_serial/Route/routePriority (38.38s)
        --- PASS: TestAccAWSAppmesh_serial/Route/tcpRoute (56.25s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (278.40s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (33.86s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (33.93s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (35.61s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (49.14s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (19.31s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (106.55s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualRouter (112.07s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/basic (33.68s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualRouter/tags (78.38s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualService (126.44s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualNode (38.02s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/virtualRouter (34.64s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualService/tags (53.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1146.999s
    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    ab05641 View commit details
    Browse the repository at this point in the history

  16. Remove duplicate example in aws_appmesh_route documentation.

    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    d384377 View commit details
    Browse the repository at this point in the history

  17. Fixes after rebase.

    @ewbankkit
    ewbankkit committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    c14869d View commit details
    Browse the repository at this point in the history