Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_global_accelerator_endpoint_group: Client IP address preservation #14486

Merged
merged 14 commits into from
Aug 22, 2020
Merged

r/aws_global_accelerator_endpoint_group: Client IP address preservation #14486

merged 14 commits into from
Aug 22, 2020

Commits on Aug 21, 2020

  1. Add client_ip_preservation_enabled to global accelerator

    @ewbankkit
    Zuhaib Siddique authored and ewbankkit committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    f6d4924 View commit details
    Browse the repository at this point in the history

  2. commit test

    @ewbankkit
    Zuhaib Siddique authored and ewbankkit committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    cc0ddf9 View commit details
    Browse the repository at this point in the history

  3. r/aws_globalaccelerator_endpoint_group: Use 'tfawsresource.TestCheckT… 

    …ypeSetElemNestedAttrs'.
    @ewbankkit
    ewbankkit committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    07e66b9 View commit details
    Browse the repository at this point in the history

  4. r/aws_globalaccelerator_endpoint: Increase deployment wait time (hash… 

    …icorp#14161).
    @ewbankkit
    ewbankkit committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    fc7431d View commit details
    Browse the repository at this point in the history

  5. r/aws_globalaccelerator_endpoint_group: Make 'client_ip_preservation_… 

    …enabled' computed.
    @ewbankkit
    ewbankkit committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    eb188b0 View commit details
    Browse the repository at this point in the history

  6. r/aws_globalaccelerator_endpoint_group: Delete security group created… 

    … by Global Accelerator service in acceptance tests.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_ALB_ClientIP'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorEndpointGroup_ALB_ClientIP -timeout 120m
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_ALB_ClientIP
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_ALB_ClientIP
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_ALB_ClientIP
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_ALB_ClientIP (650.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	650.320s
    @ewbankkit
    ewbankkit committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    9a1f13a View commit details
    Browse the repository at this point in the history

  7. r/aws_globalaccelerator_endpoint_group: Document 'client_ip_preservat… 

    …ion_enabled'.
    @ewbankkit
    ewbankkit committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    02be4bc View commit details
    Browse the repository at this point in the history

  8. r/aws_globalaccelerator_endpoint_group: Add 'TestAccAwsGlobalAccelera… 

    …torEndpointGroup_InstanceEndpoint'.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint -timeout 120m
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
    testing.go:684: Step 0 error: errors during apply:

        Error: Error creating Global Accelerator endpoint group: InvalidArgumentException: Client IP Preservation cannot be set to false for EC2 instances

          on /tmp/tf-test004466997/main.tf line 86:
          (source code not available)

--- FAIL: TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint (133.29s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	133.338s
FAIL
GNUmakefile:26: recipe for target 'testacc' failed
make: *** [testacc] Error 1
    @ewbankkit
    ewbankkit committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    9a444be View commit details
    Browse the repository at this point in the history

  9. r/aws_globalaccelerator_endpoint_group: Simplify 'TestAccAwsGlobalAcc… 

    …eleratorEndpointGroup_basic'.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorEndpointGroup_basic -timeout 120m
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_basic
    testing.go:684: Step 0 error: After applying this step, the plan was not empty:

        DIFF:

        UPDATE: aws_globalaccelerator_endpoint_group.test
          endpoint_configuration.#:      "0" => "0"
          endpoint_group_region:         "us-west-2" => "us-west-2"
          health_check_interval_seconds: "30" => "30"
          health_check_path:             "" => "/"
          health_check_port:             "80" => ""
          health_check_protocol:         "TCP" => "TCP"
          id:                            "arn:aws:globalaccelerator::xxxxxxxxxxxx:accelerator/9e848383-b09a-4439-ac4f-eacb46aa04c0/listener/38d2eb59/endpoint-group/e84317b2d005" => "arn:aws:globalaccelerator::xxxxxxxxxxxx:accelerator/9e848383-b09a-4439-ac4f-eacb46aa04c0/listener/38d2eb59/endpoint-group/e84317b2d005"
          listener_arn:                  "arn:aws:globalaccelerator::xxxxxxxxxxxx:accelerator/9e848383-b09a-4439-ac4f-eacb46aa04c0/listener/38d2eb59" => "arn:aws:globalaccelerator::xxxxxxxxxxxx:accelerator/9e848383-b09a-4439-ac4f-eacb46aa04c0/listener/38d2eb59"
          threshold_count:               "3" => "3"
          traffic_dial_percentage:       "100" => "100"

        STATE:

        aws_globalaccelerator_accelerator.test:
          ID = arn:aws:globalaccelerator::xxxxxxxxxxxx:accelerator/9e848383-b09a-4439-ac4f-eacb46aa04c0
          provider = provider.aws
          attributes.# = 1
          attributes.0.flow_logs_enabled = false
          attributes.0.flow_logs_s3_bucket =
          attributes.0.flow_logs_s3_prefix =
          dns_name = a9225ffbbaaf25cce.awsglobalaccelerator.com
          enabled = false
          hosted_zone_id = Z2BJ6XQ5FK7U4H
          ip_address_type = IPV4
          ip_sets.# = 1
          ip_sets.0.ip_addresses.# = 2
          ip_sets.0.ip_addresses.0 = 75.2.20.133
          ip_sets.0.ip_addresses.1 = 99.83.169.50
          ip_sets.0.ip_family = IPv4
          name = tf-acc-test-809980946792323534
        aws_globalaccelerator_endpoint_group.test:
          ID = arn:aws:globalaccelerator::xxxxxxxxxxxx:accelerator/9e848383-b09a-4439-ac4f-eacb46aa04c0/listener/38d2eb59/endpoint-group/e84317b2d005
          provider = provider.aws
          endpoint_group_region = us-west-2
          health_check_interval_seconds = 30
          health_check_path =
          health_check_port = 80
          health_check_protocol = TCP
          listener_arn = arn:aws:globalaccelerator::xxxxxxxxxxxx:accelerator/9e848383-b09a-4439-ac4f-eacb46aa04c0/listener/38d2eb59
          threshold_count = 3
          traffic_dial_percentage = 100

          Dependencies:
            aws_globalaccelerator_listener.test
        aws_globalaccelerator_listener.test:
          ID = arn:aws:globalaccelerator::xxxxxxxxxxxx:accelerator/9e848383-b09a-4439-ac4f-eacb46aa04c0/listener/38d2eb59
          provider = provider.aws
          accelerator_arn = arn:aws:globalaccelerator::xxxxxxxxxxxx:accelerator/9e848383-b09a-4439-ac4f-eacb46aa04c0
          client_affinity = NONE
          port_range.# = 1
          port_range.0.from_port = 80
          port_range.0.to_port = 80
          protocol = TCP

          Dependencies:
            aws_globalaccelerator_accelerator.test
--- FAIL: TestAccAwsGlobalAcceleratorEndpointGroup_basic (179.82s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	179.872s
FAIL
GNUmakefile:26: recipe for target 'testacc' failed
make: *** [testacc] Error 1
    @ewbankkit
    ewbankkit committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    68df99d View commit details
    Browse the repository at this point in the history

  10. Fix health_check_path for GA TCP endpoint group 

    - Set `health_check_path` to Computed without Default
- Update documentation
    @ewbankkit
    LOU Xun authored and ewbankkit committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    55b0325 View commit details
    Browse the repository at this point in the history

  11. Update website/docs/r/globalaccelerator_endpoint_group.html.markdown 

    Co-authored-by: Brian Flad <bflad417@gmail.com>
    @ewbankkit @bflad
    ewbankkit and bflad committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    f8a112a View commit details
    Browse the repository at this point in the history

  12. r/aws_globalaccelerator_endpoint_group: Change 'health_check_port' to… 

    … Computed (hashicorp#12882).

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorEndpointGroup_basic -timeout 120m
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_basic
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (183.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	183.312s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_update'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorEndpointGroup_update -timeout 120m
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_update
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_update
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_update
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_update (241.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	241.856s
    @ewbankkit
    ewbankkit committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    fe4ef66 View commit details
    Browse the repository at this point in the history

  13. r/aws_globalaccelerator_endpoint_group: Add '_disappears' acceptance … 

    …test (hashicorp#13527, hashicorp#13826).

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorEndpointGroup_disappears -timeout 120m
=== RUN   TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== CONT  TestAccAwsGlobalAcceleratorEndpointGroup_disappears
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_disappears (191.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	191.883s
    @ewbankkit
    ewbankkit committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    0c49a06 View commit details
    Browse the repository at this point in the history

  14. r/aws_globalaccelerator_endpoint_group: Set 'client_ip_preservation_e… 

    …nabled' to 'true' for EC2 instance endpoint test.
    @ewbankkit
    ewbankkit committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    4178c84 View commit details
    Browse the repository at this point in the history