Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hardcoded availability zone issues (VPC-WOR) #14500

Closed
wants to merge 3 commits into from
Closed

Fix hardcoded availability zone issues (VPC-WOR) #14500

wants to merge 3 commits into from

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 7, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12995

Release note for CHANGELOG:

NONE

This PR takes on 3 tasks:

  1. Fix hardcoded AZs in 4 resources:
    • resource_aws_vpc_dhcp_options_test
    • resource_aws_vpc_endpoint_connection_notification_test
    • resource_aws_vpc_endpoint_service_allowed_principal_test
    • resource_aws_vpn_gateway_test.
  2. Fix config formatting in 4 resources:
    • resource_aws_vpc_dhcp_options_test
    • resource_aws_vpc_endpoint_connection_notification_test
    • resource_aws_vpc_endpoint_service_allowed_principal_test
    • resource_aws_vpn_gateway_test.
  3. Standardize use of testAccAvailableAZsNoOptInConfig() (defined in resource_aws_instance_test) to cut down on repetitive boilerplate of data source data "aws_availability_zones" "available".

The output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSDHCPOptions_disappears (9.26s)
--- PASS: TestAccAWSDHCPOptions_deleteOptions (9.28s)
--- PASS: TestAccAWSDHCPOptions_basic (12.75s)
--- PASS: TestAccAWSDHCPOptions_tags (28.80s)

The output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSDHCPOptions_deleteOptions (64.46s)
--- PASS: TestAccAWSDHCPOptions_disappears (64.68s)
--- PASS: TestAccAWSDHCPOptions_basic (71.05s)
--- PASS: TestAccAWSDHCPOptions_tags (93.62s)
--- SKIP: TestAccDataSourceAWSEIP_CustomerOwnedIpv4Pool (0.00s)
--- SKIP: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (0.00s)
--- SKIP: TestAccDataSourceAWSDirectoryServiceDirectory_connector (0.00s)
--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_NonExistent (1.29s)
--- FAIL: TestAccAWSAPIGatewayIntegrationResponse_basic (1.42s)
--- FAIL: TestAccAWSAPIGatewayRestApi_api_key_source (1.83s)
--- FAIL: TestAccDataSourceAwsEip_PublicIP_EC2Classic (1.94s)
--- FAIL: TestAccAWSAPIGatewayRestApi_openapi (2.88s)
--- FAIL: TestAccAWSAPIGatewayIntegration_disappears (3.00s)
--- FAIL: TestAccAWSAPIGatewayIntegration_basic (3.85s)
--- FAIL: TestAccDataSourceAwsSubnetIDs_basic (4.04s)
--- FAIL: TestAccDataSourceAwsSubnetIDs_filter (4.05s)
--- FAIL: TestAccAWSAPIGatewayRestApi_tags (4.79s)
--- FAIL: TestAccAWSAPIGatewayIntegrationResponse_disappears (4.94s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_PreferredInstanceTypes (5.18s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_Filter (5.45s)
--- FAIL: TestAccAWSAPIGatewayIntegration_cache_key_parameters (5.48s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingsDataSource_LocationType (6.05s)
--- PASS: TestAccAwsEc2SpotPriceDataSource_basic (6.09s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_interface (6.24s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_gateway (6.53s)
--- PASS: TestAccDataSourceAwsEip_Id (6.86s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_LocationType (6.94s)
--- PASS: TestAccDataSourceAwsEip_PublicIP_VPC (7.10s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent (7.12s)
--- PASS: TestAccDataSourceAwsEip_Filter (7.12s)
--- PASS: TestAccAWSEc2InstanceTypeOfferingDataSource_Filter (7.12s)
--- PASS: TestAccDataSourceAwsEip_Tags (7.14s)
--- FAIL: TestAccAWSAPIGatewayRestApi_basic (7.39s)
--- FAIL: TestAccAwsAutoScalingGroupDataSource_basic (7.48s)
--- PASS: TestAccAwsEc2SpotPriceDataSource_Filter (7.68s)
--- FAIL: TestAccAWSAPIGatewayRestApi_disappears (8.01s)
--- PASS: TestAccDataSourceAwsSubnet_basic (8.17s)
--- PASS: TestAccDataSourceAwsNetworkInterfaces_Filter (8.90s)
--- PASS: TestAccDataSourceAwsNetworkInterfaces_Tags (9.29s)
--- PASS: TestAccDataSourceAwsNetworkInterface_basic (9.53s)
--- PASS: TestAccDataSourceAwsNetworkInterface_filters (9.96s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (10.01s)
--- PASS: TestAccDataSourceAWSELB_basic (11.77s)
--- FAIL: TestAccAWSAPIGatewayIntegration_contentHandling (12.23s)
--- FAIL: TestAccAWSAPIGatewayRestApi_policy (13.56s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter (13.85s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock (14.59s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byId (17.03s)
--- FAIL: TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD (17.37s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayBasic (17.80s)
--- +PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (18.16s)
--- +PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (18.20s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byFilter (18.21s)
--- +PASS: TestAccDataSourceAwsAvailabilityZone_Filter (18.23s)
--- +PASS: TestAccDataSourceAwsAvailabilityZone_Name (18.24s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byTags (18.32s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags (18.99s)
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (19.81s)
--- PASS: TestAccDataSourceAwsEip_NetworkInterface (20.93s)
--- PASS: TestAccAWSEbsVolumeDataSource_basic (22.88s)
--- PASS: TestAccDataSourceAwsEbsVolumes_basic (27.14s)
--- PASS: TestAccAWSAMI_disappears (41.77s)
--- PASS: TestAccAWSEbsSnapshotDataSource_Filter (41.99s)
--- PASS: TestAccAWSAMI_basic (42.06s)
--- PASS: TestAccAWSEbsSnapshotDataSource_basic (42.39s)
--- FAIL: TestAccDataSourceAWSMqBroker_basic (42.57s)
--- PASS: TestAccAWSAMI_snapshotSize (42.60s)
--- PASS: TestAccAWSAMI_description (45.27s)
--- PASS: TestAccAWSAMI_tags (48.98s)
--- PASS: TestAccAWSEbsSnapshotDataSource_MostRecent (82.41s)
--- PASS: TestAccDataSourceAwsEip_Instance (85.28s)
--- PASS: TestAccAWSAutoscalingGroups_basic (97.31s)
--- PASS: TestAccDataSourceAwsEfsMountTarget_basic (118.90s)
--- PASS: TestAccDataSourceAWSLBListener_BackwardsCompatibility (156.35s)
--- PASS: TestAccDataSourceAWSALBTargetGroup_basic (158.06s)
--- PASS: TestAccDataSourceAWSLBTargetGroup_BackwardsCompatibility (158.72s)
--- FAIL: TestAccDataSourceAWSLBListener_https (160.63s)
--- PASS: TestAccDataSourceAWSLB_basic (165.31s)
--- PASS: TestAccDataSourceAWSLB_BackwardsCompatibility (166.54s)
--- PASS: TestAccDataSourceAWSLBListener_basic (168.65s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_interface (170.21s)
--- PASS: TestAccAWSDbClusterSnapshotDataSource_DbClusterSnapshotIdentifier (224.84s)
--- PASS: TestAccAWSDbClusterSnapshotDataSource_DbClusterIdentifier (225.28s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom (236.77s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter_tags (257.32s)
--- PASS: TestAccDataSourceCloudHsmV2Cluster_basic (267.01s)
--- PASS: TestAccDataSourceAwsVpcEndpointService_custom_filter (267.46s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (283.65s)
--- PASS: TestAccAWSDbClusterSnapshotDataSource_MostRecent (300.50s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_Filter (304.50s)
--- PASS: TestAccAWSEc2TransitGatewayVpcAttachmentDataSource_ID (304.84s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission (318.66s)
--- PASS: TestAccAWSAMILaunchPermission_basic (328.17s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_LaunchPermission_Public (329.01s)
--- PASS: TestAccAWSAMILaunchPermission_Disappears_AMI (331.73s)
--- PASS: TestAccAWSAMIFromInstance_tags (361.72s)
--- PASS: TestAccAWSAMICopy_EnaSupport (363.92s)
--- PASS: TestAccAWSAMICopy_basic (364.52s)
--- PASS: TestAccAWSAMICopy_Description (367.34s)
--- PASS: TestAccAWSAMICopy_tags (369.70s)
--- PASS: TestAccAWSAMIFromInstance_basic (381.56s)
--- FAIL: TestAccAWSAPIGatewayIntegration_integrationType (680.00s)
--- PASS: TestAccAWSDataElasticsearchDomain_basic (754.57s)
--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_ClusterMode (923.08s)
--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_basic (953.80s)
--- PASS: TestAccAWSDataElasticsearchDomain_advanced (1092.71s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD (1710.99s)

+ Originally failed on TC but fixed after

@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 7, 2020
@YakDriver YakDriver changed the title Fix r/DHCP Options Fix hardcoded availability zone issues (VPC-WOR) Aug 7, 2020
@ghost ghost added service/apigateway Issues and PRs that pertain to the apigateway service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/directoryservice service/efs Issues and PRs that pertain to the efs service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XXL Managed by automation to categorize the size of a PR. service/mq Issues and PRs that pertain to the mq service. service/rds Issues and PRs that pertain to the rds service. and removed size/S Managed by automation to categorize the size of a PR. labels Aug 7, 2020
@YakDriver YakDriver marked this pull request as ready for review August 7, 2020 15:51
@YakDriver YakDriver requested a review from a team August 7, 2020 15:51
@YakDriver YakDriver mentioned this pull request Aug 7, 2020
Closed
@ewbankkit ewbankkit mentioned this pull request Aug 8, 2020
Merged
@YakDriver YakDriver marked this pull request as draft August 11, 2020 18:53
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Aug 27, 2020
@YakDriver YakDriver closed this Nov 5, 2020
@YakDriver YakDriver deleted the td-hardaz-r-vpc-wor branch November 5, 2020 16:53
@ghost
Copy link

ghost commented Dec 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/apigateway Issues and PRs that pertain to the apigateway service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. service/efs Issues and PRs that pertain to the efs service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/mq Issues and PRs that pertain to the mq service. service/rds Issues and PRs that pertain to the rds service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@YakDriver