[WIP] resource/aws_db_instance: Apply parameter group update when launching an RDS snapshot

[jameshaak]

My first contribution, so go easy on me. 😉

Fixes #218.

Still need to:

• Reboot RDS instance to fully apply parameter group
• Rebase onto current master
• Update resource tests?

[radeksimko]

Hi @jameshaak
thanks for your contribution.
Sorry for the delay in reviewing this.

I don't think that we need to reboot the instance in order to apply this change. Just one thing to ask - do you mind adding an acceptance test which changes the parameter group name?

See an example of a test which is updating subnet group here:

https://github.com/terraform-providers/terraform-provider-aws/blob/07ff8a7e3059e5a09f0a6ccd845294abe97d8e1c/aws/resource_aws_db_instance_test.go#L124-L151

and feel free to apply the "copy-paste-modify" approach 😃

[jameshaak]

Closing this PR since I haven't had time to work on it, and I've implemented a non-Terraform work-around in my project.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!