r/aws_efs_file_system: Add support for backup_policy

[shuheiktgw]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14372

Release note for CHANGELOG:

r/aws_efs_file_system: Add support for backup_policy

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEFSFileSystem_backupPolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEFSFileSystem_backupPolicy -timeout 120m
=== RUN   TestAccAWSEFSFileSystem_backupPolicy
=== PAUSE TestAccAWSEFSFileSystem_backupPolicy
=== RUN   TestAccAWSEFSFileSystem_backupPolicy_update
=== PAUSE TestAccAWSEFSFileSystem_backupPolicy_update
=== RUN   TestAccAWSEFSFileSystem_backupPolicy_removal
=== PAUSE TestAccAWSEFSFileSystem_backupPolicy_removal
=== CONT  TestAccAWSEFSFileSystem_backupPolicy
=== CONT  TestAccAWSEFSFileSystem_backupPolicy_removal
=== CONT  TestAccAWSEFSFileSystem_backupPolicy_update
2020/08/16 14:17:54 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2020/08/16 14:17:54 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSEFSFileSystem_backupPolicy (59.05s)
--- PASS: TestAccAWSEFSFileSystem_backupPolicy_removal (91.88s)
--- PASS: TestAccAWSEFSFileSystem_backupPolicy_update (92.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	94.713s
...

Thank you for your review! 👍

[galindro]

Will this be available in 0.13 only?

[shuheiktgw]

@galindro I'm not particularly sure when this PR will be merged, but I think the latest terraform-aws-provider should still support terraform v0.12. So I guess you can use this feature with v0.12!

I recommend you check which terraform-aws-provider version this change will be bundled with and see if its compatibility with your terraform version once this PR is merged 👍

[anatrizna]

Hi @shuheiktgw ,

I am using:
Terraform v0.13.5
aws v2.57.0

And when I try to use backup_policy, terraform validate fails with error:
$ terraform validate
Error: Unsupported argument
on aws/02-efs.tf line 4, in resource "aws_efs_file_system" "efs_file_system":
4: backup_policy = {
An argument named "backup_policy" is not expected here.
ERROR: Job failed: exit code 1

Do you think this is issue with my environment? Or feature is not yet implemented?

resource "aws_efs_file_system" "foo" {
creation_token = "my-product"
backup_policy = {
status = "ENABLED"
}
}

Anastasija

[cageyv]

Hi @anatrizna ,
this function is awaiting a merge.
But you can clone this repository with these changes and change branch and build the provider locally, then try the function

[lirlia]

I really hope this exciting function!!

[felipesere]

This looks really nice. Anything we can do to get this over the line?

[DrFaust92]

Hi, while this doesn’t suffer from the same issue as IAM policy maybe it will be more appropriate to move this to a separate resource more similar to. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/efs_file_system_policy

[sporokh]

Any estimates on the PR merge?

[shuheiktgw]

@DrFaust92 Ah, that makes sense. Let me move this into a separate resource!

[shuheiktgw]

I've created a new PR #18006 to make it a separate resource, so I'll close this one.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!