Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/provider: Update hardcoded AZs (DocDB cluster instance) #14921

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 31, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12995

Release note for CHANGELOG:

NONE

Output from acceptance testing (GovCloud partition):

--- PASS: TestAccAWSDocDBClusterInstance_basic (541.30s)

Output from acceptance testing (commercial/standard partition):

Kommer snart...

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/databasemigrationservice service/docdb Issues and PRs that pertain to the docdb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 31, 2020
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Aug 31, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Sep 1, 2020
@YakDriver YakDriver force-pushed the t-hardaz-docdb branch 2 times, most recently from 90694ef to 05b726d Compare September 3, 2020 14:24
@YakDriver YakDriver marked this pull request as ready for review September 3, 2020 14:25
@YakDriver YakDriver requested a review from a team September 3, 2020 14:25
@YakDriver YakDriver changed the title tests/provider: Update hardcoded AZs (DocDB related) tests/provider: Update hardcoded AZs (DocDB cluster instance) Sep 3, 2020
@bflad bflad self-assigned this Sep 10, 2020
bflad
bflad previously requested changes Sep 11, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looking good. 👍

aws/resource_aws_docdb_cluster_instance_test.go Outdated Show resolved Hide resolved
@YakDriver
Copy link
Member Author

YakDriver commented Sep 11, 2020

Errant test (yikes!):

--- PASS: TestAccAWSDocDBClusterInstance_namePrefix (666.01s)

@YakDriver YakDriver force-pushed the t-hardaz-docdb branch 2 times, most recently from 789a034 to 6c72284 Compare September 11, 2020 23:03
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSDocDBClusterInstance_generatedName (498.41s)
--- PASS: TestAccAWSDocDBClusterInstance_az (579.42s)
--- PASS: TestAccAWSDocDBClusterInstance_disappears (605.85s)
--- PASS: TestAccAWSDocDBClusterInstance_namePrefix (611.02s)
--- PASS: TestAccAWSDocDBClusterInstance_kmsKey (627.32s)
--- PASS: TestAccAWSDocDBClusterInstance_basic (660.49s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSDocDBClusterInstance_generatedName (491.53s)
--- PASS: TestAccAWSDocDBClusterInstance_disappears (524.09s)
--- PASS: TestAccAWSDocDBClusterInstance_kmsKey (621.14s)
--- PASS: TestAccAWSDocDBClusterInstance_basic (628.17s)
--- PASS: TestAccAWSDocDBClusterInstance_namePrefix (653.41s)
--- PASS: TestAccAWSDocDBClusterInstance_az (661.07s)

@YakDriver YakDriver added this to the v3.7.0 milestone Sep 14, 2020
@YakDriver YakDriver merged commit d58b8a3 into master Sep 14, 2020
@YakDriver YakDriver deleted the t-hardaz-docdb branch September 14, 2020 19:46
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 3.7.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/docdb Issues and PRs that pertain to the docdb service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants