Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/provider: Fix hardcoded AZs (docdb cluster) #15004

Merged
merged 1 commit into from
Sep 8, 2020
Merged

tests/provider: Fix hardcoded AZs (docdb cluster) #15004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 101 additions & 51 deletions aws/resource_aws_docdb_cluster_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,10 +597,16 @@ func testAccCheckDocDBClusterSnapshot(rInt int) resource.TestCheckFunc {
}

func testAccDocDBClusterConfig(n int) string {
return fmt.Sprintf(`
return composeConfig(testAccAvailableAZsNoOptInConfig(), fmt.Sprintf(`
resource "aws_docdb_cluster" "default" {
cluster_identifier = "tf-docdb-cluster-%d"
availability_zones = ["us-west-2a", "us-west-2b", "us-west-2c"]
cluster_identifier = "tf-docdb-cluster-%d"

availability_zones = [
data.aws_availability_zones.available.names[0],
data.aws_availability_zones.available.names[1],
data.aws_availability_zones.available.names[2]
]

master_username = "foo"
master_password = "mustbeeightcharaters"
db_cluster_parameter_group_name = "default.docdb3.6"
Expand All @@ -615,7 +621,7 @@ resource "aws_docdb_cluster" "default" {
"profiler",
]
}
`, n)
`, n))
}

func testAccDocDBClusterConfig_namePrefix() string {
Expand All @@ -640,37 +646,55 @@ resource "aws_docdb_cluster" "test" {
}

func testAccDocDBClusterConfigWithFinalSnapshot(n int) string {
return fmt.Sprintf(`
return composeConfig(testAccAvailableAZsNoOptInConfig(), fmt.Sprintf(`
resource "aws_docdb_cluster" "default" {
cluster_identifier = "tf-docdb-cluster-%d"
availability_zones = ["us-west-2a", "us-west-2b", "us-west-2c"]
cluster_identifier = "tf-docdb-cluster-%[1]d"

availability_zones = [
data.aws_availability_zones.available.names[0],
data.aws_availability_zones.available.names[1],
data.aws_availability_zones.available.names[2]
]

master_username = "foo"
master_password = "mustbeeightcharaters"
db_cluster_parameter_group_name = "default.docdb3.6"
final_snapshot_identifier = "tf-acctest-docdbcluster-snapshot-%d"
final_snapshot_identifier = "tf-acctest-docdbcluster-snapshot-%[1]d"

tags = {
Environment = "production"
}
}
`, n, n)
`, n))
}

func testAccDocDBClusterConfigWithoutUserNameAndPassword(n int) string {
return fmt.Sprintf(`
return composeConfig(testAccAvailableAZsNoOptInConfig(), fmt.Sprintf(`
resource "aws_docdb_cluster" "default" {
cluster_identifier = "tf-docdb-cluster-%d"
availability_zones = ["us-west-2a", "us-west-2b", "us-west-2c"]
cluster_identifier = "tf-docdb-cluster-%d"

availability_zones = [
data.aws_availability_zones.available.names[0],
data.aws_availability_zones.available.names[1],
data.aws_availability_zones.available.names[2]
]

skip_final_snapshot = true
}
`, n)
`, n))
}

func testAccDocDBClusterConfigUpdatedTags(n int) string {
return fmt.Sprintf(`
return composeConfig(testAccAvailableAZsNoOptInConfig(), fmt.Sprintf(`
resource "aws_docdb_cluster" "default" {
cluster_identifier = "tf-docdb-cluster-%d"
availability_zones = ["us-west-2a", "us-west-2b", "us-west-2c"]
cluster_identifier = "tf-docdb-cluster-%d"

availability_zones = [
data.aws_availability_zones.available.names[0],
data.aws_availability_zones.available.names[1],
data.aws_availability_zones.available.names[2]
]

master_username = "foo"
master_password = "mustbeeightcharaters"
db_cluster_parameter_group_name = "default.docdb3.6"
Expand All @@ -681,14 +705,20 @@ resource "aws_docdb_cluster" "default" {
AnotherTag = "test"
}
}
`, n)
`, n))
}

func testAccDocDBClusterNoCloudwatchLogsConfig(n int) string {
return fmt.Sprintf(`
return composeConfig(testAccAvailableAZsNoOptInConfig(), fmt.Sprintf(`
resource "aws_docdb_cluster" "default" {
cluster_identifier = "tf-docdb-cluster-%d"
availability_zones = ["us-west-2a", "us-west-2b", "us-west-2c"]
cluster_identifier = "tf-docdb-cluster-%d"

availability_zones = [
data.aws_availability_zones.available.names[0],
data.aws_availability_zones.available.names[1],
data.aws_availability_zones.available.names[2]
]

master_username = "foo"
master_password = "mustbeeightcharaters"
db_cluster_parameter_group_name = "default.docdb3.6"
Expand All @@ -698,14 +728,15 @@ resource "aws_docdb_cluster" "default" {
Environment = "production"
}
}
`, n)
`, n))
}

func testAccDocDBClusterConfig_kmsKey(n int) string {
return fmt.Sprintf(`
return composeConfig(testAccAvailableAZsNoOptInConfig(), fmt.Sprintf(`
resource "aws_kms_key" "foo" {
description = "Terraform acc test %d"
policy = <<POLICY
description = "Terraform acc test %[1]d"

policy = <<POLICY
{
"Version": "2012-10-17",
"Id": "kms-tf-1",
Expand All @@ -725,51 +756,74 @@ POLICY
}

resource "aws_docdb_cluster" "default" {
cluster_identifier = "tf-docdb-cluster-%d"
availability_zones = ["us-west-2a", "us-west-2b", "us-west-2c"]
cluster_identifier = "tf-docdb-cluster-%[1]d"
availability_zones = [
data.aws_availability_zones.available.names[0],
data.aws_availability_zones.available.names[1],
data.aws_availability_zones.available.names[2]
]

master_username = "foo"
master_password = "mustbeeightcharaters"
db_cluster_parameter_group_name = "default.docdb3.6"
storage_encrypted = true
kms_key_id = aws_kms_key.foo.arn
skip_final_snapshot = true
}
`, n, n)
`, n))
}

func testAccDocDBClusterConfig_encrypted(n int) string {
return fmt.Sprintf(`
return composeConfig(testAccAvailableAZsNoOptInConfig(), fmt.Sprintf(`
resource "aws_docdb_cluster" "default" {
cluster_identifier = "tf-docdb-cluster-%d"
availability_zones = ["us-west-2a", "us-west-2b", "us-west-2c"]
cluster_identifier = "tf-docdb-cluster-%d"

availability_zones = [
data.aws_availability_zones.available.names[0],
data.aws_availability_zones.available.names[1],
data.aws_availability_zones.available.names[2]
]

master_username = "foo"
master_password = "mustbeeightcharaters"
storage_encrypted = true
skip_final_snapshot = true
}
`, n)
`, n))
}

func testAccDocDBClusterConfig_backups(n int) string {
return fmt.Sprintf(`
return composeConfig(testAccAvailableAZsNoOptInConfig(), fmt.Sprintf(`
resource "aws_docdb_cluster" "default" {
cluster_identifier = "tf-docdb-cluster-%d"
availability_zones = ["us-west-2a", "us-west-2b", "us-west-2c"]
cluster_identifier = "tf-docdb-cluster-%d"

availability_zones = [
data.aws_availability_zones.available.names[0],
data.aws_availability_zones.available.names[1],
data.aws_availability_zones.available.names[2]
]

master_username = "foo"
master_password = "mustbeeightcharaters"
backup_retention_period = 5
preferred_backup_window = "07:00-09:00"
preferred_maintenance_window = "tue:04:00-tue:04:30"
skip_final_snapshot = true
}
`, n)
`, n))
}

func testAccDocDBClusterConfig_backupsUpdate(n int) string {
return fmt.Sprintf(`
return composeConfig(testAccAvailableAZsNoOptInConfig(), fmt.Sprintf(`
resource "aws_docdb_cluster" "default" {
cluster_identifier = "tf-docdb-cluster-%d"
availability_zones = ["us-west-2a", "us-west-2b", "us-west-2c"]
cluster_identifier = "tf-docdb-cluster-%d"

availability_zones = [
data.aws_availability_zones.available.names[0],
data.aws_availability_zones.available.names[1],
data.aws_availability_zones.available.names[2]
]

master_username = "foo"
master_password = "mustbeeightcharaters"
backup_retention_period = 10
Expand All @@ -778,22 +832,18 @@ resource "aws_docdb_cluster" "default" {
apply_immediately = true
skip_final_snapshot = true
}
`, n)
`, n))
}

func testAccDocDBClusterConfig_Port(rInt, port int) string {
return fmt.Sprintf(`
data "aws_availability_zones" "available" {
state = "available"

filter {
name = "opt-in-status"
values = ["opt-in-not-required"]
}
}

return composeConfig(testAccAvailableAZsNoOptInConfig(), fmt.Sprintf(`
resource "aws_docdb_cluster" "test" {
availability_zones = [data.aws_availability_zones.available.names[0], data.aws_availability_zones.available.names[1], data.aws_availability_zones.available.names[2]]
availability_zones = [
data.aws_availability_zones.available.names[0],
data.aws_availability_zones.available.names[1],
data.aws_availability_zones.available.names[2]
]

cluster_identifier = "tf-acc-test-%d"
db_cluster_parameter_group_name = "default.docdb3.6"
engine = "docdb"
Expand All @@ -802,7 +852,7 @@ resource "aws_docdb_cluster" "test" {
port = %d
skip_final_snapshot = true
}
`, rInt, port)
`, rInt, port))
}

func testAccDocDBClusterConfigDeleteProtection(isProtected bool) string {
Expand Down