Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign group name (not id) to group argument #15041

Conversation

alan-copeland-keysight
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Closes #15040 

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@alan-copeland-keysight alan-copeland-keysight requested a review from a team September 4, 2020 22:16
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. labels Sep 4, 2020
@alan-copeland-keysight
Copy link
Contributor Author

Addresses #15040

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Sep 9, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the change is innocuous since the aws_iam_group resource id attribute is already the group name, this would future proof any potential change to that value (should it ever be changed to match the unique_id attribute, for example).

@bflad bflad merged commit bc480ff into hashicorp:master Sep 9, 2020
@bflad bflad added this to the v3.6.0 milestone Sep 9, 2020
@ghost
Copy link

ghost commented Sep 11, 2020

This has been released in version 3.6.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation - iam_group_policy example incorrectly assigns group.id (not group.name) to the group argument
2 participants