Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables Organizations policy import AWS-managed acceptance test #15554

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Enables Organizations policy import AWS-managed acceptance test #15554

merged 1 commit into from
Oct 14, 2020

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Oct 7, 2020

Enables Organizations policy import AWS-managed acceptance test which required Plugin SDK 2.0.4

Relates #15446

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSOrganizations_serial/Policy/ImportAwsManagedPolicy'

--- PASS: TestAccAWSOrganizations_serial (61.59s)
    --- PASS: TestAccAWSOrganizations_serial/Policy (61.59s)
        --- PASS: TestAccAWSOrganizations_serial/Policy/ImportAwsManagedPolicy (61.59s)

@gdavison gdavison requested a review from a team October 7, 2020 22:10
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/organizations Issues and PRs that pertain to the organizations service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 7, 2020
@YakDriver YakDriver assigned YakDriver and unassigned YakDriver Oct 14, 2020
@bflad bflad self-assigned this Oct 14, 2020
bflad
bflad approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

Output from acceptance testing:

        --- PASS: TestAccAWSOrganizations_serial/Policy/ImportAwsManagedPolicy (21.61s)

@gdavison gdavison merged commit 3631e7f into master Oct 14, 2020
@gdavison gdavison deleted the b-prevent-importing-organization-policy-2 branch October 14, 2020 22:20
@ghost
Copy link

ghost commented Nov 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/organizations Issues and PRs that pertain to the organizations service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdavison @bflad @YakDriver