Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_s3control_bucket_policy #15575

Merged
merged 5 commits into from
Oct 27, 2020
Merged

New Resource: aws_s3control_bucket_policy #15575

merged 5 commits into from
Oct 27, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 9, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Requires #15468
Reference: #15412
Closes #15416

Release note for CHANGELOG:

* **New Resource:** `aws_s3control_bucket_policy`

Output from acceptance testing:

--- PASS: TestAccAWSS3ControlBucketPolicy_disappears (32.85s)
--- PASS: TestAccAWSS3ControlBucketPolicy_Policy (43.13s)
--- PASS: TestAccAWSS3ControlBucketPolicy_basic (106.91s)

@bflad bflad added new-resource Introduces a new resource. service/s3control Issues and PRs that pertain to the s3control service. labels Oct 9, 2020
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 9, 2020
@bflad bflad marked this pull request as ready for review October 9, 2020 23:38
@bflad bflad requested a review from a team October 9, 2020 23:38
@bflad bflad force-pushed the f-aws_s3control_bucket_policy branch from 20fcda5 to 7a60eed Compare October 12, 2020 17:28
bflad added 3 commits October 16, 2020 15:09
@bflad
New Resource: aws_s3control_bucket_policy
c663667 
Reference: #15412
Reference: #15416

Output from acceptance testing:

```
Pending
```
@bflad
tests/resource/aws_s3control_bucket_policy: Fixes since Public Access…
81818e6 
… Block is always enabled for S3 Control Buckets

Output from acceptance testing:

```
--- PASS: TestAccAWSS3ControlBucketPolicy_disappears (32.85s)
--- PASS: TestAccAWSS3ControlBucketPolicy_Policy (43.13s)
--- PASS: TestAccAWSS3ControlBucketPolicy_basic (106.91s)
```
@bflad
resource/aws_s3control_bucket_policy: terrafmt fixes
69fc2d5
@bflad bflad force-pushed the f-aws_s3control_bucket_policy branch from 7a60eed to 69fc2d5 Compare October 16, 2020 19:10
anGie44
anGie44 approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment re: the CheckDestroy, otherwise LGTM 🚀

aws/resource_aws_s3control_bucket_policy_test.go Outdated
Comment on lines 117 to 127
if tfawserr.ErrCodeEquals(err, "NoSuchBucket") {
return nil
}

if tfawserr.ErrCodeEquals(err, "NoSuchBucketPolicy") {
return nil
}

if tfawserr.ErrCodeEquals(err, "NoSuchOutpost") {
return nil
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar comment here as in #15510 to continue through the loop

@bflad bflad added this to the v3.13.0 milestone Oct 27, 2020
@bflad bflad merged commit 24b5475 into master Oct 27, 2020
@bflad bflad deleted the f-aws_s3control_bucket_policy branch October 27, 2020 20:31
bflad added a commit that referenced this pull request Oct 27, 2020
@bflad
Update CHANGELOG for #15575
edac249
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3control Issues and PRs that pertain to the s3control service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.

New Resource: aws_s3control_bucket_policy
2 participants
@bflad @anGie44