Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_sns_topic_subscription cross account without have access to both accounts #15597

Closed

Conversation

smailli
Copy link

@smailli smailli commented Oct 11, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes 10225
Relates OR Closes 7782

Release note for CHANGELOG:

aws_sns_topic_subscription cross account without have access to both accounts
Provide full support to HTTP/HTTPS/EMAIL/EMAIL-JSON protocols

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSNSTopicSubscription_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSNSTopicSubscription_basic -timeout 120m
=== RUN   TestAccAWSSNSTopicSubscription_basic
=== PAUSE TestAccAWSSNSTopicSubscription_basic
=== CONT  TestAccAWSSNSTopicSubscription_basic
--- PASS: TestAccAWSSNSTopicSubscription_basic (53.84s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       53.887s



$ make testacc TESTARGS='-run=TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint -timeout 120m
=== RUN   TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint
=== PAUSE TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint
=== CONT  TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (95.07s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       95.125s
...

@smailli smailli requested a review from a team October 11, 2020 01:37
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/sns Issues and PRs that pertain to the sns service. labels Oct 11, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 11, 2020
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Oct 11, 2020
@smailli smailli changed the title aws_sns_topic_subscription without need Assume Role in both Accounts aws_sns_topic_subscription Cross Account without Assume Role Oct 11, 2020
@smailli smailli changed the title aws_sns_topic_subscription Cross Account without Assume Role aws_sns_topic_subscription cross account without have access to both accounts Oct 11, 2020
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Oct 12, 2020
@smailli smailli closed this Oct 14, 2020
@ghost
Copy link

ghost commented Nov 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/sns Issues and PRs that pertain to the sns service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
3 participants