-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_s3control_bucket_lifecycle_configuration #15604
Conversation
35bae7c
to
2572c32
Compare
Reference: #15412 Reference: #15415 Output from acceptance testing (note everything except AbortIncompleteMultipartUpload was tested before losing Outpost access): ``` --- PASS: TestAccAWSS3ControlBucketLifecycleConfiguration_basic (59.06s) --- PASS: TestAccAWSS3ControlBucketLifecycleConfiguration_disappears (59.96s) --- PASS: TestAccAWSS3ControlBucketLifecycleConfiguration_Rule_Expiration_Date (70.35s) --- PASS: TestAccAWSS3ControlBucketLifecycleConfiguration_Rule_Expiration_Days (57.63s) --- PASS: TestAccAWSS3ControlBucketLifecycleConfiguration_Rule_Filter_Prefix (64.31s) --- PASS: TestAccAWSS3ControlBucketLifecycleConfiguration_Rule_Filter_Tags (62.22s) --- PASS: TestAccAWSS3ControlBucketLifecycleConfiguration_Rule_Id (73.91s) --- PASS: TestAccAWSS3ControlBucketLifecycleConfiguration_Rule_Status (65.70s) ```
2572c32
to
736ca48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- just a couple small q's and noting updating an existing tags
key:value pair may be affected by the open issue in the AWS SDK(aws/aws-sdk-go#3591)
aws/resource_aws_s3control_bucket_lifecycle_configuration_test.go
Outdated
Show resolved
Hide resolved
} | ||
|
||
func TestAccAWSS3ControlBucketLifecycleConfiguration_Rule_Expiration_ExpiredObjectDeleteMarker(t *testing.T) { | ||
TestAccSkip(t, "S3 on Outposts does not error or save it in the API when receiving this parameter") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given this behavior - should this be documented in the resource docs for users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully my out of band answer sufficed here, but we can certainly add this post merge if necessary. 👍
ValidateFunc: func(v interface{}, k string) (ws []string, errors []error) { | ||
value := v.(string) | ||
|
||
_, err := time.Parse("2006-01-02", value) | ||
|
||
if err != nil { | ||
errors = append(errors, fmt.Errorf("%q should be in YYYY-MM-DD date format", value)) | ||
} | ||
|
||
return | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could also live in validators.go
? or possibly getting too large to keep populating ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partially related to #8424 -- although in this case its something that would ultimately be a good candidate for there (or a similar shared location) if it had more usage than just here and the aws_s3_bucket
resource. 👍
This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Reference: aws/aws-sdk-go#3591
Reference: #15412
Requires #15468
Requires #15510
Closes #15415
Release note for CHANGELOG:
Output from acceptance testing (note everything except AbortIncompleteMultipartUpload was tested before losing Outpost access):