Enhancement/cloudwatch event target adding validation

aws/resource_aws_cloudwatch_event_target.go

@@ -216,6 +216,10 @@ func resourceAwsCloudWatchEventTarget() *schema.Resource {
 							Type:     schema.TypeMap,
 							Optional: true,
 							Elem:     &schema.Schema{Type: schema.TypeString},
+							ValidateFunc: validation.All(
+								MapLenBetween(0, 10),
+								MapKeyNotMatch(regexp.MustCompile(`^AWS.*$`), "input_path must not start with \"AWS\""),
+							),
 						},
 						"input_template": {
 							Type:         schema.TypeString,

aws/resource_aws_cloudwatch_event_target_test.go

@@ -1107,14 +1107,31 @@ resource "aws_cloudwatch_event_target" "test" {
   input_transformer {
     input_paths = {
       time = "$.time"
+      severity : "$.detail.severity",
+      Finding_ID : "$.detail.id",
+      instanceId : "$.detail.resource.instanceDetails.instanceId",
+      port : "$.detail.service.action.networkConnectionAction.localPortDetails.port",
+      eventFirstSeen : "$.detail.service.eventFirstSeen",
+      eventLastSeen : "$.detail.service.eventLastSeen",
+      count : "$.detail.service.count",
+      Finding_Type : "$.detail.type",
+      region : "$.region",
     }
 
     input_template = <<EOF
 {
   "detail-type": "Scheduled Event",
   "source": "aws.events",
   "time": <time>,
-  "region": "eu-west-1",
+  "severity": <severity>,
+  "Finding_ID": <Finding_ID>,
+  "instanceId": <instanceId>,
+  "port": <port>,
+  "eventFirstSeen": <eventFirstSeen>,
+  "eventLastSeen": <eventLastSeen>,
+  "count": <count>,
+  "Finding_Type": <Finding_Type>,
+  "region": <region>,
   "detail": {}
 }
 EOF

aws/validators.go

@@ -2466,3 +2466,37 @@ func validateNestedExactlyOneOf(m map[string]interface{}, valid []string) error
 	}
 	return nil
 }
+
+func MapLenBetween(min, max int) schema.SchemaValidateFunc {
+	return func(i interface{}, k string) (warnings []string, errors []error) {
+		m, ok := i.(map[string]interface{})
+		if !ok {
+			errors = append(errors, fmt.Errorf("expected type of %s to be map", k))
+			return warnings, errors
+		}
+
+		if len(m) < min || len(m) > max {
+			errors = append(errors, fmt.Errorf("expected length of %s to be in the range (%d - %d), got %d", k, min, max, len(m)))
+		}
+
+		return warnings, errors
+	}
+}
+
+func MapKeyNotMatch(r *regexp.Regexp, message string) schema.SchemaValidateFunc {
+	return func(i interface{}, k string) (warnings []string, errors []error) {
+		m, ok := i.(map[string]interface{})
+		if !ok {
+			errors = append(errors, fmt.Errorf("expected type of %s to be map", k))
+			return warnings, errors
+		}
+
+		for key := range m {
+			if ok := r.MatchString(key); ok {
+				errors = append(errors, fmt.Errorf("%s: %s: %s", k, message, key))
+			}
+		}
+
+		return warnings, errors
+	}
+}

website/docs/r/cloudwatch_event_target.html.markdown

@@ -301,6 +301,10 @@ For more information, see [Task Networking](https://docs.aws.amazon.com/AmazonEC
 `input_transformer` support the following:
 
 * `input_paths` - (Optional) Key value pairs specified in the form of JSONPath (for example, time = $.time)
+    * You can have as many as 10 key-value pairs.
+    * You must use JSON dot notation, not bracket notation.
+    * The keys can't start with "AWS".
+
 * `input_template` - (Required) Structure containing the template body.
 
 ## Import