Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Lint ignore hardcoded (StorageGateway) #15682

Merged
merged 1 commit into from
Oct 16, 2020
Merged

tests/provider: Lint ignore hardcoded (StorageGateway) #15682

merged 1 commit into from
Oct 16, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 16, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15662

Release note for CHANGELOG:

NONE

No code changes. Only adds lintignore.

The output from acceptance testing (GovCloud):

kommer snart

The output from acceptance testing (commercial):

kommer snart

@YakDriver YakDriver requested a review from a team October 16, 2020 15:46
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 16, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Oct 16, 2020
@YakDriver YakDriver mentioned this pull request Oct 16, 2020
Closed
69 tasks
bflad
bflad approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YakDriver YakDriver added this to the v3.12.0 milestone Oct 16, 2020
@YakDriver YakDriver merged commit 18fbdff into master Oct 16, 2020
@YakDriver YakDriver deleted the t-gov-hardarn-storagegateway branch October 16, 2020 18:25
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@breathingdust breathingdust added the linter Pertains to changes to or issues with the various linters. label Oct 27, 2020
@ghost
Copy link

ghost commented Nov 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. partition/aws-us-gov Pertains to the aws-us-gov partition. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@YakDriver @bflad @breathingdust