Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Fix hardcoded (S resources) #15693

Merged
merged 1 commit into from
Oct 21, 2020
Merged

tests/provider: Fix hardcoded (S resources) #15693

merged 1 commit into from
Oct 21, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 16, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15662

Release note for CHANGELOG:

NONE

Output from acceptance testing (GovCloud) (4 failures, no regressions):

--- PASS: TestDecodeResourceAwsSnsPlatformApplicationID (0.09s)
--- SKIP: TestAccAWSSnsPlatformApplication_basicAttributes (0.00s)
--- SKIP: TestAccAWSSnsPlatformApplication_iamRoleAttributes (0.00s)
--- SKIP: TestAccAWSSnsPlatformApplication_basic (0.00s)
--- SKIP: TestAccAWSSnsPlatformApplication_snsTopicAttributes (0.00s)
--- FAIL: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (35.15s)
--- FAIL: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (42.52s)
--- PASS: TestAccAWSSNSTopicPolicy_basic (48.95s)
--- PASS: TestAccAWSSNSTopicSubscription_basic (49.07s)
--- PASS: TestAccAWSSNSTopic_basic (55.48s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (55.97s)
--- PASS: TestAccAWSSNSTopic_name (56.90s)
--- PASS: TestAccAWSSNSTopic_policy (57.33s)
--- PASS: TestAccAWSSNSTopic_namePrefix (57.50s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (61.42s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (93.26s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (93.28s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (93.92s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (117.82s) ***
--- PASS: TestAccAWSSNSTopic_encryption (61.27s)
--- PASS: TestAccAWSSNSTopic_tags (64.82s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (140.79s)
--- FAIL: TestAccAWSSNSTopic_deliveryStatus (140.43s)
--- PASS: TestAccAWSSpotFleetRequest_basic (128.39s)
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (131.26s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (130.47s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (132.51s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (133.43s)
--- PASS: TestAccAWSSpotFleetRequest_tags (164.27s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (122.67s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (122.66s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (109.06s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (108.93s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (227.26s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (232.50s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (117.22s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (122.23s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (122.65s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (223.79s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (213.56s)
--- SKIP: TestAccAWSSpotFleetRequest_WithInstanceStoreAmi (0.00s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (150.56s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (112.68s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears_queue (8.71s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (156.26s)
--- PASS: TestAccAWSSQSQueuePolicy_basic (29.02s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears (23.81s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (138.12s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (140.57s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (89.36s)
--- PASS: TestAccAWSSQSQueue_namePrefix (71.89s)
--- PASS: TestAccAWSSQSQueue_policy (28.25s)***
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (223.25s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (228.67s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (159.49s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (354.16s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (162.27s)
--- PASS: TestAccAWSSQSQueue_namePrefix_fifo (65.05s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (133.16s)
--- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (12.31s)
--- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (13.64s)
--- FAIL: TestAccAWSSQSQueue_basic (121.28s)
--- PASS: TestAccAWSSQSQueue_redrivePolicy (44.43s)
--- PASS: TestAccAWSSQSQueue_Policybasic (47.38s)
--- PASS: TestAccAWSSQSQueue_FIFO (43.28s)
--- PASS: TestAccAWSSQSQueue_queueDeletedRecently (89.72s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (175.14s)
--- PASS: TestAccAWSSQSQueue_tags (133.00s)
--- PASS: TestAccAWSSQSQueue_Encryption (39.15s)
--- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (41.25s)
--- PASS: TestAccAWSSSMActivation_basic (46.16s)
--- PASS: TestAccAWSSSMActivation_expirationDate (45.84s)
--- PASS: TestAccAWSSsmResourceDataSync_basic (36.10s)
--- PASS: TestAccAWSSSMActivation_disappears (37.34s)
--- PASS: TestAccAWSSSMActivation_update (55.30s)
--- PASS: TestAccAWSSsmResourceDataSync_update (35.69s)
--- PASS: TestAccAWSSpotFleetRequest_zero_capacity (223.87s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (251.47s)

Output from acceptance testing (commercial) (0 failures, no regressions):

--- PASS: TestDecodeResourceAwsSnsPlatformApplicationID (0.12s)
--- SKIP: TestAccAWSSnsPlatformApplication_basicAttributes (0.00s)
--- SKIP: TestAccAWSSnsPlatformApplication_snsTopicAttributes (0.00s)
--- SKIP: TestAccAWSSnsPlatformApplication_basic (0.00s)
--- SKIP: TestAccAWSSnsPlatformApplication_iamRoleAttributes (0.00s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (25.76s) ***
--- PASS: TestAccAWSSNSTopicPolicy_basic (61.56s)
--- PASS: TestAccAWSSNSTopicSubscription_basic (65.32s)
--- PASS: TestAccAWSSNSTopic_namePrefix (71.02s)
--- PASS: TestAccAWSSNSTopic_policy (71.18s)
--- PASS: TestAccAWSSNSTopic_basic (73.30s)
--- PASS: TestAccAWSSNSTopic_name (74.51s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (75.39s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (124.54s) ***
--- PASS: TestAccAWSSNSTopic_deliveryStatus (81.60s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (93.81s)
--- PASS: TestAccAWSSNSTopic_encryption (106.84s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (116.26s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (117.71s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (118.28s)
--- PASS: TestAccAWSSNSTopic_tags (118.51s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (126.42s)
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (143.57s)
--- PASS: TestAccAWSSpotFleetRequest_basic (148.97s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (150.57s)
--- PASS: TestAccAWSSpotFleetRequest_tags (182.04s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (156.13s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (146.13s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (150.96s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (142.37s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (147.85s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (129.90s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (126.47s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (134.21s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (132.07s)
--- SKIP: TestAccAWSSpotFleetRequest_WithInstanceStoreAmi (0.00s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (125.05s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (131.82s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (130.94s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (169.51s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (170.54s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears_queue (12.63s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (79.38s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears (19.39s)
--- PASS: TestAccAWSSQSQueuePolicy_basic (33.93s)
--- PASS: TestAccAWSSQSQueue_namePrefix (27.91s)
--- PASS: TestAccAWSSQSQueue_policy (20.57s) ***
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (270.85s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (268.19s)
--- PASS: TestAccAWSSQSQueue_namePrefix_fifo (46.30s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (276.35s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (269.17s)
--- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (18.63s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (153.63s)
--- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (20.48s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (158.89s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (159.30s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (166.84s)
--- PASS: TestAccAWSSQSQueue_redrivePolicy (63.26s)
--- PASS: TestAccAWSSQSQueue_Policybasic (68.37s)
--- PASS: TestAccAWSSQSQueue_queueDeletedRecently (86.58s)
--- PASS: TestAccAWSSQSQueue_FIFO (55.05s)
--- PASS: TestAccAWSSQSQueue_basic (110.42s)
--- PASS: TestAccAWSSQSQueue_tags (110.79s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (140.54s)
--- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (53.01s)
--- PASS: TestAccAWSSQSQueue_Encryption (41.38s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (222.56s)
--- PASS: TestAccAWSSSMActivation_disappears (43.69s)
--- PASS: TestAccAWSSsmResourceDataSync_basic (40.00s)
--- PASS: TestAccAWSSSMActivation_expirationDate (55.65s)
--- PASS: TestAccAWSSSMActivation_basic (56.69s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (192.59s)
--- PASS: TestAccAWSSSMActivation_update (65.55s)
--- PASS: TestAccAWSSsmResourceDataSync_update (57.06s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (392.19s)
--- PASS: TestAccAWSSpotFleetRequest_zero_capacity (236.25s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (320.35s)

***Fixed after TeamCity run, tested locally

@YakDriver YakDriver requested a review from a team October 16, 2020 21:27
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 16, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Oct 16, 2020
@YakDriver YakDriver mentioned this pull request Oct 16, 2020
Closed
69 tasks
anGie44
anGie44 approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@YakDriver YakDriver added this to the v3.12.0 milestone Oct 21, 2020
@YakDriver YakDriver merged commit 2b60acd into master Oct 21, 2020
@YakDriver YakDriver deleted the t-gov-hardarn-s-res branch October 21, 2020 15:22
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @anGie44