Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent aws_ec2_client_vpn_authorization_rule exception when aws_ec2_client_vpn_endpoint is not found #15699

Closed
wants to merge 1 commit into from
Closed

Prevent aws_ec2_client_vpn_authorization_rule exception when aws_ec2_client_vpn_endpoint is not found #15699

wants to merge 1 commit into from

Conversation

wparad
Copy link
Contributor

@wparad wparad commented Oct 17, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
Prevent aws_ec2_client_vpn_authorization_rule from throwing the error InvalidClientVpnEndpointId.NotFound the case that the linked resource aws_ec2_client_vpn_endpoint does not exist.

@wparad wparad requested a review from a team October 17, 2020 10:09
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Oct 17, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 17, 2020
@wparad wparad changed the title Client vpn endpoint not found implies authorization rule does not exists Prevent authorization_rule exception when client vpn endpoint is not found Oct 17, 2020
@wparad wparad changed the title Prevent authorization_rule exception when client vpn endpoint is not found Prevent authorization_rule exception when aws_ec2_client_vpn_endpoint is not found Oct 17, 2020
@wparad wparad changed the title Prevent authorization_rule exception when aws_ec2_client_vpn_endpoint is not found Prevent aws_ec2_client_vpn_authorization_rule exception when aws_ec2_client_vpn_endpoint is not found Oct 17, 2020
Base automatically changed from master to main January 23, 2021 00:59
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:59
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 16, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@ewbankkit ewbankkit mentioned this pull request Jan 31, 2022
Merged
@ewbankkit
Copy link
Contributor

Superseded by #20688.

@ewbankkit
Copy link
Contributor

@wparad Thanks for the contribution 🎉 👏.
I have incorporated your changes into #20688.

@ewbankkit ewbankkit closed this Jan 31, 2022
ewbankkit added a commit to joeperks/terraform-provider-aws that referenced this pull request Jan 31, 2022
@ewbankkit
r/aws_ec2_client_vpn_authorization_rule: Tidy up and check for `Inval…
b89cb8e 
…idClientVpnEndpointId.NotFound` in `FindClientVPNAuthorizationRules` (hashicorp#15699).

Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule -timeout 180m
=== RUN   TestAccEC2ClientVPNEndpoint_serial
=== PAUSE TestAccEC2ClientVPNEndpoint_serial
=== CONT  TestAccEC2ClientVPNEndpoint_serial
=== RUN   TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets
=== RUN   TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears
=== RUN   TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== RUN   TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic
=== RUN   TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups
=== PAUSE TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups
=== CONT  TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets
=== CONT  TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic
=== CONT  TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint
=== CONT  TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups
=== CONT  TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears
--- PASS: TestAccEC2ClientVPNEndpoint_serial (1.11s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappearsEndpoint (57.33s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_disappears (61.52s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_basic (68.40s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_subnets (99.99s)
    --- PASS: TestAccEC2ClientVPNEndpoint_serial/AuthorizationRule_groups (125.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        130.096s
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wparad @zhelding @ewbankkit @breathingdust