Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Enable AWSAT005 #15751

Merged
merged 1 commit into from
Oct 28, 2020
Merged

tests/provider: Enable AWSAT005 #15751

merged 1 commit into from
Oct 28, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 20, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15662 🎉 🥳 🎊 😀

DO NOT MERGE UNTIL ALL PRs LINKED TO #15662 ARE MERGED.

Release note for CHANGELOG:

NONE

Output from acceptance testing: N/A

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. labels Oct 20, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Oct 20, 2020
@YakDriver YakDriver mentioned this pull request Oct 20, 2020
Closed
69 tasks
@YakDriver YakDriver marked this pull request as ready for review October 28, 2020 17:18
@YakDriver YakDriver requested a review from a team October 28, 2020 17:18
@YakDriver YakDriver force-pushed the t-gov-hardarn-enable-awsat005 branch from 97f4cb8 to 65212c5 Compare October 28, 2020 17:19
@YakDriver YakDriver force-pushed the t-gov-hardarn-enable-awsat005 branch from 65212c5 to 1bcfe24 Compare October 28, 2020 17:21
bflad
bflad approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@YakDriver YakDriver merged commit 0676ad2 into master Oct 28, 2020
@YakDriver YakDriver deleted the t-gov-hardarn-enable-awsat005 branch October 28, 2020 17:29
@YakDriver YakDriver added this to the v3.13.0 milestone Oct 28, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.

Ignore/Fix and Enable awsproviderlint AWSAT005 Hardcoded partition in ARN
2 participants
@YakDriver @bflad