Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeStar Connections service client #15960

Merged

Conversation

shuheiktgw
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15453, #12637, #11389

Release note for CHANGELOG:

None

Output from acceptance testing:

$ go test ./aws

ok  	github.com/terraform-providers/terraform-provider-aws/aws	20.391s

I took over the original PR and started integrating CodeStar Connections. Thank you for your review!

@shuheiktgw shuheiktgw requested a review from a team November 1, 2020 23:53
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. labels Nov 1, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 1, 2020
Co-authored-by: Kévin Sénéchal <kevin.senechal@gmail.com>
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing will fix up on merge, otherwise looks good to me, thanks @shuheiktgw 🚀

.hashibot.hcl Outdated Show resolved Hide resolved
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Nov 2, 2020
@bflad bflad self-assigned this Nov 2, 2020
@bflad bflad added this to the v3.14.0 milestone Nov 2, 2020
@bflad bflad merged commit 3feebb2 into hashicorp:master Nov 2, 2020
@shuheiktgw
Copy link
Collaborator Author

Thank you!

@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants