Add waiter functions for CloudFormation Stack and CloudFormation Stack Set operations

[gdavison]

Add waiter function for CloudFormation Stack and CloudFormation Stack Set operations

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudFormationStackSetInstance_\|TestAccAWSCloudFormationStackSet_\|TestAccAWSS3Bucket_tagsWithSystemTags'

--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Delete (194.51s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Rollback (218.42s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (288.99s)
--- PASS: TestAccAWSCloudFormationStack_disappears (314.48s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (348.60s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_DoNothing (174.23s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (387.48s)
--- PASS: TestAccAWSCloudFormationStack_defaultParams (402.39s)
--- PASS: TestAccAWSCloudFormationStack_yaml (422.50s)
--- PASS: TestAccAWSCloudFormationStack_withTransform (424.94s)
--- PASS: TestAccAWSCloudFormationStack_UpdateFailure (437.46s)
--- PASS: TestAccAWSCloudFormationStack_basic (267.91s)
--- PASS: TestAccAWSCloudFormationStack_allAttributes (499.19s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (519.21s)
--- PASS: TestAccAWSCloudFormationStack_withParams (563.59s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (567.65s)

--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (382.56s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (386.45s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (456.71s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (634.84s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (715.05s)

--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (610.68s)

[YakDriver]

Looking good! It would be great to fix the GovCloud failures or at the least create an issue to keep track of them. Any idea why they're failing?

GovCloud:

    data_source_aws_cloudformation_stack_test.go:16: Step 1/1 error: Error running pre-apply plan: 
        Error: Failed describing CloudFormation stack (tf-acc-ds-basic-2236090032908526147): ValidationError: Stack with id tf-acc-ds-basic-2236090032908526147 does not exist
        	status code: 400, request id: a80d6b1a-8c4b-4c33-8791-b6fc5b04556b        
--- FAIL: TestAccAWSCloudFormationStack_dataSource_basic (9.36s)

    data_source_aws_cloudformation_stack_test.go:101: Step 1/1 error: Error running pre-apply plan: 
        Error: Failed describing CloudFormation stack (tf-acc-ds-yaml-3809812790318265158): ValidationError: Stack with id tf-acc-ds-yaml-3809812790318265158 does not exist
        	status code: 400, request id: 59e1cf8b-2683-444c-a613-7409d02f8641        
--- FAIL: TestAccAWSCloudFormationStack_dataSource_yaml (6.66s)

--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Delete (20.46s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_DoNothing (33.95s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Rollback (34.80s)
--- PASS: TestAccAWSCloudFormationStack_withTransform (61.92s)
--- PASS: TestAccAWSCloudFormationStack_disappears (80.33s)
--- PASS: TestAccAWSCloudFormationStack_basic (82.07s)
--- PASS: TestAccAWSCloudFormationStack_yaml (86.09s)
--- PASS: TestAccAWSCloudFormationStack_defaultParams (90.91s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (99.28s)
--- PASS: TestAccAWSCloudFormationStack_UpdateFailure (108.29s)
--- PASS: TestAccAWSCloudFormationStack_allAttributes (121.55s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (121.74s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (122.13s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (127.92s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (137.74s)
--- PASS: TestAccAWSCloudFormationStack_withParams (155.75s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (170.92s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (192.56s)
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (195.36s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (266.74s)

Commercial:

--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Delete (26.96s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_DoNothing (37.96s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Rollback (38.94s)
--- PASS: TestAccAWSCloudFormationStack_disappears (82.52s)
--- PASS: TestAccAWSCloudFormationStack_defaultParams (89.19s)
--- PASS: TestAccAWSCloudFormationStack_withTransform (69.50s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (100.74s)
--- PASS: TestAccAWSCloudFormationStack_allAttributes (106.56s)
--- PASS: TestAccAWSCloudFormationStack_yaml (107.24s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (113.49s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (115.81s)
--- PASS: TestAccAWSCloudFormationStack_UpdateFailure (117.53s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (121.77s)
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (91.27s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears_StackSet (132.90s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_disappears (134.95s)
--- PASS: TestAccAWSCloudFormationStack_withParams (136.10s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_basic (140.85s)
--- PASS: TestAccAWSCloudFormationStack_basic (143.56s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (152.80s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_RetainStack (168.47s)
--- PASS: TestAccAWSCloudFormationStackSetInstance_ParameterOverrides (248.49s)

[YakDriver]

NOTE: These 2 tests are not compatible with TF 0.13.5. Locally I was running 0.13.5 and TC runs 0.12.29 so that explains the difference. The tests work fine in GovCloud on 0.12.29:

--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (74.11s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (73.09s)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!