Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't destroy instance on user_data #16011

Closed

Conversation

rogerhu
Copy link
Contributor

@rogerhu rogerhu commented Nov 4, 2020

This PR is a rebase from #7863 with an acceptance test.

@rogerhu rogerhu requested a review from a team as a code owner November 4, 2020 08:32
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 4, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 4, 2020
@rogerhu rogerhu force-pushed the rogerh/ec2-instance-userdata-update branch from 4925eb7 to c4945d2 Compare November 4, 2020 15:24
@rogerhu
Copy link
Contributor Author

rogerhu commented Nov 11, 2020

Friendly ping on this one =)

@rogerhu
Copy link
Contributor Author

rogerhu commented Nov 26, 2020

Can someone take a look?

@VLZZZ
Copy link

VLZZZ commented Jan 16, 2021

Looking forward to be reviewed

Base automatically changed from master to main January 23, 2021 00:59
@rogerhu
Copy link
Contributor Author

rogerhu commented Mar 11, 2021

Issuing a new PR off the master branch: #18043

@rogerhu rogerhu closed this Mar 11, 2021
@ghost
Copy link

ghost commented Apr 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants