Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/resource/aws_instance: Remove hardcoded us-east-1 handling #16035

Merged
merged 1 commit into from
Nov 11, 2020
Merged

tests/resource/aws_instance: Remove hardcoded us-east-1 handling #16035

merged 1 commit into from
Nov 11, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #8316
Reference: #15737
Reference: #15791

Release note for CHANGELOG:

NONE

Previously in AWS GovCloud (US):

=== RUN   TestAccAWSInstance_inEc2Classic
TestAccAWSInstance_inEc2Classic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid.
  status code: 403, request id: 23aa824d-1186-4ea7-803b-4d857190e77c  []}]
--- FAIL: TestAccAWSInstance_inEc2Classic (0.71s)

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSInstance_inEc2Classic (96.92s)

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccAWSInstance_inEc2Classic (2.79s)

@bflad
tests/resource/aws_instance: Remove hardcoded us-east-1 handling
1747069 
Reference: #8316
Reference: #15737
Reference: #15791

Previously in AWS GovCloud (US):

```
=== RUN   TestAccAWSInstance_inEc2Classic
TestAccAWSInstance_inEc2Classic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid.
  status code: 403, request id: 23aa824d-1186-4ea7-803b-4d857190e77c  []}]
--- FAIL: TestAccAWSInstance_inEc2Classic (0.71s)
```

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSInstance_inEc2Classic (96.92s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- SKIP: TestAccAWSInstance_inEc2Classic (2.79s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 5, 2020
@bflad bflad requested a review from a team as a code owner November 5, 2020 00:39
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 5, 2020
@bflad bflad mentioned this pull request Nov 5, 2020
Closed
@YakDriver YakDriver self-assigned this Nov 10, 2020
@YakDriver
Copy link
Member

YakDriver commented Nov 10, 2020 •
edited
Loading

One flaky failure. Re-ran fine on commercial:

Commercial:

--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (82.55s)
--- PASS: TestAccAWSInstanceDataSource_SecurityGroups (92.05s)
--- PASS: TestAccAWSInstanceDataSource_privateIP (92.49s)
--- PASS: TestAccAWSInstanceDataSource_basic (95.77s)
--- PASS: TestAccAWSInstanceDataSource_AzUserData (95.79s)
--- PASS: TestFetchRootDevice (0.09s)
--- PASS: TestAccAWSInstanceDataSource_VPC (99.79s)
--- PASS: TestAccAWSInstanceDataSource_tags (103.27s)
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (104.69s)
--- SKIP: TestAccAWSInstance_inEc2Classic (0.00s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (128.45s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (132.54s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_InvalidIopsForVolumeType (11.39s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (161.65s)
--- PASS: TestAccAWSInstancesDataSource_tags (78.26s)
--- PASS: TestAccAWSInstance_basic (73.51s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (84.75s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (7.89s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (187.58s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (92.26s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (67.02s)
--- PASS: TestAccAWSInstanceDataSource_secondaryPrivateIPs (198.97s)
--- PASS: TestAccAWSInstanceDataSource_keyPair (206.18s)
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (209.12s)
--- SKIP: TestAccAWSInstance_outpost (0.00s)
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (73.31s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (10.26s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (229.36s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (70.64s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (62.92s)
--- PASS: TestAccAWSInstance_atLeastOneOtherEbsVolume (165.44s)
--- PASS: TestAccAWSInstance_blockDevices (90.94s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (72.25s)
--- PASS: TestAccAWSInstance_dedicatedInstance (93.13s)
--- PASS: TestAccAWSInstancesDataSource_instance_state_names (198.55s)
--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (294.35s)
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (297.04s)
--- PASS: TestAccAWSInstancesDataSource_basic (209.03s)
--- PASS: TestAccAWSInstance_disableApiTermination (109.23s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (80.35s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (85.58s)
--- PASS: TestAccAWSInstance_sourceDestCheck (127.10s)
--- PASS: TestAccAWSInstance_rootInstanceStore (131.11s)
--- PASS: TestAccAWSInstanceDataSource_blockDevices (327.86s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (86.61s)
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (341.05s)
--- PASS: TestAccAWSInstance_userDataBase64 (202.82s)
--- PASS: TestAccAWSInstance_privateIP (72.07s)
--- PASS: TestAccAWSInstance_tags (100.46s)
--- PASS: TestAccAWSInstance_EbsRootDevice_basic (62.32s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (88.05s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (85.34s)
--- PASS: TestAccAWSInstance_keyPairCheck (79.46s)
--- PASS: TestAccAWSInstance_Empty_PrivateIP (86.30s)
--- PASS: TestAccAWSInstance_volumeTags (115.05s)
--- FAIL: TestAccAWSInstance_instanceProfileChange (119.96s)
--- PASS: TestAccAWSInstanceDataSource_metadataOptions (331.83s)
--- PASS: TestAccAWSInstance_volumeTagsComputed (132.82s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (197.09s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (141.43s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (91.04s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io2 (93.39s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (133.82s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (95.45s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (173.56s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS_Io1 (144.24s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (163.37s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (115.23s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (122.69s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (133.36s)
--- PASS: TestAccAWSInstance_placementGroup (316.29s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyAll (154.74s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (67.45s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (81.95s)
--- PASS: TestAccAWSInstance_addSecondaryInterface (165.61s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (147.83s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (83.22s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPs (115.11s)
--- PASS: TestAccAWSInstance_changeInstanceType (256.37s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (201.69s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPsUpdate (136.96s)
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (73.37s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PrivateIPAndSecondaryPrivateIPsUpdate (144.69s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (89.80s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (92.39s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (93.58s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (92.04s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (150.10s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (79.19s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (92.87s)
--- PASS: TestInstanceHostIDSchema (0.04s)
--- PASS: TestInstanceCpuCoreCountSchema (0.05s)
--- PASS: TestInstanceCpuThreadsPerCoreSchema (0.06s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (188.56s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (111.58s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (171.20s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (193.53s)
--- PASS: TestAccAWSInstance_disappears (65.79s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (203.64s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (102.24s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (119.75s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_EmptyPrivateIPAndSecondaryPrivateIPs (305.85s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (78.92s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (110.38s)
--- PASS: TestAccAWSInstance_metadataOptions (98.27s)
--- PASS: TestAccAWSInstance_hibernation (127.37s)
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (317.22s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (303.61s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (312.97s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (406.60s)
--- PASS: TestAccAWSInstance_NewNetworkInterface_PublicIPAndSecondaryPrivateIPs (603.96s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (497.29s)

Commercial re-run:

--- PASS: TestAccAWSInstance_instanceProfileChange (193.58s)

YakDriver
YakDriver approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯

GovCloud:

--- SKIP: TestAccAWSInstance_inEc2Classic (2.78s)

@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Nov 11, 2020
@bflad bflad added this to the v3.15.0 milestone Nov 11, 2020
@bflad bflad merged commit 394fa67 into master Nov 11, 2020
@bflad bflad deleted the t-aws_instance-ec2-classic branch November 11, 2020 00:49
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @YakDriver