Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/resource/aws_security_group: Remove hardcoded us-east-1 handling #16036

Merged
merged 1 commit into from
Nov 11, 2020

Commits on Nov 5, 2020

  1. tests/resource/aws_security_group: Remove hardcoded us-east-1 handling

    Reference: #8316
    Reference: #15737
    Reference: #15791
    
    Previously in AWS GovCloud (US):
    
    ```
    === RUN   TestAccAWSSecurityGroup_defaultEgressClassic
    TestAccAWSSecurityGroup_defaultEgressClassic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid.
      status code: 403, request id: 80bb55a7-5ac8-46b6-8c39-cf4f09bb4cd5  []}]
    --- FAIL: TestAccAWSSecurityGroup_defaultEgressClassic (0.50s)
    
    === RUN   TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic
    TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic: provider_test.go:184: [{0 error configuring Terraform AWS Provider: error validating provider credentials: error calling sts:GetCallerIdentity: InvalidClientTokenId: The security token included in the request is invalid.
      status code: 403, request id: 9909088a-dd37-40db-8774-2ea613dd1b3d  []}]
    --- FAIL: TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic (0.50s)
    ```
    
    Output from acceptance testing in AWS Commercial:
    
    ```
    --- PASS: TestAccAWSSecurityGroup_defaultEgressClassic (12.50s)
    --- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic (14.84s)
    ```
    
    Output from acceptance testing in AWS GovCloud (US):
    
    ```
    --- SKIP: TestAccAWSSecurityGroup_defaultEgressClassic (2.90s)
    --- SKIP: TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic (2.90s)
    ```
    bflad committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    a60ed99 View commit details
    Browse the repository at this point in the history